Git-Mirrors/keepassxc
1
0
Fork 0
mirror of https://github.com/keepassxreboot/keepassxc.git synced 2025-03-08 14:25:54 -05:00
Code Issues Packages Projects Releases Wiki Activity

Enhance readability when accessing static members

Browse Source 
The sole purpose of a few objects was calling a static member of the
class they belonged to. This is not needed, as you can access a static
member with the <class_name>::<member_name> notation.
This commit is contained in:
Gianluca Recchia 2018-10-28 14:29:57 +01:00
parent da9afd3f6f
commit 7208635502
No known key found for this signature in database
GPG Key ID: 3C2B4128D9A1F218
3 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/autotype/AutoType.cpp
View File

@ -731,8 +731,7 @@ bool AutoType::checkHighRepetition(const QString& string)
bool AutoType::verifyAutoTypeSyntax(const QString& sequence) bool AutoType::verifyAutoTypeSyntax(const QString& sequence)
{ {
if (!AutoType::checkSyntax(sequence)) { if (!AutoType::checkSyntax(sequence)) {
QMessageBox messageBox; QMessageBox::critical(nullptr, tr("Auto-Type"), tr("The Syntax of your Auto-Type statement is incorrect!"));
messageBox.critical(nullptr, tr("Auto-Type"), tr("The Syntax of your Auto-Type statement is incorrect!"));
return false; return false;
} else if (AutoType::checkHighDelay(sequence)) { } else if (AutoType::checkHighDelay(sequence)) {
QMessageBox::StandardButton reply; QMessageBox::StandardButton reply;

3
src/gui/entry/EditEntryWidget.cpp
View File

@ -1311,8 +1311,7 @@ void EditEntryWidget::pickColor()
oldColor = QColor(m_advancedUi->bgColorButton->property("color").toString()); oldColor = QColor(m_advancedUi->bgColorButton->property("color").toString());
} }
QColorDialog colorDialog(this); QColor newColor = QColorDialog::getColor(oldColor);
QColor newColor = colorDialog.getColor(oldColor);
if (newColor.isValid()) { if (newColor.isValid()) {
setupColorButton(isForeground, newColor); setupColorButton(isForeground, newColor);
setUnsavedChanges(true); setUnsavedChanges(true);

2
src/sshagent/BinaryStream.cpp
View File

@ -151,7 +151,7 @@ bool BinaryStream::readString(QString& str)
return false; return false;
} }
str = str.fromLatin1(ba); str = QString::fromLatin1(ba);
return true; return true;
} }