Git-Mirrors/keepassxc
1
0
Fork 0
mirror of https://github.com/keepassxreboot/keepassxc.git synced 2025-01-26 14:36:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix access denied errors when using KeeShare export/sync (#7322)

Browse Source
This commit is contained in:
Jonathan White 2022-01-28 21:28:01 -05:00 committed by GitHub
parent bce8c84c26
commit 6a12f450e6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/keeshare/ShareExport.cpp
View File

@ -155,13 +155,6 @@ ShareObserver::Result ShareExport::intoContainer(const QString& resolvedPath,
const KeeShareSettings::Reference& reference, const KeeShareSettings::Reference& reference,
const Group* group) const Group* group)
{ {
QFile file(resolvedPath);
const bool fileOpened = file.open(QIODevice::WriteOnly);
if (!fileOpened) {
qWarning("Opening export file failed");
return {resolvedPath, ShareObserver::Result::Error, file.errorString()};
}
QScopedPointer<Database> targetDb(extractIntoDatabase(reference, group)); QScopedPointer<Database> targetDb(extractIntoDatabase(reference, group));
if (resolvedPath.endsWith(".kdbx.share")) { if (resolvedPath.endsWith(".kdbx.share")) {
// Write database to memory and sign it // Write database to memory and sign it

2
src/keeshare/ShareImport.cpp
View File

@ -47,7 +47,6 @@ ShareObserver::Result ShareImport::containerInto(const QString& resolvedPath,
const KeeShareSettings::Reference& reference, const KeeShareSettings::Reference& reference,
Group* targetGroup) Group* targetGroup)
{ {
// TODO: Read signing certificate as well, but don't check validity
QByteArray dbData; QByteArray dbData;
auto uf = unzOpen64(resolvedPath.toLatin1().constData()); auto uf = unzOpen64(resolvedPath.toLatin1().constData());
@ -71,6 +70,7 @@ ShareObserver::Result ShareImport::containerInto(const QString& resolvedPath,
return {reference.path, ShareObserver::Result::Error, file.errorString()}; return {reference.path, ShareObserver::Result::Error, file.errorString()};
} }
dbData = file.readAll(); dbData = file.readAll();
file.close();
} }
QBuffer buffer(&dbData); QBuffer buffer(&dbData);