Git-Mirrors/keepassxc
1
0
Fork 0
mirror of https://github.com/keepassxreboot/keepassxc.git synced 2025-01-14 08:50:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

Create history item when setting up a TOTP seed, resolves #1445

Browse Source
This commit is contained in:
Janek Bevendorff 2018-02-01 17:58:15 +01:00
parent 9c51e1af18
commit 17e3f1c21f
3 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/Entry.cpp
View File

@ -350,6 +350,7 @@ QString Entry::totp() const
void Entry::setTotp(const QString& seed, quint8& step, quint8& digits) void Entry::setTotp(const QString& seed, quint8& step, quint8& digits)
{ {
beginUpdate();
if (step == 0) { if (step == 0) {
step = Totp::defaultStep; step = Totp::defaultStep;
} }
@ -376,6 +377,7 @@ void Entry::setTotp(const QString& seed, quint8& step, quint8& digits)
} }
m_attributes->set("TOTP Settings", data); m_attributes->set("TOTP Settings", data);
} }
endUpdate();
} }
QString Entry::totpSeed() const QString Entry::totpSeed() const

12
tests/TestTotp.cpp
View File

@ -164,3 +164,15 @@ void TestTotp::testSteamTotp()
time = 1511200714; time = 1511200714;
QCOMPARE(Totp::generateTotp(seed, time, Totp::ENCODER_STEAM, 30), QString("9P3VP")); QCOMPARE(Totp::generateTotp(seed, time, Totp::ENCODER_STEAM, 30), QString("9P3VP"));
} }
void TestTotp::testEntryHistory()
{
Entry entry;
quint8 step = 16;
quint8 digits = 6;
QCOMPARE(entry.historyItems().size(), 0);
entry.setTotp("GEZDGNBVGY3TQOJQGEZDGNBVGY3TQOJQ", step, digits);
QCOMPARE(entry.historyItems().size(), 1);
entry.setTotp("foo", step, digits);
QCOMPARE(entry.historyItems().size(), 2);
}

1
tests/TestTotp.h
View File

@ -33,6 +33,7 @@ private slots:
void testTotpCode(); void testTotpCode();
void testEncoderData(); void testEncoderData();
void testSteamTotp(); void testSteamTotp();
void testEntryHistory();
}; };
#endif // KEEPASSX_TESTTOTP_H #endif // KEEPASSX_TESTTOTP_H