Git-Mirrors/keepassxc
1
0
Fork 0
mirror of https://github.com/keepassxreboot/keepassxc.git synced 2025-05-03 07:04:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

Pass entryFlags to clone() when recursing into sub-groups.

Browse source 
Based on https://github.com/keepassx/keepassx/pull/178 by Mois Moshev <mois@monomon.me>

Closes #525
This commit is contained in:
Felix Geyer 2016-09-02 11:47:22 +02:00
parent 595b1011dd
commit 1635a5211f
2 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/core/Group.cpp
View file

@ -504,7 +504,7 @@ Group* Group::clone(Entry::CloneFlags entryFlags) const
} }
Q_FOREACH (Group* groupChild, children()) { Q_FOREACH (Group* groupChild, children()) {
Group* clonedGroupChild = groupChild->clone(); Group* clonedGroupChild = groupChild->clone(entryFlags);
clonedGroupChild->setParent(clonedGroup); clonedGroupChild->setParent(clonedGroup);
} }

5
tests/TestGroup.cpp
View file

@ -386,7 +386,12 @@ void TestGroup::testClone()
QVERIFY(clonedSubGroupEntry->uuid() != subGroupEntry->uuid()); QVERIFY(clonedSubGroupEntry->uuid() != subGroupEntry->uuid());
QCOMPARE(clonedSubGroupEntry->title(), QString("SubGroupEntry")); QCOMPARE(clonedSubGroupEntry->title(), QString("SubGroupEntry"));
Group* clonedGroupKeepUuid = originalGroup->clone(Entry::CloneNoFlags);
QCOMPARE(clonedGroupKeepUuid->entries().at(0)->uuid(), originalGroupEntry->uuid());
QCOMPARE(clonedGroupKeepUuid->children().at(0)->entries().at(0)->uuid(), subGroupEntry->uuid());
delete clonedGroup; delete clonedGroup;
delete clonedGroupKeepUuid;
delete db; delete db;
} }