2017-04-22 03:02:59 -04:00
|
|
|
/*
|
|
|
|
* Copyright (C) 2017 Vladimir Svyatski <v.unreal@gmail.com>
|
2017-06-09 17:40:36 -04:00
|
|
|
* Copyright (C) 2017 KeePassXC Team <team@keepassxc.org>
|
2017-04-22 03:02:59 -04:00
|
|
|
*
|
|
|
|
* This program is free software: you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation, either version 2 or (at your option)
|
|
|
|
* version 3 of the License.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "TestDatabase.h"
|
2018-01-24 07:22:20 -05:00
|
|
|
#include "TestGlobal.h"
|
2017-04-22 03:02:59 -04:00
|
|
|
|
2017-04-22 07:35:01 -04:00
|
|
|
#include <QSignalSpy>
|
2017-04-22 03:02:59 -04:00
|
|
|
|
2017-04-22 07:35:01 -04:00
|
|
|
#include "config-keepassx-tests.h"
|
2017-04-22 17:50:26 -04:00
|
|
|
#include "core/Metadata.h"
|
2018-03-31 16:01:30 -04:00
|
|
|
#include "crypto/Crypto.h"
|
2017-04-22 17:50:26 -04:00
|
|
|
#include "format/KeePass2Writer.h"
|
2018-03-31 16:01:30 -04:00
|
|
|
#include "keys/PasswordKey.h"
|
2019-10-14 09:31:23 -04:00
|
|
|
#include "util/TemporaryFile.h"
|
2017-04-22 03:02:59 -04:00
|
|
|
|
|
|
|
QTEST_GUILESS_MAIN(TestDatabase)
|
|
|
|
|
2019-10-20 18:23:11 -04:00
|
|
|
static QString dbFileName = QStringLiteral(KEEPASSX_TEST_DATA_DIR).append("/NewDatabase.kdbx");
|
|
|
|
|
2017-04-22 03:02:59 -04:00
|
|
|
void TestDatabase::initTestCase()
|
|
|
|
{
|
|
|
|
QVERIFY(Crypto::init());
|
|
|
|
}
|
|
|
|
|
2019-10-14 09:31:23 -04:00
|
|
|
void TestDatabase::testOpen()
|
|
|
|
{
|
|
|
|
auto db = QSharedPointer<Database>::create();
|
|
|
|
QVERIFY(!db->isInitialized());
|
|
|
|
QVERIFY(!db->isModified());
|
|
|
|
|
|
|
|
auto key = QSharedPointer<CompositeKey>::create();
|
|
|
|
key->addKey(QSharedPointer<PasswordKey>::create("a"));
|
|
|
|
|
2019-10-20 18:23:11 -04:00
|
|
|
bool ok = db->open(dbFileName, key);
|
2019-10-14 09:31:23 -04:00
|
|
|
QVERIFY(ok);
|
|
|
|
|
|
|
|
QVERIFY(db->isInitialized());
|
|
|
|
QVERIFY(!db->isModified());
|
|
|
|
|
|
|
|
db->metadata()->setName("test");
|
|
|
|
QVERIFY(db->isModified());
|
|
|
|
}
|
|
|
|
|
|
|
|
void TestDatabase::testSave()
|
|
|
|
{
|
|
|
|
TemporaryFile tempFile;
|
2019-10-20 18:23:11 -04:00
|
|
|
QVERIFY(tempFile.copyFromFile(dbFileName));
|
2019-10-14 09:31:23 -04:00
|
|
|
|
|
|
|
auto db = QSharedPointer<Database>::create();
|
|
|
|
auto key = QSharedPointer<CompositeKey>::create();
|
|
|
|
key->addKey(QSharedPointer<PasswordKey>::create("a"));
|
|
|
|
|
|
|
|
QString error;
|
|
|
|
bool ok = db->open(tempFile.fileName(), key, &error);
|
|
|
|
QVERIFY(ok);
|
|
|
|
|
|
|
|
// Test safe saves
|
|
|
|
db->metadata()->setName("test");
|
|
|
|
QVERIFY(db->isModified());
|
2019-10-20 18:23:11 -04:00
|
|
|
QVERIFY2(db->save(&error), error.toLatin1());
|
|
|
|
QVERIFY(!db->isModified());
|
2019-10-14 09:31:23 -04:00
|
|
|
|
|
|
|
// Test unsafe saves
|
2019-10-20 18:23:11 -04:00
|
|
|
db->metadata()->setName("test2");
|
2019-10-14 09:31:23 -04:00
|
|
|
QVERIFY2(db->save(&error, false, false), error.toLatin1());
|
|
|
|
QVERIFY(!db->isModified());
|
|
|
|
|
|
|
|
// Test save backups
|
2019-10-20 18:23:11 -04:00
|
|
|
db->metadata()->setName("test3");
|
2019-10-14 09:31:23 -04:00
|
|
|
QVERIFY2(db->save(&error, true, true), error.toLatin1());
|
2019-10-20 18:23:11 -04:00
|
|
|
QVERIFY(!db->isModified());
|
|
|
|
|
|
|
|
// Confirm backup exists and then delete it
|
|
|
|
auto re = QRegularExpression("(\\.[^.]+)$");
|
|
|
|
auto match = re.match(tempFile.fileName());
|
|
|
|
auto backupFilePath = tempFile.fileName();
|
|
|
|
backupFilePath = backupFilePath.replace(re, "") + ".old" + match.captured(1);
|
|
|
|
QVERIFY(QFile::exists(backupFilePath));
|
|
|
|
QFile::remove(backupFilePath);
|
|
|
|
QVERIFY(!QFile::exists(backupFilePath));
|
|
|
|
}
|
|
|
|
|
|
|
|
void TestDatabase::testSignals()
|
|
|
|
{
|
|
|
|
TemporaryFile tempFile;
|
|
|
|
QVERIFY(tempFile.copyFromFile(dbFileName));
|
|
|
|
|
|
|
|
auto db = QSharedPointer<Database>::create();
|
|
|
|
auto key = QSharedPointer<CompositeKey>::create();
|
|
|
|
key->addKey(QSharedPointer<PasswordKey>::create("a"));
|
|
|
|
|
|
|
|
QSignalSpy spyFilePathChanged(db.data(), SIGNAL(filePathChanged(const QString&, const QString&)));
|
|
|
|
QString error;
|
|
|
|
bool ok = db->open(tempFile.fileName(), key, &error);
|
|
|
|
QVERIFY(ok);
|
|
|
|
QCOMPARE(spyFilePathChanged.count(), 1);
|
|
|
|
|
|
|
|
QSignalSpy spyModified(db.data(), SIGNAL(databaseModified()));
|
|
|
|
db->metadata()->setName("test1");
|
|
|
|
QTRY_COMPARE(spyModified.count(), 1);
|
|
|
|
|
|
|
|
QSignalSpy spySaved(db.data(), SIGNAL(databaseSaved()));
|
|
|
|
QVERIFY(db->save(&error));
|
|
|
|
QCOMPARE(spySaved.count(), 1);
|
|
|
|
|
|
|
|
QSignalSpy spyFileChanged(db.data(), SIGNAL(databaseFileChanged()));
|
|
|
|
QVERIFY(tempFile.copyFromFile(dbFileName));
|
|
|
|
QTRY_COMPARE(spyFileChanged.count(), 1);
|
|
|
|
QTRY_VERIFY(!db->isModified());
|
|
|
|
|
|
|
|
db->metadata()->setName("test2");
|
|
|
|
QTRY_VERIFY(db->isModified());
|
|
|
|
|
|
|
|
QSignalSpy spyDiscarded(db.data(), SIGNAL(databaseDiscarded()));
|
|
|
|
QVERIFY(db->open(tempFile.fileName(), key, &error));
|
|
|
|
QCOMPARE(spyDiscarded.count(), 1);
|
2019-10-14 09:31:23 -04:00
|
|
|
}
|
|
|
|
|
2017-04-22 03:02:59 -04:00
|
|
|
void TestDatabase::testEmptyRecycleBinOnDisabled()
|
|
|
|
{
|
2017-04-22 07:35:01 -04:00
|
|
|
QString filename = QString(KEEPASSX_TEST_DATA_DIR).append("/RecycleBinDisabled.kdbx");
|
2018-05-13 17:21:43 -04:00
|
|
|
auto key = QSharedPointer<CompositeKey>::create();
|
|
|
|
key->addKey(QSharedPointer<PasswordKey>::create("123"));
|
2018-11-22 05:47:31 -05:00
|
|
|
auto db = QSharedPointer<Database>::create();
|
|
|
|
QVERIFY(db->open(filename, key, nullptr, false));
|
2017-04-22 03:02:59 -04:00
|
|
|
|
2018-11-22 05:47:31 -05:00
|
|
|
// Explicitly mark DB as read-write in case it was opened from a read-only drive.
|
|
|
|
// Prevents assertion failures on CI systems when the data dir is not writable
|
|
|
|
db->setReadOnly(false);
|
|
|
|
|
|
|
|
QSignalSpy spyModified(db.data(), SIGNAL(databaseModified()));
|
2017-04-22 07:35:01 -04:00
|
|
|
|
|
|
|
db->emptyRecycleBin();
|
2018-03-31 16:01:30 -04:00
|
|
|
// The database must be unmodified in this test after emptying the recycle bin.
|
2018-11-22 05:47:31 -05:00
|
|
|
QTRY_COMPARE(spyModified.count(), 0);
|
2017-04-22 03:02:59 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
void TestDatabase::testEmptyRecycleBinOnNotCreated()
|
|
|
|
{
|
2017-04-22 07:35:01 -04:00
|
|
|
QString filename = QString(KEEPASSX_TEST_DATA_DIR).append("/RecycleBinNotYetCreated.kdbx");
|
2018-05-13 17:21:43 -04:00
|
|
|
auto key = QSharedPointer<CompositeKey>::create();
|
|
|
|
key->addKey(QSharedPointer<PasswordKey>::create("123"));
|
2018-11-22 05:47:31 -05:00
|
|
|
auto db = QSharedPointer<Database>::create();
|
|
|
|
QVERIFY(db->open(filename, key, nullptr, false));
|
|
|
|
db->setReadOnly(false);
|
2017-04-22 07:35:01 -04:00
|
|
|
|
2018-11-22 05:47:31 -05:00
|
|
|
QSignalSpy spyModified(db.data(), SIGNAL(databaseModified()));
|
2017-04-22 07:35:01 -04:00
|
|
|
|
|
|
|
db->emptyRecycleBin();
|
2018-03-31 16:01:30 -04:00
|
|
|
// The database must be unmodified in this test after emptying the recycle bin.
|
2018-11-22 05:47:31 -05:00
|
|
|
QTRY_COMPARE(spyModified.count(), 0);
|
2017-04-22 03:02:59 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
void TestDatabase::testEmptyRecycleBinOnEmpty()
|
|
|
|
{
|
2017-04-22 07:35:01 -04:00
|
|
|
QString filename = QString(KEEPASSX_TEST_DATA_DIR).append("/RecycleBinEmpty.kdbx");
|
2018-05-13 17:21:43 -04:00
|
|
|
auto key = QSharedPointer<CompositeKey>::create();
|
|
|
|
key->addKey(QSharedPointer<PasswordKey>::create("123"));
|
2018-11-22 05:47:31 -05:00
|
|
|
auto db = QSharedPointer<Database>::create();
|
|
|
|
QVERIFY(db->open(filename, key, nullptr, false));
|
|
|
|
db->setReadOnly(false);
|
2017-04-22 03:02:59 -04:00
|
|
|
|
2018-11-22 05:47:31 -05:00
|
|
|
QSignalSpy spyModified(db.data(), SIGNAL(databaseModified()));
|
2017-04-22 07:35:01 -04:00
|
|
|
|
|
|
|
db->emptyRecycleBin();
|
2018-03-31 16:01:30 -04:00
|
|
|
// The database must be unmodified in this test after emptying the recycle bin.
|
2018-11-22 05:47:31 -05:00
|
|
|
QTRY_COMPARE(spyModified.count(), 0);
|
2017-04-22 03:02:59 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
void TestDatabase::testEmptyRecycleBinWithHierarchicalData()
|
|
|
|
{
|
2017-04-22 17:50:26 -04:00
|
|
|
QString filename = QString(KEEPASSX_TEST_DATA_DIR).append("/RecycleBinWithData.kdbx");
|
2018-05-13 17:21:43 -04:00
|
|
|
auto key = QSharedPointer<CompositeKey>::create();
|
|
|
|
key->addKey(QSharedPointer<PasswordKey>::create("123"));
|
2018-11-22 05:47:31 -05:00
|
|
|
auto db = QSharedPointer<Database>::create();
|
|
|
|
QVERIFY(db->open(filename, key, nullptr, false));
|
|
|
|
db->setReadOnly(false);
|
2017-04-22 17:50:26 -04:00
|
|
|
|
|
|
|
QFile originalFile(filename);
|
|
|
|
qint64 initialSize = originalFile.size();
|
|
|
|
|
|
|
|
db->emptyRecycleBin();
|
|
|
|
QVERIFY(db->metadata()->recycleBin());
|
|
|
|
QVERIFY(db->metadata()->recycleBin()->entries().empty());
|
|
|
|
QVERIFY(db->metadata()->recycleBin()->children().empty());
|
|
|
|
|
|
|
|
QTemporaryFile afterCleanup;
|
2018-11-22 05:47:31 -05:00
|
|
|
afterCleanup.open();
|
|
|
|
|
2017-04-22 17:50:26 -04:00
|
|
|
KeePass2Writer writer;
|
2018-05-13 17:21:43 -04:00
|
|
|
writer.writeDatabase(&afterCleanup, db.data());
|
2017-04-22 17:50:26 -04:00
|
|
|
QVERIFY(afterCleanup.size() < initialSize);
|
2017-04-22 03:02:59 -04:00
|
|
|
}
|