Samantaz Fox
2c447a42f2
Make sure to only apply fix if QUIC is disabled
2021-11-16 21:40:35 +01:00
Samantaz Fox
dad8f9a0ce
Fix typo
...
Should be checking the returned headers, not the sent ones.
2021-11-16 20:39:26 +01:00
Samantaz Fox
2eac23a0b3
Temporary fix for #2612
...
Don't rely on the auto compression/decompression provided by the crystal stdlib.
2021-11-16 13:46:28 +01:00
Samantaz Fox
00904ae3f2
Merge pull request #2444 from syeopite/only-use-redirect-endpoint-when-needed
...
Only use the /redirect endpoint when automatically redirecting to another instance
2021-11-13 20:40:09 +01:00
Émilien Devos
d214a0b333
remove duplicate lsquic requirement
2021-11-12 23:02:43 +00:00
syeopite
a120f143d7
Disable quic by default
...
See #2577
2021-11-12 04:03:23 -08:00
syeopite
65fbdbff6a
Remove of gzip header w/ use_quic config
...
Continuation of b0f127d4d8
2021-11-12 03:52:50 -08:00
syeopite
6ec4dcfafd
Fix handling for maxres thumbnail
2021-11-12 03:47:58 -08:00
syeopite
48191aca6e
Fix copy-paste error
2021-11-12 03:47:57 -08:00
syeopite
83556bace2
Allow thumbnail queries with QUIC disabled
2021-11-12 03:47:57 -08:00
syeopite
814c9e6c3a
Use https for storyboard image requests
2021-11-12 03:47:57 -08:00
syeopite
547abe17d9
Use https for ggpht requests
2021-11-12 03:47:57 -08:00
syeopite
6b8450558d
Allow storyboard queries with QUIC disabled
2021-11-12 03:47:57 -08:00
syeopite
c3747c2d49
Allow ggpht queries with QUIC disabled
2021-11-12 03:47:57 -08:00
syeopite
245122104a
Respect use_quic param and fix typos
2021-11-12 03:47:57 -08:00
syeopite
b0f127d4d8
Fix gzip decompression with HTTP::Client
2021-11-12 03:47:57 -08:00
syeopite
d379a36c0e
Add compile-time flag to remove code for QUIC
2021-11-12 03:47:50 -08:00
Samantaz Fox
6cf0ff6b49
Remove useless auto_generated param from PlaylistVideo#to_xml
...
given the variables available in this function's context, 'author' and 'ucid'
provide the same data 'self.author' and 'self.ucid', respectively.
Given that fact, the variable `auto_generated` has no impact on the logic of
this function, and hence can be safely removed. this greatly simplifies the
code and makes it perfectly compatible with crystal's calling convention for
'#to_xml' methods.
2021-10-29 16:26:42 +02:00
Samantaz Fox
86f75758a7
Fix 'to_json' in struct PlaylistVideo
2021-10-29 16:26:42 +02:00
Samantaz Fox
0ec94405ce
Add TODO comments to other places
2021-10-29 16:26:42 +02:00
Samantaz Fox
33780f1995
Also fix 'to_json' in struct Video
2021-10-29 16:26:35 +02:00
Samantaz Fox
1cb715ac9f
serialized_yt_data: force datatype of 'locale'
2021-10-28 17:48:08 +02:00
Samantaz Fox
f65b628bf3
serialized_yt_data: Remove default nil value in to_json
...
this will ensure that two parameters are passed and that it
doesn't collide with 'to_json(builder)'
2021-10-28 17:48:07 +02:00
Samantaz Fox
60fa552469
Fix an infinite recursion caused by #2228
...
Changes in the aforementioned PR lead to change the behavior
of some old code.
The data type of the parameters aren't explicit enough, which
makes the compiler use the wrong method because of type infering.
2021-10-28 17:48:07 +02:00
syeopite
437bdedb07
Use env.request.resource for instance switch link
2021-10-26 16:12:25 -07:00
syeopite
a531f4f057
Rebase error
2021-10-26 16:12:25 -07:00
syeopite
bb396a310e
Remove unneeded redirect.invidious.io code in /redirect
2021-10-26 16:12:25 -07:00
syeopite
66e7285108
Only use /redirect when automatically redirecting
2021-10-26 16:12:16 -07:00
Samantaz Fox
2b81a82620
Merge pull request #2529 from DmitrySandalov/master
...
Feature Request: Localization for trending iv-org#331
2021-10-26 23:49:56 +02:00
Samantaz Fox
b555df8377
Merge pull request #2428 from syeopite/ameba-fixes
...
Fix (some) issues detected by Ameba
2021-10-26 23:34:18 +02:00
Samantaz Fox
232730e909
Merge branch 'master' into master
2021-10-26 23:31:48 +02:00
Samantaz Fox
1e0712625a
Normalize translation key for preferences categories
...
categories normalized:
- Miscellanous
- Player
- Visual
- Administrator
- Data
- Subscription
2021-10-26 23:17:04 +02:00
Samantaz Fox
88752f32bd
Normalize translation key for user prefrerences
...
preferences normalized:
- annotations
- annotations_subscribed
- automatic_instance_redirect
- autoplay
- captions
- comments
- continue
- continue_autoplay
- dark_mode
- default_home
- extend_desc
- feed_menu
- listen
- local
- locale
- max_results
- notifications_only
- player_style
- quality
- quality_dash
- related_videos
- show_nick
- sort
- speed
- thin_mode
- unseen_only
- video_loop
- volume
- vr_mode
2021-10-26 23:15:39 +02:00
syeopite
e2bbc9a6fa
Switch to #sort_by! in pull_popular_videos job
2021-10-25 01:14:14 -07:00
syeopite
17e481c107
Reduce block verbosity further
2021-10-25 01:14:14 -07:00
syeopite
b8f27a42a7
Optimize assigning of on_response_received_endpoints
2021-10-25 01:14:14 -07:00
syeopite
575c66efd3
Remove extra dot between [] from ambea copy-pasting.
2021-10-25 01:14:14 -07:00
syeopite
88ad7c8d8d
Update src/invidious/routes/playlists.cr
...
Co-authored-by: Samantaz Fox <coding@samantaz.fr>
2021-10-25 01:14:09 -07:00
syeopite
1adcac175e
Update src/invidious/routes/channels.cr
...
Co-authored-by: Samantaz Fox <coding@samantaz.fr>
2021-10-25 01:14:09 -07:00
syeopite
dd8c412abc
Fix Style/IsAFilter issues
2021-10-25 01:14:08 -07:00
syeopite
e969c1490a
Fix Performance/ChainedCallWithNoBang issues
2021-10-25 01:12:26 -07:00
syeopite
e91421253e
Fix Style/VerboseBlock issues
2021-10-25 01:12:26 -07:00
syeopite
35d15c7c2b
Fix Style/VariableNames issues
2021-10-25 01:12:26 -07:00
syeopite
20cb751ff6
Fix Lint/UnusedArgument issues
2021-10-25 01:12:26 -07:00
syeopite
0614b52f03
Fix Lint/RedundantStringCoercion issues
2021-10-25 01:12:19 -07:00
Dmitry Sandalov
a629521c37
Feature Request: Localization for trending (remove region from server config)
2021-10-25 10:57:27 +03:00
Dmitry Sandalov
0e17d026f2
Feature Request: Localization for trending (fix lint CONTENT_REGIONS end comma)
2021-10-21 23:38:49 +03:00
Dmitry Sandalov
1d78d67af3
Feature Request: Localization for trending (move TRENDING_REGIONS to i18n.cr as CONTENT_REGIONS)
2021-10-21 22:30:49 +03:00
Dmitry Sandalov
d9c58c4837
Feature Request: Localization for trending iv-org#331
2021-10-21 14:54:15 +03:00
syeopite
129779a757
Merge pull request #2433 from iv-org/increase-channel-refresh-delay
...
Decrease channel refresh frequency (1 min -> 1 h)
2021-10-20 19:12:35 +00:00
syeopite
c8a985cc77
Merge pull request #2477 from SamantazFox/move-prefs-and-config
...
Move user preferences and server config
2021-10-18 17:06:07 +00:00
Samantaz Fox
cb9b84f940
Move 'extract_text()' to 'extractors_utils.cr'
2021-10-18 16:14:37 +02:00
Samantaz Fox
33d9be0ffb
Move 'extractors.cr' to 'yt_backend' folder
2021-10-18 16:12:49 +02:00
Samantaz Fox
2571e420f3
Move 'add_yt_headers()' to 'connection_pool.cr'
2021-10-18 16:12:18 +02:00
Samantaz Fox
e17c8b1f4d
Move 'extract_videos' and 'extract_selected_tab' too
2021-10-18 16:12:18 +02:00
Samantaz Fox
8805ee7c8c
Add fetch_continuation_token back (required by #2215 )
2021-10-18 16:12:18 +02:00
Samantaz Fox
7df2fd0bc8
Add 'require' statement to 'invidious.cr'
2021-10-18 16:12:17 +02:00
Samantaz Fox
f7f0910953
Remove fetch_continuation_token(): dead code
2021-10-18 16:12:17 +02:00
Samantaz Fox
d300797e22
Move the YoutubeConnectionPool code to its own file
2021-10-18 16:12:17 +02:00
Samantaz Fox
56dbe15943
Move proxy & YoutubeAPI code to the yt_backend folder
2021-10-18 16:12:17 +02:00
syeopite
5f65e92500
Merge pull request #2508 from syeopite/lazy-load-images
...
Lazy load (some) images
2021-10-17 18:25:59 +00:00
syeopite
21b96a3159
Merge pull request #2506 from syeopite/handle-empty-playlist-tabs
...
Handle YT tabs without content
2021-10-15 22:13:25 +00:00
syeopite
888c7e2c29
Merge pull request #2491 from syeopite/extract-image-routes
...
Extract image routes
2021-10-15 22:13:10 +00:00
TheFrenchGhosty
22e8f7e287
Fix #2510
2021-10-14 21:00:14 +02:00
TheFrenchGhosty
0ad2793b68
Link to invidious.io/donate/ in the footer
2021-10-14 20:20:25 +02:00
syeopite
585e4617e8
Lazy load (some) images
2021-10-14 08:18:44 -07:00
syeopite
4d44b2c3a4
Handle YT tabs without any content
2021-10-13 11:38:20 -07:00
syeopite
b49b5fbda9
Support empty categories
2021-10-13 11:35:31 -07:00
syeopite
17e6093abb
Merge pull request #2497 from Yetangitu/videorendererparser_parse_missing_title
...
Handle missing title fields in VideoRendererParser.parse (fixes #2495 )
2021-10-12 19:04:51 +00:00
Frank de Lange
3dc980e800
Fix for #2488 - parse contents of search results of type=Category ( #2496 )
...
* Fix for #2488 - parse contents of search results of type=Category (returned on first page for universal (type=all) queries instead of returning an error.
* Moved content array walker to Category#to_json
As requested by reviewer this change moves the content array walker from the API endpoint to the Category class.
* Update src/invidious/helpers/serialized_yt_data.cr
Co-authored-by: syeopite <70992037+syeopite@users.noreply.github.com>
2021-10-12 18:17:45 +00:00
Frank de Lange
c44c1003af
Handle missing title fields in VideoRendererParser.parse
2021-10-12 14:56:15 +00:00
Samantaz Fox
678b10dbcf
Lookback 50 videos
2021-10-11 23:52:57 +02:00
diogo
a1d6411f1f
propagate video_id field on getting playlists
2021-10-11 23:51:07 +02:00
diogo
c4c8a10507
rename from continuation to video_id on get_playlist_videos
2021-10-11 23:49:08 +02:00
diogo
ee94ccdeb0
update to new YoutubeAPI
2021-10-11 23:49:08 +02:00
diogo
e3df9f9ead
use dig for getting the video index
2021-10-11 23:49:08 +02:00
diogo
62dc629337
linting
2021-10-11 23:49:08 +02:00
diogo
dccdf38ce7
increase the max videos in a playlist
2021-10-11 23:49:07 +02:00
diogo
84124b837d
use v1/next instead of searching for the continuation index
2021-10-11 23:49:07 +02:00
diogo
6176da3cbb
linting
2021-10-11 23:46:23 +02:00
diogo
24bc3e2704
no need to normalize the offset
2021-10-11 23:45:22 +02:00
diogo
0a9e19646a
pass the api/v1/playlists with videos before the offset
2021-10-11 23:43:41 +02:00
diogo
65e45c4079
linting
2021-10-11 23:30:49 +02:00
diogo
440105976f
fix cases when high offset video from playlist has no offset in url
2021-10-11 23:30:49 +02:00
diogo
7eba7fbcc7
add index to playlist item
2021-10-11 23:30:49 +02:00
diogo
d9bfb3d305
playlist starts at the offset
2021-10-11 23:30:49 +02:00
syeopite
4246c7a523
Extract image routes
2021-10-11 13:22:11 -07:00
Samantaz Fox
57ed047025
Add mising 'require' statement to 'invidious.cr'
2021-10-11 18:33:36 +02:00
Samantaz Fox
bda3a26423
Move server structure to a separate file
2021-10-11 18:33:36 +02:00
Samantaz Fox
080d9a8dc7
move theme converter function to a separate file
2021-10-11 18:33:36 +02:00
Samantaz Fox
984a4acc7b
Move user preferences structure to a separate file
2021-10-11 18:33:36 +02:00
syeopite
b10f37bea9
Use kemal in production mode ( #2455 )
2021-10-11 14:42:22 +02:00
mastihios
0947c26612
Fix URL-encoding in href strings ( #2460 )
...
* hrefs: replace HTML.escape w/ URI.encode_www_form
* Fix search_query_encoded
2021-10-11 05:18:20 -07:00
Samantaz Fox
c6f088d6ca
Reduce refresh delay, increase backoff start duration
2021-10-08 18:39:02 +02:00
syeopite
21e29411af
Fix extractor bugs ( #2454 )
...
* Add debug/trace logging to extract_items
* Handle invalid timestamps for livestreams extraction
* Make use of author_fallback in playlist extractor
* Don't use extract_text for video length extraction
The extract_text function attempts to extract from both the simpleText and
the runs route. This is typically what we'd want for text extraction as
it could appear in both locations. However, while this still holds true,
the thumbnailOverlayTimeStatusRenderer writes a numerical length (when
present on the video) to the simpleText route and uses runs for a
text overlay like "LIVE" or "PREMIERE".
Therefore, when a video has a text overlay instead of a numerical one,
Invidious still passes it onto decode_length_seconds, which obviously
raises since it cannot be converted into integers.
In the future, if more routes requires one text route over the other, we
should go ahead and add an argument to extract_text itself. Though for
now, this is sufficient.
* Handle unsupported "special" categories
2021-10-07 23:39:21 +02:00
Samantaz Fox
adc12addfa
Add config option to display source code URL in footer ( #2450 )
2021-10-07 13:53:12 +02:00
Samantaz Fox
d806310665
Revert "Fix typo ( #2456 )" ( #2457 )
...
This reverts commit 4982bff74d
2021-10-04 19:51:57 +02:00
Jorge Maldonado Ventura
4982bff74d
Fix typo ( #2456 )
2021-10-04 17:47:57 +00:00
syeopite
81b12b8001
Add support to make invidious API-only via flag ( #2363 )
2021-10-02 20:04:02 +00:00
syeopite
3e781b7d13
Merge pull request #2443 from iv-org/syeopite-patch-1
...
Use make_client when querying instance api
2021-10-02 20:00:37 +00:00
syeopite
9c44e41a4c
Merge pull request #2228 from syeopite/extract-items-overhaul
...
Overhaul extract_item(s) functions and add infrastructure for parsing YouTube categories
2021-10-02 20:00:16 +00:00
syeopite
73eabb6ca2
Actually fix lint
2021-10-02 08:53:58 -07:00
Samantaz Fox
5a52b4fe45
Fix lint
2021-10-02 17:41:25 +02:00
Samantaz Fox
caa08a6379
Disable locales with less than 50% of strings translated
2021-10-02 17:38:06 +02:00
Samantaz Fox
cd02078e26
Add Portuguese (pt) to locales
...
follow up to #2437
2021-10-02 17:19:28 +02:00
syeopite
77131cff91
Use make_client when querying instance api
2021-10-02 15:16:07 +00:00
mastihios
7b2aa5f98e
add icon-buttons to playlist items ( #2442 )
2021-10-02 11:59:33 +00:00
syeopite
26b28cea49
Use break instead of short-circuit return
2021-10-01 05:39:23 -07:00
syeopite
23049e026f
Improve readabltiy of SearchChannel auto-gen detect
2021-09-28 08:55:02 -07:00
syeopite
9ab242ca2e
Optimize routing logic of extract_item(s) funcs
2021-09-28 08:50:23 -07:00
syeopite
aa59925374
Rename get_browse_endpoint to get_browse_id
2021-09-28 08:39:00 -07:00
syeopite
43ea8fa706
Convert nil for AuthorFallback to empty strings
2021-09-28 08:25:03 -07:00
syeopite
6df85718e6
Apply suggestions from code review
...
Co-authored-by: Samantaz Fox <coding@samantaz.fr>
2021-09-28 15:23:36 +00:00
Samantaz Fox
9ba3e1cdb4
Decrease channel refresh frequency (1 min -> 1 h)
...
This is a temporary fix to reduce load on instances with many channels and avoid IP being flagged by Google.
2021-09-26 23:31:14 +02:00
syeopite
b20f72b963
Use default timeout (5 seconds) for YT pool ( #2430 )
2021-09-26 23:03:45 +02:00
syeopite
092b8a4e52
Add documentation to extractors.cr
2021-09-24 21:07:07 -07:00
syeopite
e5f07dedbf
Typos and tiny styling changes
2021-09-24 21:07:07 -07:00
syeopite
ca9eb0d539
Bountiful extractor changes
...
- Add extract_text to simplify extraction of InnerTube texts
- Add helper extractor methods to reduce repetition in parsing InnerTube
- Change [] more than 2 blocks long to use #dig or #dig?
- Remove useless ?.try blocks for items that always exists
- Add (some) documentation to VideoRendererParser
2021-09-24 21:07:07 -07:00
syeopite
142317c2be
Overhaul extractors.cr to use modules
2021-09-24 21:07:07 -07:00
syeopite
3dea670091
Switch to structs in extractors.cr for performance
2021-09-24 21:07:07 -07:00
syeopite
8435e79913
Improve documentation for extract_item(s) funcs
2021-09-24 21:07:07 -07:00
syeopite
30e85b40f9
Fix extract_videos
2021-09-24 21:07:07 -07:00
syeopite
be1a43a337
Manually extract category refactor from 1b569bbc99
...
Also fixes some errors caused by cherry-picking
2021-09-24 21:07:07 -07:00
syeopite
abca8f7a7c
Rename invidiousitems.cr
2021-09-24 21:07:07 -07:00
syeopite
7b60dac526
Add description_html field to Category
...
(cherry picked from commit aa8f15f795
2021-09-24 21:07:07 -07:00
syeopite
ea6434662d
Change typing of Category contents to only Array
...
(cherry picked from commit d3384e17f1
2021-09-24 21:07:06 -07:00
syeopite
0b7a108a59
Move continuation_token out of Category struct
...
(cherry picked from commit 0e96eda28f
2021-09-24 21:07:06 -07:00
syeopite
57c63f3598
Rename "items_without_cate_items" to reflect usage
2021-09-24 21:07:06 -07:00
syeopite
ae30f32c36
Unpack search items that are embedded in categories
...
This is a squash of a bunch of commits
cherry-picked commits
Fix category parse error on search
(cherry picked from commit cc02fed4e62605b9c609ca4afd59f4cc10675610abda6840d5491e33450e
2021-09-24 21:07:06 -07:00
syeopite
a50f64f6e9
Add parser for categories (shelfRenderer)
...
This commit adds a new parser for YT's shelfRenderers which are
typically used to denote different categories.The code for featured
channels parsing has also been moved to use the new parser but some
additional refactoring are needed there.
The ContinuationExtractor has also been improved and is now capable of
extraction continuation data that is packaged under
"appendContinuationItemsAction"
In additional this commit adds some useful helper functions to extract
the current selected tab the continuation token. This is to mainly
reduce code size and repetition.
--
This cherry-picked commit also removes the code for parsing featured
channels present on the original.
(cherry picked from commit 8000d538db
2021-09-24 21:07:06 -07:00
syeopite
1323b94b7a
Rewrite extract_item and extract_items functions
...
This commit completely rewrites the extract_item and extract_items
function. Before this commit these two function were an unreadable
mess. The extract_item function was a lengthy if-elsif chain
while the extract_items function contained an incomprehensible
mess of .try, else and ||.
With this commit both of these functions have been pulled into a
separate file with the internal logic being moved to a few classes.
This significantly reduces the size of these two methods, enhances
readability and makes adding new extraction/parse rules much simpler.
See diff for details.
--
This cherry-picked commit also removes the code for parsing featured
channels present on the original.
(cherry picked from commit a027fbf7af
2021-09-24 21:06:46 -07:00
syeopite
6d68fbc31d
Fix livestream regex regression caused by #2271
...
Closes #2352
Special thanks to @WaywardHeart for finding this issue!
2021-09-25 02:47:52 +00:00
syeopite
86ca568d6d
Remove login type button from frontend ( #2423 )
2021-09-23 08:44:26 +02:00
Walkyst
2b0bb69a4f
Fix mixes route ( #2421 )
2021-09-20 22:39:32 -07:00
syeopite
87f46a7532
Unregister captcha job ( #2390 )
2021-09-19 10:30:19 +00:00
Samantaz Fox
e655af251c
Try not to log search queries ( #2362 )
2021-09-16 09:36:22 +00:00
syeopite
5054510d15
Prevent VR from being initialized in listen mode ( #2396 )
2021-09-15 01:37:23 +02:00
Samantaz Fox
947fe4fbb3
HTML escape video mimetype
...
Video mimetype may contain code information between double quotes.
If not properly escaped, it breaks the browser's parser. E.g:
```
type="video/mp4; codecs=" avc1.64001f,="" mp4a.40.2""=""
```
Thank Robin for catching this!
2021-09-13 18:20:11 +02:00
syeopite
50c8afb525
Handle equirectangular projections for VR ( #2379 )
2021-09-10 07:42:39 +00:00
syeopite
a539de4f97
Bump dependencies ( #2378 )
...
* Upgrade to Kemal v1.1.0
* Bump postgres driver
2021-09-10 07:42:15 +00:00
TheFrenchGhosty
8d5a867271
Merge pull request #2380 from syeopite/fix-invidious-showing-yt-redirect-links
...
Fix invidious showing yt redirect links
2021-09-06 11:15:08 +02:00
syeopite
387bddb51b
Improve detection and handling of yt redirect links
2021-09-05 13:13:37 -07:00
Emilien Devos
41ba19b615
fix comment replies
2021-09-04 15:37:16 +02:00
syeopite
a28945273d
Propagate replacing yout.be links to /watch to RSS
2021-09-03 03:33:49 -07:00
syeopite
fd6f03655e
Fix typo causing links to be youtube.com/redirect
2021-09-03 03:30:36 -07:00
Émilien Devos
8b62c05fe2
remove 3gp only from the player ( #2376 )
...
+ video quality precedence on default player when js is not enabled
2021-09-03 09:39:11 +02:00
syeopite
a1001ada47
Properly transform youtu.be links to be /watch routes in comments and descriptions ( #2365 )
2021-09-01 12:59:47 +02:00
TheFrenchGhosty
8e3ff79f22
Remove the mention of 'Omar Roth' from the footer
2021-09-01 12:23:50 +02:00
syeopite
4fcd0964cd
Extract API routes ( #2271 )
...
* Extract API routes from invidious.cr
* Remove deprecated APIs
- insights
- top feed
2021-08-30 18:27:47 +02:00
syeopite
5005212bec
Extract feed routes ( #2269 )
...
* Extract feed routes from invidious.cr
* Removes the deprecated route for /feed/top
* Deprecate /view_all_playlist & use /feed/playlists
* Move feed views into their own directory
* Add haltf method to halt current route context
* Change status_code + return blocks to use haltf
* Set appropriate response headers for RSS routes
2021-08-30 16:58:24 +02:00
