From d6a7df3adc3402fee0b0289331f1f22e9677d37d Mon Sep 17 00:00:00 2001
From: Samantaz Fox <coding@samantaz.fr>
Date: Thu, 1 Sep 2022 00:10:16 +0200
Subject: [PATCH] Jobs: add hourly cleaning of expired nonces/cached videos

---
 src/invidious.cr                              |  2 ++
 src/invidious/database/nonces.cr              | 11 ++++++++-
 src/invidious/database/videos.cr              |  9 ++++++++
 src/invidious/jobs/clear_expired_items_job.cr | 23 +++++++++++++++++++
 4 files changed, 44 insertions(+), 1 deletion(-)
 create mode 100644 src/invidious/jobs/clear_expired_items_job.cr

diff --git a/src/invidious.cr b/src/invidious.cr
index 0601d5b2..58adaa35 100644
--- a/src/invidious.cr
+++ b/src/invidious.cr
@@ -172,6 +172,8 @@ end
 CONNECTION_CHANNEL = Channel({Bool, Channel(PQ::Notification)}).new(32)
 Invidious::Jobs.register Invidious::Jobs::NotificationJob.new(CONNECTION_CHANNEL, CONFIG.database_url)
 
+Invidious::Jobs.register Invidious::Jobs::ClearExpiredItemsJob.new
+
 Invidious::Jobs.start_all
 
 def popular_videos
diff --git a/src/invidious/database/nonces.cr b/src/invidious/database/nonces.cr
index 469fcbd8..b87c81ec 100644
--- a/src/invidious/database/nonces.cr
+++ b/src/invidious/database/nonces.cr
@@ -4,7 +4,7 @@ module Invidious::Database::Nonces
   extend self
 
   # -------------------
-  #  Insert
+  #  Insert / Delete
   # -------------------
 
   def insert(nonce : String, expire : Time)
@@ -17,6 +17,15 @@ module Invidious::Database::Nonces
     PG_DB.exec(request, nonce, expire)
   end
 
+  def delete_expired
+    request = <<-SQL
+      DELETE FROM nonces *
+      WHERE expire < now()
+    SQL
+
+    PG_DB.exec(request)
+  end
+
   # -------------------
   #  Update
   # -------------------
diff --git a/src/invidious/database/videos.cr b/src/invidious/database/videos.cr
index e1fa01c3..695f5b33 100644
--- a/src/invidious/database/videos.cr
+++ b/src/invidious/database/videos.cr
@@ -22,6 +22,15 @@ module Invidious::Database::Videos
     PG_DB.exec(request, id)
   end
 
+  def delete_expired
+    request = <<-SQL
+      DELETE FROM videos *
+      WHERE updated < (now() - interval '6 hours')
+    SQL
+
+    PG_DB.exec(request)
+  end
+
   def update(video : Video)
     request = <<-SQL
       UPDATE videos
diff --git a/src/invidious/jobs/clear_expired_items_job.cr b/src/invidious/jobs/clear_expired_items_job.cr
new file mode 100644
index 00000000..49f86106
--- /dev/null
+++ b/src/invidious/jobs/clear_expired_items_job.cr
@@ -0,0 +1,23 @@
+class Invidious::Jobs::ClearExpiredItemsJob < Invidious::Jobs::BaseJob
+  # Remove items (videos, nonces, etc..) whose cache is outdated every hour.
+  # Removes the need for a cron job.
+  def begin
+    loop do
+      failed = false
+
+      begin
+        Invidious::Database::Videos.delete_expired
+        Invidious::Database::Nonces.delete_expired
+      rescue DB::Error
+        failed = true
+      end
+
+      # Retry earlier than scheduled on DB error
+      if failed
+        sleep 10.minutes
+      else
+        sleep 1.hour
+      end
+    end
+  end
+end