Fix toggle_theme when visiting preferences with JS disabled

This commit is contained in:
Omar Roth 2019-06-04 19:58:56 -05:00
parent d6ec441c8e
commit 352e409a6e
No known key found for this signature in database
GPG Key ID: B8254FB7EC3D37F2
2 changed files with 11 additions and 9 deletions

View File

@ -1487,7 +1487,7 @@ end
get "/toggle_theme" do |env| get "/toggle_theme" do |env|
locale = LOCALES[env.get("preferences").as(Preferences).locale]? locale = LOCALES[env.get("preferences").as(Preferences).locale]?
referer = get_referer(env) referer = get_referer(env, unroll: false)
redirect = env.params.query["redirect"]? redirect = env.params.query["redirect"]?
redirect ||= "true" redirect ||= "true"

View File

@ -243,7 +243,7 @@ def make_host_url(config, kemal_config)
return "#{scheme}#{host}#{port}" return "#{scheme}#{host}#{port}"
end end
def get_referer(env, fallback = "/") def get_referer(env, fallback = "/", unroll = true)
referer = env.params.query["referer"]? referer = env.params.query["referer"]?
referer ||= env.request.headers["referer"]? referer ||= env.request.headers["referer"]?
referer ||= fallback referer ||= fallback
@ -251,16 +251,18 @@ def get_referer(env, fallback = "/")
referer = URI.parse(referer) referer = URI.parse(referer)
# "Unroll" nested referrers # "Unroll" nested referrers
loop do if unroll
if referer.query loop do
params = HTTP::Params.parse(referer.query.not_nil!) if referer.query
if params["referer"]? params = HTTP::Params.parse(referer.query.not_nil!)
referer = URI.parse(URI.unescape(params["referer"])) if params["referer"]?
referer = URI.parse(URI.unescape(params["referer"]))
else
break
end
else else
break break
end end
else
break
end end
end end