refactor payment account form api to support structured, dynamic forms

This commit is contained in:
woodser 2022-06-16 18:58:27 -04:00
parent 341ae2bef0
commit faeb9ca8db
203 changed files with 1844 additions and 509 deletions

View file

@ -115,9 +115,6 @@ public class AbstractPaymentAccountTest extends MethodTest {
static final Map<String, Object> COMPLETED_FORM_MAP = new HashMap<>();
// A payment account serializer / deserializer.
static final PaymentAccountForm PAYMENT_ACCOUNT_FORM = new PaymentAccountForm();
@BeforeEach
public void setup() {
Res.setup();
@ -134,7 +131,7 @@ public class AbstractPaymentAccountTest extends MethodTest {
// File emptyForm = PAYMENT_ACCOUNT_FORM.getPaymentAccountForm(paymentMethodId);
log.debug("{} Empty form saved to {}",
testName(testInfo),
PAYMENT_ACCOUNT_FORM.getClickableURI(emptyForm));
PaymentAccountForm.getClickableURI(emptyForm));
emptyForm.deleteOnExit();
return emptyForm;
}
@ -142,7 +139,7 @@ public class AbstractPaymentAccountTest extends MethodTest {
protected final void verifyEmptyForm(File jsonForm, String paymentMethodId, String... fields) {
@SuppressWarnings("unchecked")
Map<String, Object> emptyForm = (Map<String, Object>) GSON.fromJson(
PAYMENT_ACCOUNT_FORM.toJsonString(jsonForm),
PaymentAccountForm.toJsonString(jsonForm),
Object.class);
assertNotNull(emptyForm);
@ -201,14 +198,14 @@ public class AbstractPaymentAccountTest extends MethodTest {
protected final String getCompletedFormAsJsonString(List<String> comments) {
File completedForm = fillPaymentAccountForm(comments);
String jsonString = PAYMENT_ACCOUNT_FORM.toJsonString(completedForm);
String jsonString = PaymentAccountForm.toJsonString(completedForm);
log.debug("Completed form: {}", jsonString);
return jsonString;
}
protected final String getCompletedFormAsJsonString() {
File completedForm = fillPaymentAccountForm(PROPERTY_VALUE_JSON_COMMENTS);
String jsonString = PAYMENT_ACCOUNT_FORM.toJsonString(completedForm);
String jsonString = PaymentAccountForm.toJsonString(completedForm);
log.debug("Completed form: {}", jsonString);
return jsonString;
}

View file

@ -36,11 +36,12 @@ import static org.apache.commons.lang3.StringUtils.capitalize;
import bisq.cli.GrpcClient;
import bisq.core.api.model.PaymentAccountForm;
/**
* Convenience GrpcClient wrapper for bots using gRPC services.
*/
@SuppressWarnings({"JavaDoc", "unused"})
@SuppressWarnings({"unused"})
@Slf4j
public class BotClient {

View file

@ -58,10 +58,9 @@ public class BotPaymentAccountGenerator {
}
private Map<String, Object> getPaymentAccountFormMap(String paymentMethodId) {
PaymentAccountForm paymentAccountForm = new PaymentAccountForm();
File jsonFormTemplate = paymentAccountForm.getPaymentAccountForm(paymentMethodId);
File jsonFormTemplate = PaymentAccountForm.getPaymentAccountForm(paymentMethodId);
jsonFormTemplate.deleteOnExit();
String jsonString = paymentAccountForm.toJsonString(jsonFormTemplate);
String jsonString = PaymentAccountForm.toJsonString(jsonFormTemplate);
//noinspection unchecked
return (Map<String, Object>) gson.fromJson(jsonString, Object.class);
}