Rename ImageUtil methods

This commit is contained in:
Manfred Karrer 2014-09-16 01:34:30 +02:00
parent f0f5ddd4ec
commit 908874fd92
12 changed files with 37 additions and 38 deletions

View File

@ -128,7 +128,6 @@ public class BitSquare extends Application {
primaryStage.setMinHeight(500);
primaryStage.show();
} catch (IOException e) {
log.error(e.getMessage());
}

View File

@ -59,7 +59,8 @@ public class Navigation {
///////////////////////////////////////////////////////////////////////////////////////////
public void navigationTo(Item... items) {
log.trace("navigationTo " + Arrays.asList(items).toString());
if (items != null)
log.trace("navigationTo " + Arrays.asList(items).toString());
List<Item> temp = new ArrayList<>();
for (int i = 0; i < items.length; i++) {
Item item = items[i];
@ -82,8 +83,9 @@ public class Navigation {
currentItems = items;
persistence.write(this, "navigationItems", items);
log.trace("navigationTo notify listeners " + Arrays.asList(items).toString() + " / " + listeners
.size());
if (items != null)
log.trace("navigationTo notify listeners " + Arrays.asList(items).toString() + " / " + listeners
.size());
listeners.stream().forEach((e) -> e.onNavigationRequested(items));
}

View File

@ -72,7 +72,7 @@ public class InfoDisplay extends Parent {
public InfoDisplay() {
icon = ImageUtil.getIconImageView(ImageUtil.INFO);
icon = ImageUtil.getImageView(ImageUtil.INFO);
icon.setPickOnBounds(true);
icon.setPreserveRatio(true);
icon.visibleProperty().bind(visibleProperty());

View File

@ -85,7 +85,6 @@ public class MainViewCB extends ViewCB<MainPM> {
// Lifecycle
///////////////////////////////////////////////////////////////////////////////////////////
@SuppressWarnings("EmptyMethod")
@Override
public void initialize(URL url, ResourceBundle rb) {
super.initialize(url, rb);
@ -188,7 +187,7 @@ public class MainViewCB extends ViewCB<MainPM> {
Profiler.printMsgWithTime("MainController.ondMainNavigationAdded");
presentationModel.takeOfferRequested.addListener((ov, olaValue, newValue) -> {
final Button alertButton = new Button("", ImageUtil.getIconImageView(ImageUtil.MSG_ALERT));
final Button alertButton = new Button("", ImageUtil.getImageView(ImageUtil.MSG_ALERT));
alertButton.setId("nav-alert-button");
alertButton.relocate(36, 19);
alertButton.setOnAction((e) ->
@ -361,8 +360,8 @@ public class MainViewCB extends ViewCB<MainPM> {
onMainNavigationAdded();
}
private ToggleButton addNavButton(Pane parent, String title, Navigation.Item item) {
ImageView icon = ImageUtil.getIconImageView(item.getIcon());
private ToggleButton addNavButton(Pane parent, String title, Navigation.Item navigationItem) {
ImageView icon = ImageUtil.getImageView(navigationItem.getIcon());
icon.setFitWidth(32);
icon.setFitHeight(32);
@ -381,16 +380,16 @@ public class MainViewCB extends ViewCB<MainPM> {
toggleButton.setMaxSize(50, 50);
toggleButton.setGraphicTextGap(newValue ? -1 : 0);
if (newValue) {
Image activeIcon = ImageUtil.getIconImage(item.getActiveIcon());
Image activeIcon = ImageUtil.getImage(navigationItem.getActiveIcon());
((ImageView) toggleButton.getGraphic()).setImage(activeIcon);
}
else {
Image activeIcon = ImageUtil.getIconImage(item.getIcon());
Image activeIcon = ImageUtil.getImage(navigationItem.getIcon());
((ImageView) toggleButton.getGraphic()).setImage(activeIcon);
}
});
toggleButton.setOnAction(e -> navigation.navigationTo(Navigation.Item.MAIN, item));
toggleButton.setOnAction(e -> navigation.navigationTo(Navigation.Item.MAIN, navigationItem));
parent.getChildren().add(toggleButton);
return toggleButton;

View File

@ -236,7 +236,7 @@ public class RestrictionsViewCB extends CachedViewCB<RestrictionsPM> implements
public ListCell<Locale> call(ListView<Locale> list) {
return new ListCell<Locale>() {
final Label label = new Label();
final ImageView icon = ImageUtil.getIconImageView(ImageUtil.REMOVE_ICON);
final ImageView icon = ImageUtil.getImageView(ImageUtil.REMOVE_ICON);
final Button removeButton = new Button("", icon);
final AnchorPane pane = new AnchorPane(label, removeButton);
@ -294,7 +294,7 @@ public class RestrictionsViewCB extends CachedViewCB<RestrictionsPM> implements
public ListCell<Country> call(ListView<Country> list) {
return new ListCell<Country>() {
final Label label = new Label();
final ImageView icon = ImageUtil.getIconImageView(ImageUtil.REMOVE_ICON);
final ImageView icon = ImageUtil.getImageView(ImageUtil.REMOVE_ICON);
final Button removeButton = new Button("", icon);
final AnchorPane pane = new AnchorPane(label, removeButton);
@ -338,7 +338,7 @@ public class RestrictionsViewCB extends CachedViewCB<RestrictionsPM> implements
public ListCell<Arbitrator> call(ListView<Arbitrator> list) {
return new ListCell<Arbitrator>() {
final Label label = new Label();
final ImageView icon = ImageUtil.getIconImageView(ImageUtil.REMOVE_ICON);
final ImageView icon = ImageUtil.getImageView(ImageUtil.REMOVE_ICON);
final Button removeButton = new Button("", icon);
final AnchorPane pane = new AnchorPane(label, removeButton);

View File

@ -202,7 +202,7 @@ class WizardItem extends HBox {
setSpacing(5);
setPrefWidth(200);
imageView = ImageUtil.getIconImageView(ImageUtil.ARROW_GREY);
imageView = ImageUtil.getImageView(ImageUtil.ARROW_GREY);
imageView.setFitHeight(15);
imageView.setFitWidth(20);
imageView.setPickOnBounds(true);
@ -237,7 +237,7 @@ class WizardItem extends HBox {
navigationItem);
setId("wizard-item-background-active");
imageView.setImage(ImageUtil.getIconImage(ImageUtil.ARROW_BLUE));
imageView.setImage(ImageUtil.getImage(ImageUtil.ARROW_BLUE));
titleLabel.setId("wizard-title-active");
subTitleLabel.setId("wizard-sub-title-active");
return childController;
@ -245,7 +245,7 @@ class WizardItem extends HBox {
void onCompleted() {
setId("wizard-item-background-completed");
imageView.setImage(ImageUtil.getIconImage(ImageUtil.TICK));
imageView.setImage(ImageUtil.getImage(ImageUtil.TICK));
titleLabel.setId("wizard-title-completed");
subTitleLabel.setId("wizard-sub-title-completed");
}

View File

@ -155,7 +155,7 @@ public class OfferController extends CachedViewController {
@Override
public TableCell<String, OfferListItem> call(TableColumn<String, OfferListItem> directionColumn) {
return new TableCell<String, OfferListItem>() {
final ImageView iconView = ImageUtil.getIconImageView(ImageUtil.REMOVE_ICON);
final ImageView iconView = ImageUtil.getImageView(ImageUtil.REMOVE_ICON);
final Button button = new Button();
{

View File

@ -78,8 +78,8 @@ public class PendingTradeController extends CachedViewController {
private Trade currentTrade;
private final Image buyIcon = ImageUtil.getIconImage(ImageUtil.BUY_ICON);
private final Image sellIcon = ImageUtil.getIconImage(ImageUtil.SELL_ICON);
private final Image buyIcon = ImageUtil.getImage(ImageUtil.BUY_ICON);
private final Image sellIcon = ImageUtil.getImage(ImageUtil.SELL_ICON);
private ConfidenceDisplay confidenceDisplay;
@FXML private TableView openTradesTable;
@ -365,7 +365,7 @@ public class PendingTradeController extends CachedViewController {
if (tradesTableItem != null) {
Country country = tradesTableItem.getTrade().getOffer().getBankAccountCountry();
try {
hBox.getChildren().add(ImageUtil.getIconImageView(
hBox.getChildren().add(ImageUtil.getImageView(
"/images/countries/" + country.getCode().toLowerCase() + ".png"));
} catch (Exception e) {

View File

@ -90,9 +90,8 @@ public class TradeViewCB extends CachedViewCB {
super.activate();
// We need to remove open validation error popups
// TODO Find a way to do that in the InputTextField directly, but a tab change does not trigger any event
// there
// Platform.runLater needed as focus-out event is called after selectedIndexProperty changed
// TODO Find a way to do that in the InputTextField directly, but a tab change does not trigger any event...
TabPane tabPane = (TabPane) root;
tabPane.getSelectionModel().selectedIndexProperty()
.addListener((observableValue, oldValue, newValue) ->
@ -128,8 +127,7 @@ public class TradeViewCB extends CachedViewCB {
// Navigation
///////////////////////////////////////////////////////////////////////////////////////////
// @Override
@Override
protected Initializable loadView(Navigation.Item navigationItem) {
super.loadView(navigationItem);
TabPane tabPane = (TabPane) root;

View File

@ -190,8 +190,8 @@ public class CreateOfferViewCB extends CachedViewCB<CreateOfferPM> {
showAdvancedSettingsButton.setVisible(true);
if (expand == null) {
expand = ImageUtil.getIconImageView(ImageUtil.EXPAND);
collapse = ImageUtil.getIconImageView(ImageUtil.COLLAPSE);
expand = ImageUtil.getImageView(ImageUtil.EXPAND);
collapse = ImageUtil.getImageView(ImageUtil.COLLAPSE);
}
showAdvancedSettingsButton.setGraphic(expand);

View File

@ -70,8 +70,8 @@ public class OrderBookViewCB extends CachedViewCB<OrderBookPM> {
private boolean detailsVisible;
private boolean advancedScreenInited;
private final Image buyIcon = ImageUtil.getIconImage(ImageUtil.BUY_ICON);
private final Image sellIcon = ImageUtil.getIconImage(ImageUtil.SELL_ICON);
private final Image buyIcon = ImageUtil.getImage(ImageUtil.BUY_ICON);
private final Image sellIcon = ImageUtil.getImage(ImageUtil.SELL_ICON);
private ImageView expand;
private ImageView collapse;
@ -125,8 +125,8 @@ public class OrderBookViewCB extends CachedViewCB<OrderBookPM> {
setupValidators();
setupComparators();
expand = ImageUtil.getIconImageView(ImageUtil.EXPAND);
collapse = ImageUtil.getIconImageView(ImageUtil.COLLAPSE);
expand = ImageUtil.getImageView(ImageUtil.EXPAND);
collapse = ImageUtil.getImageView(ImageUtil.COLLAPSE);
showAdvancedSettingsButton.setGraphic(expand);
super.initialize(url, rb);
@ -456,7 +456,7 @@ public class OrderBookViewCB extends CachedViewCB<OrderBookPM> {
Offer offer = item.getOffer();
if (presentationModel.isMyOffer(offer)) {
icon = ImageUtil.getIconImage(ImageUtil.REMOVE_ICON);
icon = ImageUtil.getImage(ImageUtil.REMOVE_ICON);
title = "Remove";
button.setOnAction(event -> presentationModel.removeOffer(item
.getOffer()));

View File

@ -24,6 +24,7 @@ import javafx.scene.image.*;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
public class ImageUtil {
private static final Logger log = LoggerFactory.getLogger(ImageUtil.class);
@ -63,17 +64,17 @@ public class ImageUtil {
public static final String ARROW_GREY = "/images/arrow_grey.png";
public static final String INFO = "/images/info.png";
public static Image getIconImage(String iconName) {
return new Image(ImageUtil.class.getResourceAsStream(iconName));
public static Image getImage(String url) {
return new Image(ImageUtil.class.getResourceAsStream(url));
}
public static ImageView getIconImageView(String iconName) {
return new ImageView(new Image(ImageUtil.class.getResourceAsStream(iconName)));
public static ImageView getImageView(String url) {
return new ImageView(getImage(url));
}
public static ImageView getCountryIconImageView(Country country) {
try {
return ImageUtil.getIconImageView("/images/countries/" + country.getCode().toLowerCase() + ".png");
return ImageUtil.getImageView("/images/countries/" + country.getCode().toLowerCase() + ".png");
} catch (Exception e) {
log.error("Country icon not found URL = /images/countries/" + country.getCode().toLowerCase() +