Return void from TradeView#loadView

The return value of #loadView is never used. Return void to more clearly
reflect this fact.
This commit is contained in:
Chris Beams 2014-11-27 10:36:08 +01:00
parent 1ce151821a
commit 75babebc8b
No known key found for this signature in database
GPG key ID: 3D214F8F5BC5ED73

View file

@ -66,9 +66,8 @@ public abstract class TradeView extends ActivatableView<TabPane, Void> {
@Override @Override
protected void initialize() { protected void initialize() {
listener = viewPath -> { listener = viewPath -> {
if (viewPath.size() == 3 && viewPath.indexOf(this.getClass()) == 1) { if (viewPath.size() == 3 && viewPath.indexOf(this.getClass()) == 1)
loadView(viewPath.tip()); loadView(viewPath.tip());
}
}; };
} }
@ -116,7 +115,7 @@ public abstract class TradeView extends ActivatableView<TabPane, Void> {
navigation.navigateTo(MainView.class, this.getClass(), TakeOfferView.class); navigation.navigateTo(MainView.class, this.getClass(), TakeOfferView.class);
} }
private View loadView(Class<? extends View> viewClass) { private void loadView(Class<? extends View> viewClass) {
TabPane tabPane = root; TabPane tabPane = root;
View view; View view;
@ -157,8 +156,6 @@ public abstract class TradeView extends ActivatableView<TabPane, Void> {
offerBookView.setOfferActionHandler(offerActionHandler); offerBookView.setOfferActionHandler(offerActionHandler);
offerBookView.setDirection(direction); offerBookView.setDirection(direction);
return offerBookView;
} }
else if (viewClass == CreateOfferView.class && createOfferView == null) { else if (viewClass == CreateOfferView.class && createOfferView == null) {
view = viewLoader.load(viewClass); view = viewLoader.load(viewClass);
@ -172,7 +169,6 @@ public abstract class TradeView extends ActivatableView<TabPane, Void> {
tab.setContent(createOfferPane); tab.setContent(createOfferPane);
tabPane.getTabs().add(tab); tabPane.getTabs().add(tab);
tabPane.getSelectionModel().select(tab); tabPane.getSelectionModel().select(tab);
return createOfferView;
} }
else if (viewClass == TakeOfferView.class && takeOfferView == null && offer != null) { else if (viewClass == TakeOfferView.class && takeOfferView == null && offer != null) {
view = viewLoader.load(viewClass); view = viewLoader.load(viewClass);
@ -186,9 +182,7 @@ public abstract class TradeView extends ActivatableView<TabPane, Void> {
tab.setContent(takeOfferPane); tab.setContent(takeOfferPane);
tabPane.getTabs().add(tab); tabPane.getTabs().add(tab);
tabPane.getSelectionModel().select(tab); tabPane.getSelectionModel().select(tab);
return takeOfferView;
} }
return null;
} }
private void onCreateOfferViewRemoved() { private void onCreateOfferViewRemoved() {