fix sorting of trigger price icon with open offer row (#1874)

This commit is contained in:
woodser 2025-07-20 16:34:25 -04:00 committed by GitHub
parent 7fb7504046
commit 45e54b69e8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -1010,15 +1010,18 @@ public class OpenOffersView extends ActivatableViewAndModel<VBox, OpenOffersView
@Override @Override
public TableCell<OpenOfferListItem, OpenOfferListItem> call(TableColumn<OpenOfferListItem, OpenOfferListItem> column) { public TableCell<OpenOfferListItem, OpenOfferListItem> call(TableColumn<OpenOfferListItem, OpenOfferListItem> column) {
return new TableCell<>() { return new TableCell<>() {
Button button; private final Button button = getRegularIconButton(MaterialDesignIcon.SHIELD_HALF_FULL);
@Override @Override
public void updateItem(final OpenOfferListItem item, boolean empty) { protected void updateItem(final OpenOfferListItem item, boolean empty) {
super.updateItem(item, empty); super.updateItem(item, empty);
if (item != null && !empty) { if (item == null || empty) {
if (button == null) { setGraphic(null);
button = getRegularIconButton(MaterialDesignIcon.SHIELD_HALF_FULL); button.setOnAction(null);
return;
}
boolean triggerPriceSet = item.getOpenOffer().getTriggerPrice() > 0; boolean triggerPriceSet = item.getOpenOffer().getTriggerPrice() > 0;
button.setVisible(triggerPriceSet); button.setVisible(triggerPriceSet);
@ -1029,17 +1032,10 @@ public class OpenOffersView extends ActivatableViewAndModel<VBox, OpenOffersView
button.getGraphic().getStyleClass().remove("warning"); button.getGraphic().getStyleClass().remove("warning");
button.setTooltip(new Tooltip(Res.get("openOffer.triggerPrice", model.getTriggerPrice(item)))); button.setTooltip(new Tooltip(Res.get("openOffer.triggerPrice", model.getTriggerPrice(item))));
} }
button.setOnAction(e -> onEditOpenOffer(item.getOpenOffer()));
setGraphic(button); setGraphic(button);
} }
button.setOnAction(event -> onEditOpenOffer(item.getOpenOffer()));
} else {
setGraphic(null);
if (button != null) {
button.setOnAction(null);
button = null;
}
}
}
}; };
} }
}); });