Remove empty lifecycle methods in gui model classes

This commit is contained in:
Chris Beams 2014-11-22 10:35:55 +01:00
parent 1551d09cf0
commit 10cca4f844
No known key found for this signature in database
GPG Key ID: 3D214F8F5BC5ED73
29 changed files with 0 additions and 512 deletions

View File

@ -31,30 +31,6 @@ class AccountModel extends UIModel {
this.user = user;
}
@SuppressWarnings("EmptyMethod")
@Override
public void initialize() {
super.initialize();
}
@SuppressWarnings("EmptyMethod")
@Override
public void activate() {
super.activate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
boolean getNeedRegistration() {
return user.getAccountId() == null;

View File

@ -28,32 +28,6 @@ class AccountPM extends PresentationModel<AccountModel> {
super(model);
}
@SuppressWarnings("EmptyMethod")
@Override
public void initialize() {
super.initialize();
}
@SuppressWarnings("EmptyMethod")
@Override
public void activate() {
super.activate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
boolean getNeedRegistration() {
return model.getNeedRegistration();
}

View File

@ -27,30 +27,6 @@ class ChangePasswordModel extends UIModel {
public ChangePasswordModel() {
}
@SuppressWarnings("EmptyMethod")
@Override
public void initialize() {
super.initialize();
}
@SuppressWarnings("EmptyMethod")
@Override
public void activate() {
super.activate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
@SuppressWarnings("EmptyMethod")
void savePassword(String password) {

View File

@ -49,31 +49,6 @@ class ChangePasswordPM extends PresentationModel<ChangePasswordModel> {
}
@SuppressWarnings("EmptyMethod")
@Override
public void initialize() {
super.initialize();
}
@SuppressWarnings("EmptyMethod")
@Override
public void activate() {
super.activate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
boolean requestSavePassword() {
if (validate()) {
model.savePassword(passwordField.get());

View File

@ -74,12 +74,6 @@ class FiatAccountModel extends UIModel {
}
@SuppressWarnings("EmptyMethod")
@Override
public void initialize() {
super.initialize();
}
@Override
public void activate() {
super.activate();
@ -87,18 +81,6 @@ class FiatAccountModel extends UIModel {
allBankAccounts.setAll(user.getBankAccounts());
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
void saveBankAccount() {
BankAccount bankAccount = new BankAccount(type.get(),

View File

@ -98,18 +98,6 @@ class FiatAccountPm extends PresentationModel<FiatAccountModel> {
applyAllBankAccounts();
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
InputValidator.ValidationResult requestSaveBankAccount() {
InputValidator.ValidationResult result = validateInput();

View File

@ -78,7 +78,6 @@ class IrcAccountModel extends UIModel {
}
@SuppressWarnings("EmptyMethod")
@Override
public void initialize() {
super.initialize();
@ -93,19 +92,6 @@ class IrcAccountModel extends UIModel {
allBankAccounts.setAll(user.getBankAccounts());
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
void saveBankAccount() {
BankAccount bankAccount = new BankAccount(type.get(),
currency.get(),

View File

@ -66,23 +66,6 @@ class IrcAccountPm extends PresentationModel<IrcAccountModel> {
super.initialize();
}
@Override
public void activate() {
super.activate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
InputValidator.ValidationResult requestSaveBankAccount() {
InputValidator.ValidationResult result = validateInput();

View File

@ -28,32 +28,6 @@ class PasswordModel extends UIModel {
public PasswordModel() {
}
@SuppressWarnings("EmptyMethod")
@Override
public void initialize() {
super.initialize();
}
@SuppressWarnings("EmptyMethod")
@Override
public void activate() {
super.activate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
@SuppressWarnings("EmptyMethod")
void savePassword(String password) {
//TODO Implement password encryption for wallet

View File

@ -49,31 +49,6 @@ class PasswordPM extends PresentationModel<PasswordModel> {
}
@SuppressWarnings("EmptyMethod")
@Override
public void initialize() {
super.initialize();
}
@SuppressWarnings("EmptyMethod")
@Override
public void activate() {
super.activate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
boolean requestSavePassword() {
if (validate()) {
model.savePassword(passwordField.get());

View File

@ -85,25 +85,6 @@ class RegistrationModel extends UIModel {
}
}
@SuppressWarnings("EmptyMethod")
@Override
public void activate() {
super.activate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
void payFee() {
FutureCallback<Transaction> callback = new FutureCallback<Transaction>() {
@Override

View File

@ -82,25 +82,6 @@ class RegistrationPM extends PresentationModel<RegistrationModel> {
});
}
@SuppressWarnings("EmptyMethod")
@Override
public void activate() {
super.activate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
void payFee() {
model.payFeeErrorMessage.set(null);
model.payFeeSuccess.set(false);

View File

@ -97,20 +97,6 @@ class RestrictionsModel extends UIModel {
arbitratorList.setAll(accountSettings.getAcceptedArbitrators());
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
ObservableList<Country> getAllCountriesFor(Region selectedRegion) {
return FXCollections.observableArrayList(CountryUtil.getAllCountriesFor(selectedRegion));
}

View File

@ -41,13 +41,6 @@ class RestrictionsPM extends PresentationModel<RestrictionsModel> {
}
@SuppressWarnings("EmptyMethod")
@Override
public void initialize() {
super.initialize();
}
@Override
public void activate() {
super.activate();
@ -55,13 +48,6 @@ class RestrictionsPM extends PresentationModel<RestrictionsModel> {
updateDoneButtonDisableState();
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();
}
void addLanguage(Locale locale) {
model.addLanguage(locale);
updateDoneButtonDisableState();

View File

@ -35,32 +35,6 @@ class SeedWordsModel extends UIModel {
mnemonicCode = walletService.getWallet().getKeyChainSeed().getMnemonicCode();
}
@SuppressWarnings("EmptyMethod")
@Override
public void initialize() {
super.initialize();
}
@SuppressWarnings("EmptyMethod")
@Override
public void activate() {
super.activate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
List<String> getMnemonicCode() {
return mnemonicCode;
}

View File

@ -38,7 +38,6 @@ class SeedWordsPM extends PresentationModel<SeedWordsModel> {
}
@SuppressWarnings("EmptyMethod")
@Override
public void initialize() {
super.initialize();
@ -47,22 +46,4 @@ class SeedWordsPM extends PresentationModel<SeedWordsModel> {
seedWords.set(formatter.mnemonicCodeToString(model.getMnemonicCode()));
}
@SuppressWarnings("EmptyMethod")
@Override
public void activate() {
super.activate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
}

View File

@ -78,13 +78,6 @@ class ClosedTradesModel extends UIModel {
tradeManager.getClosedTrades().removeListener(mapChangeListener);
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
public ObservableList<ClosedTradesListItem> getList() {
return list;
}

View File

@ -36,32 +36,6 @@ class ClosedTradesPM extends PresentationModel<ClosedTradesModel> {
this.formatter = formatter;
}
@SuppressWarnings("EmptyMethod")
@Override
public void initialize() {
super.initialize();
}
@SuppressWarnings("EmptyMethod")
@Override
public void activate() {
super.activate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
public ObservableList<ClosedTradesListItem> getList() {
return model.getList();
}

View File

@ -79,13 +79,6 @@ class OffersModel extends UIModel {
tradeManager.getOffers().removeListener(offerMapChangeListener);
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
void removeOffer(OfferListItem item) {
tradeManager.removeOffer(item.getOffer());
}

View File

@ -37,31 +37,6 @@ class OffersPM extends PresentationModel<OffersModel> {
}
@SuppressWarnings("EmptyMethod")
@Override
public void initialize() {
super.initialize();
}
@SuppressWarnings("EmptyMethod")
@Override
public void activate() {
super.activate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
void removeOffer(OfferListItem item) {
model.removeOffer(item);
}

View File

@ -96,7 +96,6 @@ public class PendingTradesPM extends PresentationModel<PendingTradesModel> {
updateState();
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();

View File

@ -56,12 +56,6 @@ class PreferencesModel extends UIModel {
}
@SuppressWarnings("EmptyMethod")
@Override
public void initialize() {
super.initialize();
}
@Override
public void activate() {
super.activate();
@ -83,12 +77,5 @@ class PreferencesModel extends UIModel {
useEffects.removeListener(useEffectsListener);
btcDenomination.removeListener(btcDenominationListener);
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
}

View File

@ -32,33 +32,6 @@ public class PreferencesPM extends PresentationModel<PreferencesModel> {
super(model);
}
@SuppressWarnings("EmptyMethod")
@Override
public void initialize() {
super.initialize();
}
@SuppressWarnings("EmptyMethod")
@Override
public void activate() {
super.activate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
public ObservableList<String> getBtcDenominationItems() {
return model.btcDenominations;
}

View File

@ -173,19 +173,6 @@ class CreateOfferModel extends UIModel {
}
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
void placeOffer() {
// data validation is done in the trade domain
tradeManager.requestPlaceOffer(offerId,

View File

@ -118,25 +118,6 @@ class CreateOfferPM extends PresentationModel<CreateOfferModel> {
setupListeners();
}
@SuppressWarnings("EmptyMethod")
@Override
public void activate() {
super.activate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
// setOfferBookFilter is a one time call
void initWithData(Direction direction, Coin amount, Fiat price) {
model.setDirection(direction);

View File

@ -123,13 +123,6 @@ class OfferBookModel extends UIModel {
btcCode.unbind();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
void removeOffer(Offer offer) {
tradeManager.removeOffer(offer);
}

View File

@ -102,25 +102,6 @@ class OfferBookPM extends PresentationModel<OfferBookModel> {
(newValue)));
}
@SuppressWarnings("EmptyMethod")
@Override
public void activate() {
super.activate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
void removeOffer(Offer offer) {
model.removeOffer(offer);
}

View File

@ -111,13 +111,6 @@ class TakeOfferModel extends UIModel {
btcCode.unbind();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
void initWithData(Coin amount, Offer offer) {
this.offer = offer;

View File

@ -106,25 +106,6 @@ class TakeOfferPM extends PresentationModel<TakeOfferModel> {
setupListeners();
}
@SuppressWarnings("EmptyMethod")
@Override
public void activate() {
super.activate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void deactivate() {
super.deactivate();
}
@SuppressWarnings("EmptyMethod")
@Override
public void terminate() {
super.terminate();
}
// setOfferBookFilter is a one time call
void initWithData(Direction direction, Coin amount, Offer offer) {
model.initWithData(amount, offer);