Git-Mirrors/haveno-ts
1
0
Fork 0
mirror of https://github.com/haveno-dex/haveno-ts.git synced 2025-08-07 05:52:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

reject creating crypto payment account with invalid currency code or address

Browse source
This commit is contained in:
napoly 2022-11-15 12:44:26 +01:00 • committed by woodser
parent 768c2158b3
commit 891d6cce3f
1 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/HavenoClient.test.ts
View file

@ -123,7 +123,7 @@ const TestConfig = {
address: "0xdBdAb835Acd6fC84cF5F9aDD3c0B5a1E25fbd99f" address: "0xdBdAb835Acd6fC84cF5F9aDD3c0B5a1E25fbd99f"
}, { }, {
currencyCode: "BTC", currencyCode: "BTC",
address: "bcrt1q6j90vywv8x7eyevcnn2tn2wrlg3vsjlsvt46qz" address: "1G457efxTyci67msm2dSqyhFzxPYFWaghe"
}, { }, {
currencyCode: "BCH", currencyCode: "BCH",
address: "1JRjBNKi4ZgJpKPeoL4149Q7ZZD3VvVgk9" // TODO: support CashAddr format only address: "1JRjBNKi4ZgJpKPeoL4149Q7ZZD3VvVgk9" // TODO: support CashAddr format only
@ -1065,17 +1065,15 @@ test("Can create crypto payment accounts", async () => {
testCryptoPaymentAccountEquals(fetchedAccount, testAccount, name); testCryptoPaymentAccountEquals(fetchedAccount, testAccount, name);
} }
// TODO (woodser): update from latest Bisq CorePaymentAccountService.java for currency and address validation // test invalid currency code
/* // test invalid currency code
await expect(async () => { await user1.createCryptoPaymentAccount("My account", "ABC", "123"); }) await expect(async () => { await user1.createCryptoPaymentAccount("My account", "ABC", "123"); })
.rejects .rejects
.toThrow('Unsupported cryptocurrency code: ABC'); .toThrow("crypto currency with code 'abc' not found");
// test invalid address // test invalid address
await expect(async () => { await user1.createCryptoPaymentAccount("My account", "ETH", "123"); }) await expect(async () => { await user1.createCryptoPaymentAccount("My account", "ETH", "123"); })
.rejects .rejects
.toThrow('Invalid address');*/ .toThrow('123 is not a valid eth address');
// TODO (woodser): test rejecting account with duplicate name // TODO (woodser): test rejecting account with duplicate name