mirror of
https://github.com/edgelesssys/constellation.git
synced 2024-12-29 01:16:12 -05:00
a87b7894db
* add current chart add current helm chart * disable service controller for aws ccm * add new iam roles * doc AWS internet LB + add to LB test * pass clusterName to helm for AWS LB * fix update-aws-lb chart to also include .helmignore * move chart outside services * working state * add subnet tags for AWS subnet discovery * fix .helmignore load rule with file in subdirectory * upgrade iam profile * revert new loader impl since cilium is not correctly loaded * install chart if not already present during `upgrade apply` * cleanup PR + fix build + add todos cleanup PR + add todos * shared helm pkg for cli install and bootstrapper * add link to eks docs * refactor iamMigrationCmd * delete unused helm.symwallk * move iammigrate to upgrade pkg * fixup! delete unused helm.symwallk * add to upgradecheck * remove nodeSelector from go code (Otto) * update iam docs and sort permission + remove duplicate roles * fix bug in `upgrade check` * better upgrade check output when svc version upgrade not possible * pr feedback * remove force flag in upgrade_test * use upgrader.GetUpgradeID instead of extra type * remove todos + fix check * update doc lb (leo) * remove bootstrapper helm package * Update cli/internal/cmd/upgradecheck.go Co-authored-by: Daniel Weiße <66256922+daniel-weisse@users.noreply.github.com> * final nits * add docs for e2e upgrade test setup * Apply suggestions from code review Co-authored-by: Daniel Weiße <66256922+daniel-weisse@users.noreply.github.com> * Update cli/internal/helm/loader.go Co-authored-by: Daniel Weiße <66256922+daniel-weisse@users.noreply.github.com> * Update cli/internal/cmd/tfmigrationclient.go Co-authored-by: Daniel Weiße <66256922+daniel-weisse@users.noreply.github.com> * fix daniel review * link to the iam permissions instead of manually updating them (agreed with leo) * disable iam upgrade in upgrade apply --------- Co-authored-by: Daniel Weiße <66256922+daniel-weisse@users.noreply.github.com> Co-authored-by: Malte Poll
232 lines
8.4 KiB
Go
232 lines
8.4 KiB
Go
/*
|
|
Copyright (c) Edgeless Systems GmbH
|
|
|
|
SPDX-License-Identifier: AGPL-3.0-only
|
|
*/
|
|
|
|
package upgrade
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
|
|
"github.com/edgelesssys/constellation/v2/cli/internal/cloudcmd"
|
|
"github.com/edgelesssys/constellation/v2/cli/internal/clusterid"
|
|
"github.com/edgelesssys/constellation/v2/cli/internal/terraform"
|
|
"github.com/edgelesssys/constellation/v2/internal/cloud/cloudprovider"
|
|
"github.com/edgelesssys/constellation/v2/internal/constants"
|
|
"github.com/edgelesssys/constellation/v2/internal/file"
|
|
)
|
|
|
|
// NewTerraformUpgrader returns a new TerraformUpgrader.
|
|
func NewTerraformUpgrader(tfClient tfResourceClient, outWriter io.Writer, fileHandler file.Handler) (*TerraformUpgrader, error) {
|
|
return &TerraformUpgrader{
|
|
tf: tfClient,
|
|
policyPatcher: cloudcmd.NewAzurePolicyPatcher(),
|
|
outWriter: outWriter,
|
|
fileHandler: fileHandler,
|
|
}, nil
|
|
}
|
|
|
|
// TerraformUpgrader is responsible for performing Terraform migrations on cluster upgrades.
|
|
type TerraformUpgrader struct {
|
|
tf tfResourceClient
|
|
policyPatcher policyPatcher
|
|
outWriter io.Writer
|
|
fileHandler file.Handler
|
|
}
|
|
|
|
// TerraformUpgradeOptions are the options used for the Terraform upgrade.
|
|
type TerraformUpgradeOptions struct {
|
|
// LogLevel is the log level used for Terraform.
|
|
LogLevel terraform.LogLevel
|
|
// CSP is the cloud provider to perform the upgrade on.
|
|
CSP cloudprovider.Provider
|
|
// Vars are the Terraform variables used for the upgrade.
|
|
Vars terraform.Variables
|
|
}
|
|
|
|
// CheckTerraformMigrations checks whether Terraform migrations are possible in the current workspace.
|
|
func checkTerraformMigrations(file file.Handler, upgradeID, upgradeSubDir string) error {
|
|
var existingFiles []string
|
|
filesToCheck := []string{
|
|
filepath.Join(constants.UpgradeDir, upgradeID, upgradeSubDir),
|
|
}
|
|
|
|
for _, f := range filesToCheck {
|
|
if err := checkFileExists(file, &existingFiles, f); err != nil {
|
|
return fmt.Errorf("checking terraform migrations: %w", err)
|
|
}
|
|
}
|
|
|
|
if len(existingFiles) > 0 {
|
|
return fmt.Errorf("file(s) %s already exist", strings.Join(existingFiles, ", "))
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// CheckTerraformMigrations checks whether Terraform migrations are possible in the current workspace.
|
|
// If the files that will be written during the upgrade already exist, it returns an error.
|
|
func (u *TerraformUpgrader) CheckTerraformMigrations(upgradeID, upgradeSubDir string) error {
|
|
return checkTerraformMigrations(u.fileHandler, upgradeID, upgradeSubDir)
|
|
}
|
|
|
|
// checkFileExists checks whether a file exists and adds it to the existingFiles slice if it does.
|
|
func checkFileExists(fileHandler file.Handler, existingFiles *[]string, filename string) error {
|
|
_, err := fileHandler.Stat(filename)
|
|
if err != nil {
|
|
if !os.IsNotExist(err) {
|
|
return fmt.Errorf("checking %s: %w", filename, err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
*existingFiles = append(*existingFiles, filename)
|
|
return nil
|
|
}
|
|
|
|
// PlanTerraformMigrations prepares the upgrade workspace and plans the Terraform migrations for the Constellation upgrade.
|
|
// If a diff exists, it's being written to the upgrader's output writer. It also returns
|
|
// a bool indicating whether a diff exists.
|
|
func (u *TerraformUpgrader) PlanTerraformMigrations(ctx context.Context, opts TerraformUpgradeOptions, upgradeID string) (bool, error) {
|
|
// Prepare the new Terraform workspace and backup the old one
|
|
err := u.tf.PrepareUpgradeWorkspace(
|
|
filepath.Join("terraform", strings.ToLower(opts.CSP.String())),
|
|
constants.TerraformWorkingDir,
|
|
filepath.Join(constants.UpgradeDir, upgradeID, constants.TerraformUpgradeWorkingDir),
|
|
filepath.Join(constants.UpgradeDir, upgradeID, constants.TerraformUpgradeBackupDir),
|
|
opts.Vars,
|
|
)
|
|
if err != nil {
|
|
return false, fmt.Errorf("preparing terraform workspace: %w", err)
|
|
}
|
|
|
|
// Backup the old constellation-id.json file
|
|
if err := u.fileHandler.CopyFile(
|
|
constants.ClusterIDsFileName,
|
|
filepath.Join(constants.UpgradeDir, upgradeID, constants.ClusterIDsFileName+".old"),
|
|
); err != nil {
|
|
return false, fmt.Errorf("backing up %s: %w", constants.ClusterIDsFileName, err)
|
|
}
|
|
|
|
hasDiff, err := u.tf.Plan(ctx, opts.LogLevel, constants.TerraformUpgradePlanFile)
|
|
if err != nil {
|
|
return false, fmt.Errorf("terraform plan: %w", err)
|
|
}
|
|
|
|
if hasDiff {
|
|
if err := u.tf.ShowPlan(ctx, opts.LogLevel, constants.TerraformUpgradePlanFile, u.outWriter); err != nil {
|
|
return false, fmt.Errorf("terraform show plan: %w", err)
|
|
}
|
|
}
|
|
|
|
return hasDiff, nil
|
|
}
|
|
|
|
// CleanUpTerraformMigrations cleans up the Terraform migration workspace, for example when an upgrade is
|
|
// aborted by the user.
|
|
func (u *TerraformUpgrader) CleanUpTerraformMigrations(upgradeID string) error {
|
|
return CleanUpTerraformMigrations(upgradeID, u.fileHandler)
|
|
}
|
|
|
|
// CleanUpTerraformMigrations cleans up the Terraform upgrade directory.
|
|
func CleanUpTerraformMigrations(upgradeID string, fileHandler file.Handler) error {
|
|
cleanupFiles := []string{
|
|
filepath.Join(constants.UpgradeDir, upgradeID),
|
|
}
|
|
|
|
for _, f := range cleanupFiles {
|
|
if err := fileHandler.RemoveAll(f); err != nil {
|
|
return fmt.Errorf("cleaning up file %s: %w", f, err)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// ApplyTerraformMigrations applies the migrations planned by PlanTerraformMigrations.
|
|
// If PlanTerraformMigrations has not been executed before, it will return an error.
|
|
// In case of a successful upgrade, the output will be written to the specified file and the old Terraform directory is replaced
|
|
// By the new one.
|
|
func (u *TerraformUpgrader) ApplyTerraformMigrations(ctx context.Context, opts TerraformUpgradeOptions, upgradeID string) error {
|
|
tfOutput, err := u.tf.CreateCluster(ctx, opts.LogLevel)
|
|
if err != nil {
|
|
return fmt.Errorf("terraform apply: %w", err)
|
|
}
|
|
|
|
// AttestationURL is only set for Azure.
|
|
if tfOutput.AttestationURL != "" {
|
|
if err := u.policyPatcher.Patch(ctx, tfOutput.AttestationURL); err != nil {
|
|
return fmt.Errorf("patching policies: %w", err)
|
|
}
|
|
}
|
|
|
|
outputFileContents := clusterid.File{
|
|
CloudProvider: opts.CSP,
|
|
InitSecret: []byte(tfOutput.Secret),
|
|
IP: tfOutput.IP,
|
|
APIServerCertSANs: tfOutput.APIServerCertSANs,
|
|
UID: tfOutput.UID,
|
|
AttestationURL: tfOutput.AttestationURL,
|
|
}
|
|
|
|
if err := u.fileHandler.RemoveAll(constants.TerraformWorkingDir); err != nil {
|
|
return fmt.Errorf("removing old terraform directory: %w", err)
|
|
}
|
|
|
|
if err := u.fileHandler.CopyDir(filepath.Join(constants.UpgradeDir, upgradeID, constants.TerraformUpgradeWorkingDir), constants.TerraformWorkingDir); err != nil {
|
|
return fmt.Errorf("replacing old terraform directory with new one: %w", err)
|
|
}
|
|
|
|
if err := u.fileHandler.RemoveAll(filepath.Join(constants.UpgradeDir, upgradeID, constants.TerraformUpgradeWorkingDir)); err != nil {
|
|
return fmt.Errorf("removing terraform upgrade directory: %w", err)
|
|
}
|
|
|
|
if err := u.mergeClusterIDFile(outputFileContents); err != nil {
|
|
return fmt.Errorf("merging migration output into %s: %w", constants.ClusterIDsFileName, err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// mergeClusterIDFile merges the output of the migration into the constellation-id.json file.
|
|
func (u *TerraformUpgrader) mergeClusterIDFile(migrationOutput clusterid.File) error {
|
|
idFile := &clusterid.File{}
|
|
if err := u.fileHandler.ReadJSON(constants.ClusterIDsFileName, idFile); err != nil {
|
|
return fmt.Errorf("reading %s: %w", constants.ClusterIDsFileName, err)
|
|
}
|
|
|
|
if err := u.fileHandler.WriteJSON(constants.ClusterIDsFileName, idFile.Merge(migrationOutput), file.OptOverwrite); err != nil {
|
|
return fmt.Errorf("writing %s: %w", constants.ClusterIDsFileName, err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
type tfClientCommon interface {
|
|
ShowPlan(ctx context.Context, logLevel terraform.LogLevel, planFilePath string, output io.Writer) error
|
|
Plan(ctx context.Context, logLevel terraform.LogLevel, planFile string) (bool, error)
|
|
}
|
|
|
|
// tfResourceClient is a Terraform client for managing cluster resources.
|
|
type tfResourceClient interface {
|
|
PrepareUpgradeWorkspace(path, oldWorkingDir, newWorkingDir, backupDir string, vars terraform.Variables) error
|
|
CreateCluster(ctx context.Context, logLevel terraform.LogLevel) (terraform.ApplyOutput, error)
|
|
tfClientCommon
|
|
}
|
|
|
|
// tfIAMClient is a Terraform client for managing IAM resources.
|
|
type tfIAMClient interface {
|
|
ApplyIAMConfig(ctx context.Context, csp cloudprovider.Provider, logLevel terraform.LogLevel) (terraform.IAMOutput, error)
|
|
tfClientCommon
|
|
}
|
|
|
|
// policyPatcher interacts with the CSP (currently only applies for Azure) to update the attestation policy.
|
|
type policyPatcher interface {
|
|
Patch(ctx context.Context, attestationURL string) error
|
|
}
|