From dbc648089b8be2509fc4b7139e3d26b620471000 Mon Sep 17 00:00:00 2001
From: miampf <miampf@proton.me>
Date: Fri, 19 Apr 2024 12:15:01 +0200
Subject: [PATCH] fix update_tfstate

move comparison to correct scope
---
 .github/actions/update_tfstate/action.yml | 7 ++++---
 .github/workflows/e2e-windows.yml         | 2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/.github/actions/update_tfstate/action.yml b/.github/actions/update_tfstate/action.yml
index 5582ea9e5..58d9ef11e 100644
--- a/.github/actions/update_tfstate/action.yml
+++ b/.github/actions/update_tfstate/action.yml
@@ -13,13 +13,14 @@ inputs:
     required: true
   skipDeletion:
     description: "Don't try to delete the artifact before updating. You should only use this if you know that no artifact exists."
-    default: false
+    default: "false"
+    required: false
 
 runs:
   using: "composite"
   steps:
     - name: Check if tfstate should be deleted
-      if: always() && !${{ inputs.skipDeletion }}
+      if: always() && ${{ inputs.skipDeletion }} == "false"
       shell: bash
       run: |
         if [ ! -d constellation-terraform ] && [ ! -d constellation-iam-terraform ]; then
@@ -29,7 +30,7 @@ runs:
         fi
 
     - name: Delete tfstate artifact if necessary
-      if: always() && env.DELETE_TF_STATE == 'true' && !${{ inputs.skipDeletion }}
+      if: always() && env.DELETE_TF_STATE == 'true' && ${{ inputs.skipDeletion }} == "false"
       uses: ./.github/actions/artifact_delete
       with:
         name: ${{ inputs.name }}
diff --git a/.github/workflows/e2e-windows.yml b/.github/workflows/e2e-windows.yml
index a1df1335a..893ff8306 100644
--- a/.github/workflows/e2e-windows.yml
+++ b/.github/workflows/e2e-windows.yml
@@ -216,5 +216,5 @@ jobs:
           name: terraform-state-${{ github.run_id }} 
           runID: ${{ github.run_id }}
           encryptionSecret: ${{ secrets.ARTIFACT_ENCRYPT_PASSWD }}
-          skipDeletion: true
+          skipDeletion: "true"