cli: Terraform migrations on upgrade (#1685)

* add terraform planning * overwrite terraform files in upgrade workspace * Revert "overwrite terraform files in upgrade workspace" This reverts commit 8bdacfb8bef23ef2cdbdb06bad0855b3bbc42df0. * prepare terraform workspace * test upgrade integration * print upgrade abort * rename plan file * write output to file * add show plan test * add upgrade tf workdir * fix workspace preparing * squash to 1 command * test * bazel build * plan test * register flag manually * bazel tidy * fix linter * remove MAA variable * fix workdir * accept tf variables * variable fetching * fix resource indices * accept Terraform targets * refactor upgrade command * Terraform migration apply unit test * pass down image fetcher to test * use new flags in e2e test * move file name to constant * update buildfiles * fix version constant * conditionally create MAA * move interface down * upgrade dir * update buildfiles * fix interface * fix createMAA check * fix imports * update buildfiles * wip: workspace backup * copy utils * backup upgrade workspace * remove debug print * replace old state after upgrade * check if flag exists * prepare test workspace * remove prefix Co-authored-by: Otto Bittner <cobittner@posteo.net> * respect file permissions * refactor tf upgrader * check workspace before upgrades * remove temp upgrade dir after completion * clean up workspace after abortion * fix upgrade apply test * fix linter --------- Co-authored-by: Otto Bittner <cobittner@posteo.net>
2025-06-06 05:39:08 -04:00 · 2023-05-22 13:31:20 +02:00 · 2023-05-22 13:31:20 +02:00 · c69e6777bd
commit c69e6777bd
parent 339e750c18
21 changed files with 1391 additions and 44 deletions
--- a/internal/file/file_test.go
+++ b/internal/file/file_test.go
@ -8,6 +8,8 @@ package file

 import (
 	"encoding/json"
+	"io/fs"
+	"path/filepath"
 	"testing"

 	"github.com/edgelesssys/constellation/v2/internal/constants"
@ -350,3 +352,123 @@ func TestRemove(t *testing.T) {

 	assert.Error(handler.Remove("d"))
 }
+
+func TestCopyFile(t *testing.T) {
+	perms := fs.FileMode(0o644)
+
+	setupFs := func(existingFiles ...string) afero.Fs {
+		fs := afero.NewMemMapFs()
+		aferoHelper := afero.Afero{Fs: fs}
+		for _, file := range existingFiles {
+			require.NoError(t, aferoHelper.WriteFile(file, []byte{}, perms))
+		}
+		return fs
+	}
+
+	testCases := map[string]struct {
+		fs         afero.Fs
+		copyFiles  [][]string
+		checkFiles []string
+		opts       []Option
+		wantErr    bool
+	}{
+		"successful copy": {
+			fs:         setupFs("a"),
+			copyFiles:  [][]string{{"a", "b"}},
+			checkFiles: []string{"b"},
+		},
+		"copy to existing file overwrite": {
+			fs:         setupFs("a", "b"),
+			copyFiles:  [][]string{{"a", "b"}},
+			checkFiles: []string{"b"},
+			opts:       []Option{OptOverwrite},
+		},
+		"copy to existing file no overwrite": {
+			fs:         setupFs("a", "b"),
+			copyFiles:  [][]string{{"a", "b"}},
+			checkFiles: []string{"b"},
+			wantErr:    true,
+		},
+		"file doesn't exist": {
+			fs:         setupFs("a"),
+			copyFiles:  [][]string{{"b", "c"}},
+			checkFiles: []string{"a"},
+			wantErr:    true,
+		},
+	}
+
+	for name, tc := range testCases {
+		t.Run(name, func(t *testing.T) {
+			assert := assert.New(t)
+			require := require.New(t)
+
+			handler := NewHandler(tc.fs)
+			for _, files := range tc.copyFiles {
+				err := handler.CopyFile(files[0], files[1], tc.opts...)
+				if tc.wantErr {
+					assert.Error(err)
+				} else {
+					assert.NoError(err)
+				}
+			}
+
+			for _, file := range tc.checkFiles {
+				info, err := handler.fs.Stat(file)
+				assert.Equal(perms, info.Mode())
+				require.NoError(err)
+			}
+		})
+	}
+}
+
+func TestCopyDir(t *testing.T) {
+	setupHandler := func(existingFiles ...string) Handler {
+		fs := afero.NewMemMapFs()
+		handler := NewHandler(fs)
+		for _, file := range existingFiles {
+			err := handler.Write(file, []byte("some content"), OptMkdirAll)
+			require.NoError(t, err)
+		}
+		return handler
+	}
+
+	testCases := map[string]struct {
+		handler    Handler
+		copyFiles  [][]string
+		checkFiles []string
+		opts       []Option
+	}{
+		"successful copy": {
+			handler:    setupHandler(filepath.Join("someDir", "someFile"), filepath.Join("someDir", "someOtherDir", "someOtherFile")),
+			copyFiles:  [][]string{{"someDir", "copiedDir"}},
+			checkFiles: []string{filepath.Join("copiedDir", "someFile"), filepath.Join("copiedDir", "someOtherDir", "someOtherFile")},
+		},
+		"copy file": {
+			handler:    setupHandler("someFile"),
+			copyFiles:  [][]string{{"someFile", "copiedFile"}},
+			checkFiles: []string{"copiedFile"},
+		},
+		"copy to existing dir overwrite": {
+			handler:    setupHandler(filepath.Join("someDir", "someFile"), filepath.Join("someDir", "someOtherDir", "someOtherFile"), filepath.Join("copiedDir", "someExistingFile")),
+			copyFiles:  [][]string{{"someDir", "copiedDir"}},
+			checkFiles: []string{filepath.Join("copiedDir", "someFile"), filepath.Join("copiedDir", "someOtherDir", "someOtherFile"), filepath.Join("copiedDir", "someExistingFile")},
+			opts:       []Option{OptOverwrite},
+		},
+	}
+
+	for name, tc := range testCases {
+		t.Run(name, func(t *testing.T) {
+			require := require.New(t)
+
+			for _, files := range tc.copyFiles {
+				err := tc.handler.CopyDir(files[0], files[1], tc.opts...)
+				require.NoError(err)
+			}
+
+			for _, file := range tc.checkFiles {
+				_, err := tc.handler.fs.Stat(file)
+				require.NoError(err)
+			}
+		})
+	}
+}