From c1168588e619604f08f0f8160357beca5e2dd4ba Mon Sep 17 00:00:00 2001 From: miampf Date: Wed, 10 Jan 2024 14:16:45 +0100 Subject: [PATCH] dont rewrite operators and dont write replaceAttr function --- internal/logger/grpclogger.go | 5 ----- operators/constellation-node-operator/main.go | 1 - 2 files changed, 6 deletions(-) diff --git a/internal/logger/grpclogger.go b/internal/logger/grpclogger.go index bf96c4eb6..8116626d2 100644 --- a/internal/logger/grpclogger.go +++ b/internal/logger/grpclogger.go @@ -93,11 +93,6 @@ func (l *grpcLogger) Errorf(format string, args ...interface{}) { _ = l.logger.Handler().Handle(context.Background(), r) } -// TODO(miampf): Find a way to log on a fatal level, not an error level? -// A ReplaceAttr function could be implemented in the logger package, however -// this would increase it's complexity again (look [here](https://pkg.go.dev/log/slog#HandlerOptions) -// for a reference implementation. - func (l *grpcLogger) Fatal(args ...interface{}) { var pcs [1]uintptr runtime.Callers(2, pcs[:]) diff --git a/operators/constellation-node-operator/main.go b/operators/constellation-node-operator/main.go index dcc61f3c9..07e3b303b 100644 --- a/operators/constellation-node-operator/main.go +++ b/operators/constellation-node-operator/main.go @@ -75,7 +75,6 @@ func main() { flag.BoolVar(&enableLeaderElection, "leader-elect", false, "Enable leader election for controller manager. "+ "Enabling this will ensure there is only one active controller manager.") - // TODO(miampf): Find out what is going on here and reimplement it in log/slog. opts := zap.Options{ Development: true, }