From bf06a014a4e95aceb0d8e0ba71b5303821a08449 Mon Sep 17 00:00:00 2001 From: Malte Poll <1780588+malt3@users.noreply.github.com> Date: Thu, 9 Nov 2023 11:16:31 +0100 Subject: [PATCH] bootstrapper: ignore "journald" not in $PATH in constructor In unit tests, NewCollector may be called on systems that do not have "journalctl" in $PATH. We can defer checking if the command can work by not checking cmd.Err in the constructor. --- bootstrapper/internal/journald/journald.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/bootstrapper/internal/journald/journald.go b/bootstrapper/internal/journald/journald.go index 3854310c8..bf040a1a0 100644 --- a/bootstrapper/internal/journald/journald.go +++ b/bootstrapper/internal/journald/journald.go @@ -30,9 +30,6 @@ type Collector struct { // NewCollector creates a new Collector for journald logs. func NewCollector(ctx context.Context) (*Collector, error) { cmd := exec.CommandContext(ctx, "journalctl") - if cmd.Err != nil { - return nil, cmd.Err - } stdoutPipe, err := cmd.StdoutPipe() if err != nil { return nil, err