From be130dbcf304edb95c61de6b1edcc1992eacd937 Mon Sep 17 00:00:00 2001 From: Malte Poll <1780588+malt3@users.noreply.github.com> Date: Tue, 28 Nov 2023 14:44:17 +0100 Subject: [PATCH] bazel: remove unused go_ld_test This was an attempt to make unit tests work where we linked against libraries and ld from Fedora. This is no longer needed. --- bazel/go/go_test.bzl | 73 -------------------------------------------- 1 file changed, 73 deletions(-) diff --git a/bazel/go/go_test.bzl b/bazel/go/go_test.bzl index 0277132ef..0db8b9f5a 100644 --- a/bazel/go/go_test.bzl +++ b/bazel/go/go_test.bzl @@ -40,76 +40,3 @@ def go_test(ld = None, count = 3, **kwargs): kwargs["gc_linkopts"] += ["-I", ld] _go_test(**kwargs) - -def _vars_script(env, ld, cmd): - ret = ["#!/bin/sh"] - for k, v in env.items(): - ret.append('export {}="{}"'.format(k, v)) - ret.append('exec {} {} "$@"'.format(ld, cmd)) - return "\n".join(ret) + "\n" - -def _ld_binary_impl(ctx): - source_info = ctx.attr.src[DefaultInfo] - ld_info = ctx.attr.ld[DefaultInfo] - - executable = None - if source_info.files_to_run and source_info.files_to_run.executable: - command = _vars_script(ctx.attr.env, ld_info.files_to_run.executable.short_path, source_info.files_to_run.executable.short_path) - executable = ctx.actions.declare_file("{}_under_ld".format(ctx.file.src.basename)) - ctx.actions.write( - output = executable, - content = command, - is_executable = True, - ) - - runfiles = ctx.runfiles(files = ctx.files.src) - runfiles = runfiles.merge(source_info.data_runfiles) - runfiles = runfiles.merge(ctx.runfiles(files = ctx.files.ld)) - runfiles = runfiles.merge(ld_info.data_runfiles) - return [DefaultInfo( - executable = executable, - files = depset([executable]), - runfiles = runfiles, - )] - -_attrs = { - "env": attr.string_dict( - doc = "Environment variables for the test", - ), - "ld": attr.label( - executable = True, - cfg = "exec", - doc = "ld wrapper executable", - ), - "src": attr.label( - allow_single_file = True, - mandatory = True, - doc = "Target to build.", - ), -} - -ld_test = rule( - implementation = _ld_binary_impl, - attrs = _attrs, - executable = True, - test = True, -) - -def go_ld_test(**kwargs): - """go_ld_test is a wrapper for go_test that uses the specified ld to run the test binary under. - - Args: - **kwargs: all arguments are passed to go_test. - """ - - # Sets test count to 3. - kwargs.setdefault("args", []) - kwargs["args"].append("--test.count=3") - - # Disable test wrapper - kwargs.setdefault("env", {}) - kwargs["env"]["GO_TEST_WRAP"] = "0" - - ld_test( - **kwargs - )