aws: use new LB controller to fix SecurityGroup cleanup on K8s service deletion (#2090)

* add current chart

add current helm chart

* disable service controller for aws ccm

* add new iam roles

* doc AWS internet LB + add to LB test

* pass clusterName to helm for AWS LB

* fix update-aws-lb chart to also include .helmignore

* move chart outside services

* working state

* add subnet tags for AWS subnet discovery

* fix .helmignore load rule with file in subdirectory

* upgrade iam profile

* revert new loader impl since cilium is not correctly loaded

* install chart if not already present during `upgrade apply`

* cleanup PR + fix build + add todos

cleanup PR + add todos

* shared helm pkg for cli install and bootstrapper

* add link to eks docs

* refactor iamMigrationCmd

* delete unused helm.symwallk

* move iammigrate to upgrade pkg

* fixup! delete unused helm.symwallk

* add to upgradecheck

* remove nodeSelector from go code (Otto)

* update iam docs and sort permission + remove duplicate roles

* fix bug in `upgrade check`

* better upgrade check output when svc version upgrade not possible

* pr feedback

* remove force flag in upgrade_test

* use upgrader.GetUpgradeID instead of extra type

* remove todos + fix check

* update doc lb (leo)

* remove bootstrapper helm package

* Update cli/internal/cmd/upgradecheck.go

Co-authored-by: Daniel Weiße <66256922+daniel-weisse@users.noreply.github.com>

* final nits

* add docs for e2e upgrade test setup

* Apply suggestions from code review

Co-authored-by: Daniel Weiße <66256922+daniel-weisse@users.noreply.github.com>

* Update cli/internal/helm/loader.go

Co-authored-by: Daniel Weiße <66256922+daniel-weisse@users.noreply.github.com>

* Update cli/internal/cmd/tfmigrationclient.go

Co-authored-by: Daniel Weiße <66256922+daniel-weisse@users.noreply.github.com>

* fix daniel review

* link to the iam permissions instead of manually updating them (agreed with leo)

* disable iam upgrade in upgrade apply

---------

Co-authored-by: Daniel Weiße <66256922+daniel-weisse@users.noreply.github.com>
Co-authored-by: Malte Poll

cli/internal/helm/update-aws-load-balancer-chart.sh

@@ -0,0 +1,50 @@
+#!/usr/bin/env bash
+
+# updates the Helm charts for the AWS Load Balancer Controller in the CLI.
+# script is mostly copied from cli/internal/helm/update-csi-charts.sh
+
+set -euo pipefail
+set -o errtrace
+shopt -s inherit_errexit
+
+echo "Updating AWS Load Balancer Controller Helm chart..."
+branch="v0.0.140" # releases can update the AWS load-balancer-controller chart
+# Required tools
+if ! command -v git &> /dev/null; then
+  echo "git could not be found"
+  exit 1
+fi
+
+callDir=$(pwd)
+repo_tmp_dir=$(mktemp -d)
+
+chart_base_path="charts"
+chart_name="aws-load-balancer-controller"
+
+chart_url="https://github.com/aws/eks-charts"
+chart_dir="stable/aws-load-balancer-controller"
+cd "${repo_tmp_dir}"
+git clone \
+  --filter=blob:none \
+  --no-checkout \
+  --sparse \
+  --depth 1 \
+  --branch="${branch}" \
+  "${chart_url}" "${repo_tmp_dir}"
+
+git sparse-checkout add "${chart_dir}"
+git checkout
+cd "${callDir}"
+
+# remove files being ignored in .helmignore due to wrong import of .helmignore in current implementation
+rm -r "${repo_tmp_dir}/${chart_dir}/ci"
+rm "${repo_tmp_dir}/${chart_dir}/crds/kustomization.yaml"
+rm "${repo_tmp_dir}/${chart_dir}/test.yaml"
+
+# delete current chart
+rm -r "${chart_base_path:?}/${chart_name}"
+
+# move new chart
+mkdir -p "${chart_base_path}/${chart_name}"
+# do not use /* because it will not copy hidden files
+cp -r "${repo_tmp_dir}/${chart_dir}" "${chart_base_path}/"