Git-Mirrors/constellation
1
0
Fork 0
mirror of https://github.com/edgelesssys/constellation.git synced 2025-05-03 14:54:53 -04:00
Code Issues Projects Releases Packages Wiki Activity

cli: cleanup terraform files when create fails (#2282)

Browse source
This commit is contained in:
Adrian Stobbe 2023-08-24 16:38:02 +02:00 • committed by GitHub
parent b278b76df5
commit 9e79e2e0a1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 37 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

40
cli/internal/cloudcmd/rollback_test.go
View file

@ -7,6 +7,7 @@ SPDX-License-Identifier: AGPL-3.0-only
package cloudcmd
import (
"bytes"
"context"
"errors"
"testing"
@ -19,19 +20,20 @@ func TestRollbackTerraform(t *testing.T) {
someErr := errors.New("failed")
testCases := map[string]struct {
tfClient *stubTerraformClient
wantErr bool
tfClient *stubTerraformClient
wantCleanupErr bool
wantDestroyErr bool
}{
"success": {
tfClient: &stubTerraformClient{},
},
"destroy cluster error": {
tfClient: &stubTerraformClient{destroyErr: someErr},
wantErr: true,
tfClient: &stubTerraformClient{destroyErr: someErr},
wantDestroyErr: true,
},
"clean up workspace error": {
tfClient: &stubTerraformClient{cleanUpWorkspaceErr: someErr},
wantErr: true,
tfClient: &stubTerraformClient{cleanUpWorkspaceErr: someErr},
wantCleanupErr: true,
},
}
@ -43,14 +45,20 @@ func TestRollbackTerraform(t *testing.T) {
client: tc.tfClient,
}
err := rollbacker.rollback(context.Background(), terraform.LogLevelNone)
if tc.wantErr {
destroyClusterErrOutput := &bytes.Buffer{}
err := rollbacker.rollback(context.Background(), destroyClusterErrOutput, terraform.LogLevelNone)
if tc.wantCleanupErr {
assert.Error(err)
if tc.tfClient.cleanUpWorkspaceErr == nil {
assert.False(tc.tfClient.cleanUpWorkspaceCalled)
}
return
}
if tc.wantDestroyErr {
assert.Error(err)
assert.Equal("Could not destroy the resources. Please delete the \"constellation-terraform\" directory manually if no resources were created\n", destroyClusterErrOutput.String())
return
}
assert.NoError(err)
assert.True(tc.tfClient.destroyCalled)
assert.True(tc.tfClient.cleanUpWorkspaceCalled)
@ -65,6 +73,7 @@ func TestRollbackQEMU(t *testing.T) {
libvirt *stubLibvirtRunner
tfClient *stubTerraformClient
createdWorkspace bool
wantDestroyErr bool
wantErr bool
}{
"success": {
@ -78,9 +87,9 @@ func TestRollbackQEMU(t *testing.T) {
wantErr: true,
},
"destroy cluster error": {
libvirt: &stubLibvirtRunner{stopErr: someErr},
tfClient: &stubTerraformClient{destroyErr: someErr},
wantErr: true,
libvirt: &stubLibvirtRunner{stopErr: someErr},
tfClient: &stubTerraformClient{destroyErr: someErr},
wantDestroyErr: true,
},
"clean up workspace error": {
libvirt: &stubLibvirtRunner{},
@ -99,7 +108,9 @@ func TestRollbackQEMU(t *testing.T) {
createdWorkspace: tc.createdWorkspace,
}
err := rollbacker.rollback(context.Background(), terraform.LogLevelNone)
destroyClusterErrOutput := &bytes.Buffer{}
err := rollbacker.rollback(context.Background(), destroyClusterErrOutput, terraform.LogLevelNone)
if tc.wantErr {
assert.Error(err)
if tc.tfClient.cleanUpWorkspaceErr == nil {
@ -107,6 +118,11 @@ func TestRollbackQEMU(t *testing.T) {
}
return
}
if tc.wantDestroyErr {
assert.Error(err)
assert.Equal("Could not destroy the resources. Please delete the \"constellation-terraform\" directory manually if no resources were created\n", destroyClusterErrOutput.String())
return
}
assert.NoError(err)
assert.True(tc.libvirt.stopCalled)
if tc.createdWorkspace {