terraform: align infrastructure module attributes (#2703)

* all vars have snail_case

* make iam schema consistent

* infrastructure schema

* terraform: update AWS infrastructure module

* fix ci

* terraform: update AWS infrastructure module

* terraform: update AWS IAM module

* terraform: update Azure Infrastructure module inputs

Signed-off-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>

* terraform: update Azure IAM module

Signed-off-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>

* terraform: update GCP infrastructure module

Signed-off-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>

* terraform: update GCP IAM module

Signed-off-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>

* terraform: update OpenStack Infrastructure module

Signed-off-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>

* terraform: update QEMU Infrastructure module

Signed-off-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>

* terraform-module: fix input name

Signed-off-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>

* terraform: tidy

* cli: ignore whitespace in Terraform variable tests

* terraform-module: fix AWS output names

* terraform-module: fix output references

Signed-off-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>

* terraform: rename `api_server_cert_sans`

* Update terraform/infrastructure/aws/modules/public_private_subnet/variables.tf

Co-authored-by: Daniel Weiße <66256922+daniel-weisse@users.noreply.github.com>

* fix self-managed

* terraform: revert AWS modules output file renaming

* terraform: remove duplicate varable declaration

* terraform: rename Azure location field

* ci: adjust output name in self-managed e2e test

* e2e: continuously print output in upgrade test

* e2e: write to output variables

* cli: migrate IAM variable names

* cli: make `location` field optional

---------

Signed-off-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>
Co-authored-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>
Co-authored-by: Daniel Weiße <66256922+daniel-weisse@users.noreply.github.com>

terraform/infrastructure/aws/modules/instance_group/variables.tf

@@ -10,7 +10,7 @@ variable "node_group_name" {
 
 variable "role" {
   type        = string
-  description = "The role of the instance group."
+  description = "Role of the instance group."
   validation {
     condition     = contains(["control-plane", "worker"], var.role)
     error_message = "The role has to be 'control-plane' or 'worker'."
@@ -19,7 +19,7 @@ variable "role" {
 
 variable "uid" {
   type        = string
-  description = "UID of the cluster. This is used for tags."
+  description = "Unique Identifier (UID) of the cluster."
 }
 
 variable "instance_type" {
@@ -34,7 +34,7 @@ variable "initial_count" {
 
 variable "image_id" {
   type        = string
-  description = "Image ID for the nodes."
+  description = "Amazon Machine Image (AMI) ID for the cluster's nodes."
 }
 
 variable "state_disk_type" {
@@ -64,18 +64,18 @@ variable "iam_instance_profile" {
 
 variable "security_groups" {
   type        = list(string)
-  description = "List of IDs of the security groups for an instance."
+  description = "List of security group IDs for an instance."
 }
 
 variable "tags" {
   type        = map(string)
-  description = "The tags to add to the instance group."
+  description = "Tags to add to the instance group."
 }
 
 variable "enable_snp" {
   type        = bool
   default     = true
-  description = "Enable AMD SEV SNP. Setting this to true sets the cpu-option AmdSevSnp to enable."
+  description = "Enable AMD SEV-SNP for the instances."
 }
 
 variable "zone" {

terraform/infrastructure/aws/modules/jump_host/main.tf

@@ -7,7 +7,6 @@ terraform {
   }
 }
 
-
 data "aws_ami" "ubuntu" {
   most_recent = true
   owners      = ["099720109477"] # Canonical
@@ -55,5 +54,4 @@ iptables -t nat -A PREROUTING -p tcp --dport ${port} -j DNAT --to-destination $$
 iptables -t nat -A POSTROUTING -p tcp -d $${lb_ip} --dport ${port} -j SNAT --to-source $${internal_ip}
 %{endfor~}
 EOF
-
 }

terraform/infrastructure/aws/modules/jump_host/output.tf

@@ -1,3 +1,4 @@
 output "ip" {
-  value = aws_instance.jump_host.public_ip
+  value       = aws_instance.jump_host.public_ip
+  description = "Public IP of the jump host."
 }

terraform/infrastructure/aws/modules/jump_host/variables.tf

@@ -1,28 +1,28 @@
 variable "base_name" {
-  description = "Base name of the jump host"
-  type        = string
-}
-
-variable "subnet_id" {
-  description = "Subnet ID to deploy the jump host into"
-  type        = string
-}
-
-variable "lb_internal_ip" {
-  description = "Internal IP of the load balancer"
-  type        = string
-}
-
-variable "iam_instance_profile" {
-  description = "IAM instance profile to attach to the jump host"
+  description = "Base name of the jump host."
   type        = string
 }
 
 variable "ports" {
-  description = "Ports to forward to the load balancer"
+  description = "Ports to forward to the load balancer."
   type        = list(number)
 }
 
+variable "subnet_id" {
+  description = "Subnet ID to deploy the jump host into."
+  type        = string
+}
+
+variable "lb_internal_ip" {
+  description = "Internal IP of the load balancer."
+  type        = string
+}
+
+variable "iam_instance_profile" {
+  description = "IAM instance profile to attach to the jump host."
+  type        = string
+}
+
 variable "security_groups" {
   type        = list(string)
   description = "List of IDs of the security groups for an instance."

terraform/infrastructure/aws/modules/load_balancer_target/main.tf

@@ -8,7 +8,7 @@ terraform {
 }
 
 resource "aws_lb_target_group" "front_end" {
-  name               = var.name
+  name               = var.base_name
   port               = var.port
   protocol           = "TCP"
   vpc_id             = var.vpc_id

terraform/infrastructure/aws/modules/load_balancer_target/output.tf

@@ -1,3 +1,4 @@
 output "target_group_arn" {
-  value = aws_lb_target_group.front_end.arn
+  value       = aws_lb_target_group.front_end.arn
+  description = "ARN of the load balancer target group."
 }

terraform/infrastructure/aws/modules/load_balancer_target/variables.tf

@@ -1,6 +1,6 @@
-variable "name" {
+variable "base_name" {
   type        = string
-  description = "Name of the load balancer target."
+  description = "Base name of the load balancer target."
 }
 
 variable "port" {
@@ -32,5 +32,5 @@ variable "healthcheck_path" {
 
 variable "tags" {
   type        = map(string)
-  description = "The tags to add to the loadbalancer."
+  description = "Tags to add to the loadbalancer."
 }

terraform/infrastructure/aws/modules/public_private_subnet/output.tf

@@ -3,6 +3,7 @@ output "private_subnet_id" {
     for az in data.aws_availability_zone.all :
     az.name => aws_subnet.private[az.name].id
   }
+  description = "Map of availability zones to private subnet id."
 }
 
 output "public_subnet_id" {

terraform/infrastructure/aws/modules/public_private_subnet/variables.tf

@@ -1,6 +1,6 @@
 variable "name" {
   type        = string
-  description = "Name of your Constellation, which is used as a prefix for tags."
+  description = "Name of the Constellation cluster."
 }
 
 variable "vpc_id" {
@@ -30,5 +30,5 @@ variable "cidr_vpc_subnet_internet" {
 
 variable "tags" {
   type        = map(string)
-  description = "The tags to add to the resource."
+  description = "Tags to add to the resource."
 }