From 860d72a083b55d2d13b69dcd7ad703e0c1fc709f Mon Sep 17 00:00:00 2001
From: Paul Meyer <49727155+katexochen@users.noreply.github.com>
Date: Fri, 14 Apr 2023 18:50:58 +0200
Subject: [PATCH] ci: reduce number of steps with continue-on-error (#1593)

Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
---
 .github/actions/constellation_create/action.yml  | 1 +
 .github/actions/constellation_destroy/action.yml | 1 -
 .github/workflows/build-os-image.yml             | 7 -------
 .github/workflows/e2e-test-release.yml           | 3 ---
 .github/workflows/e2e-upgrade.yml                | 1 -
 5 files changed, 1 insertion(+), 12 deletions(-)

diff --git a/.github/actions/constellation_create/action.yml b/.github/actions/constellation_create/action.yml
index 941c362a4..73f7c70ce 100644
--- a/.github/actions/constellation_create/action.yml
+++ b/.github/actions/constellation_create/action.yml
@@ -268,6 +268,7 @@ runs:
 
     - name: Upload boot logs
       if: always() && !env.ACT
+      continue-on-error: true
       uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # v3.1.2
       with:
         name: serial-logs-${{ inputs.artifactNameSuffix }}
diff --git a/.github/actions/constellation_destroy/action.yml b/.github/actions/constellation_destroy/action.yml
index b6b792e17..9283c853f 100644
--- a/.github/actions/constellation_destroy/action.yml
+++ b/.github/actions/constellation_destroy/action.yml
@@ -11,7 +11,6 @@ runs:
   steps:
     - name: Delete persistent volumes
       if: inputs.kubeconfig != ''
-      continue-on-error: true
       shell: bash
       env:
         KUBECONFIG: ${{ inputs.kubeconfig }}
diff --git a/.github/workflows/build-os-image.yml b/.github/workflows/build-os-image.yml
index 635fdc692..ec28e7ba0 100644
--- a/.github/workflows/build-os-image.yml
+++ b/.github/workflows/build-os-image.yml
@@ -317,7 +317,6 @@ jobs:
 
       - name: Collect hashes
         id: collect-hashes
-        continue-on-error: true
         working-directory: ${{ github.workspace }}/image/mkosi.output.${{ matrix.csp }}/fedora~37
         run: |
           {
@@ -332,16 +331,12 @@ jobs:
           } | tee -a "$GITHUB_OUTPUT"
 
       - name: Upload raw OS image as artifact
-        if: always()
-        continue-on-error: true
         uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # v3.1.2
         with:
           name: image-${{ matrix.csp }}
           path: ${{ github.workspace }}/image/mkosi.output.${{ matrix.csp }}/fedora~37/image.raw
 
       - name: Upload individual OS parts as artifacts
-        if: always()
-        continue-on-error: true
         uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # v3.1.2
         with:
           name: parts-${{ matrix.csp }}
@@ -355,8 +350,6 @@ jobs:
             ${{ github.workspace }}/image/mkosi.output.${{ matrix.csp }}/fedora~37/image.vmlinuz
 
       - name: Upload manifest as artifact
-        if: always()
-        continue-on-error: true
         uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # v3.1.2
         with:
           name: manifest-${{ matrix.csp }}
diff --git a/.github/workflows/e2e-test-release.yml b/.github/workflows/e2e-test-release.yml
index 1317a0e28..e337d2056 100644
--- a/.github/workflows/e2e-test-release.yml
+++ b/.github/workflows/e2e-test-release.yml
@@ -165,17 +165,14 @@ jobs:
           azureClusterCreateCredentials: ${{ secrets.AZURE_E2E_CLUSTER_CREDENTIALS }}
           azureIAMCreateCredentials: ${{ secrets.AZURE_E2E_IAM_CREDENTIALS }}
 
-
       - name: Always terminate cluster
         if: always()
-        continue-on-error: true
         uses: ./.github/actions/constellation_destroy
         with:
           kubeconfig: ${{ steps.e2e_test.outputs.kubeconfig }}
 
       - name: Always delete IAM configuration
         if: always()
-        continue-on-error: true
         uses: ./.github/actions/constellation_iam_destroy
         with:
           cloudProvider: ${{ matrix.provider }}
diff --git a/.github/workflows/e2e-upgrade.yml b/.github/workflows/e2e-upgrade.yml
index 086b2726f..ea3bea9b3 100644
--- a/.github/workflows/e2e-upgrade.yml
+++ b/.github/workflows/e2e-upgrade.yml
@@ -171,7 +171,6 @@ jobs:
 
       - name: Always upload logs
         if: always()
-        continue-on-error: true
         uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # v3.1.2
         with:
           name: upgrade-logs