From 6e5ba774d89516b5914c067d04f315de86bd1fb0 Mon Sep 17 00:00:00 2001 From: Otto Bittner Date: Mon, 4 Sep 2023 16:32:06 +0200 Subject: [PATCH] cli: disable nosmt via VMM temporarily. AWS asked us to disable these options temporarily until they resolve some internal issues that sometimes prevents these instances from starting. --- .../terraform/terraform/aws/modules/instance_group/main.tf | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/cli/internal/terraform/terraform/aws/modules/instance_group/main.tf b/cli/internal/terraform/terraform/aws/modules/instance_group/main.tf index 538a55b81..de323305f 100644 --- a/cli/internal/terraform/terraform/aws/modules/instance_group/main.tf +++ b/cli/internal/terraform/terraform/aws/modules/instance_group/main.tf @@ -54,11 +54,12 @@ resource "aws_launch_template" "launch_template" { # Disable SMT. We are already disabling it inside the image. # Disabling SMT only in the image, not in the Hypervisor creates problems. # Thus, also disable it in the Hypervisor. - threads_per_core = 1 + # TODO (derpsteb): reenable once AWS confirms it's safe to do so. + # threads_per_core = 1 # When setting threads_per_core we also have to set core_count. # For the currently supported SNP instance families (C6a, M6a, R6a) default_cores # equals the maximum number of available cores. - core_count = data.aws_ec2_instance_type.instance_data.default_cores + # core_count = data.aws_ec2_instance_type.instance_data.default_cores } lifecycle {