From 64c32c22366988f16cdd7167dee489956c93aafa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Wei=C3=9Fe?=
 <66256922+daniel-weisse@users.noreply.github.com>
Date: Mon, 5 Feb 2024 15:46:57 +0100
Subject: [PATCH] ci: make instance type configurable for provider sample
 (#2893)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Make default instance type configurable for provider sample
* Set TDX instance type when running TDX provider e2e test
* Fix missing attestation variant when setting up stub config in provider e2e test

---------

Signed-off-by: Daniel Weiße <dw@edgeless.systems>
---
 .github/workflows/e2e-test-provider-example.yml    | 14 +++++++++++++-
 .../examples/full/aws/main.tf                      |  5 +++--
 .../examples/full/azure/main.tf                    |  5 +++--
 .../examples/full/gcp/main.tf                      |  5 +++--
 4 files changed, 22 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/e2e-test-provider-example.yml b/.github/workflows/e2e-test-provider-example.yml
index 89c6a63b3..8e81029da 100644
--- a/.github/workflows/e2e-test-provider-example.yml
+++ b/.github/workflows/e2e-test-provider-example.yml
@@ -301,6 +301,18 @@ jobs:
           EOF
           cat _override.tf
 
+      - name: Create Azure TDX Terraform overrides
+        if: inputs.attestationVariant == 'azure-tdx'
+        working-directory: ${{ github.workspace }}/cluster
+        shell: bash
+        run: |
+          cat >> _override.tf <<EOF
+          locals {
+            instance_type = "Standard_DC4es_v5"
+          }
+          EOF
+          cat _override.tf
+
       - name: Copy example Terraform file
         working-directory: ${{ github.workspace }}
         shell: bash
@@ -408,7 +420,7 @@ jobs:
           fi
 
           # cfg must be in same dir as KUBECONFIG
-          ${{ github.workspace }}/build/constellation config generate "${{ steps.determine.outputs.cloudProvider }}"
+          ${{ github.workspace }}/build/constellation config generate "${{ steps.determine.outputs.cloudProvider }}" --attestation ${{ inputs.attestationVariant}}
           # make cfg valid with fake data
           # IMPORTANT: zone needs to be correct because it is used to resolve the CSP image ref
           if [[ "${{ steps.determine.outputs.cloudProvider }}" == "azure" ]]; then
diff --git a/terraform-provider-constellation/examples/full/aws/main.tf b/terraform-provider-constellation/examples/full/aws/main.tf
index 1fefc2b8f..4a467d5e4 100644
--- a/terraform-provider-constellation/examples/full/aws/main.tf
+++ b/terraform-provider-constellation/examples/full/aws/main.tf
@@ -22,6 +22,7 @@ locals {
   zone                 = "us-east-2c"
   control_plane_count  = 3
   worker_count         = 2
+  instance_type        = "m6a.xlarge"
 
   master_secret      = random_bytes.master_secret.hex
   master_secret_salt = random_bytes.master_secret_salt.hex
@@ -54,7 +55,7 @@ module "aws_infrastructure" {
   node_groups = {
     control_plane_default = {
       role          = "control-plane"
-      instance_type = "m6a.xlarge"
+      instance_type = local.instance_type
       disk_size     = 30
       disk_type     = "gp3"
       initial_count = local.control_plane_count
@@ -62,7 +63,7 @@ module "aws_infrastructure" {
     },
     worker_default = {
       role          = "worker"
-      instance_type = "m6a.xlarge"
+      instance_type = local.instance_type
       disk_size     = 30
       disk_type     = "gp3"
       initial_count = local.worker_count
diff --git a/terraform-provider-constellation/examples/full/azure/main.tf b/terraform-provider-constellation/examples/full/azure/main.tf
index 1fcb4cf30..629f07e2d 100644
--- a/terraform-provider-constellation/examples/full/azure/main.tf
+++ b/terraform-provider-constellation/examples/full/azure/main.tf
@@ -21,6 +21,7 @@ locals {
   location             = "northeurope"
   control_plane_count  = 3
   worker_count         = 2
+  instance_type        = "Standard_DC4as_v5"
 
   master_secret      = random_bytes.master_secret.hex
   master_secret_salt = random_bytes.master_secret_salt.hex
@@ -55,14 +56,14 @@ module "azure_infrastructure" {
   node_groups = {
     control_plane_default = {
       role          = "control-plane"
-      instance_type = "Standard_DC4as_v5"
+      instance_type = local.instance_type
       disk_size     = 30
       disk_type     = "Premium_LRS"
       initial_count = local.control_plane_count
     },
     worker_default = {
       role          = "worker"
-      instance_type = "Standard_DC4as_v5"
+      instance_type = local.instance_type
       disk_size     = 30
       disk_type     = "Premium_LRS"
       initial_count = local.worker_count
diff --git a/terraform-provider-constellation/examples/full/gcp/main.tf b/terraform-provider-constellation/examples/full/gcp/main.tf
index f4f975c44..1db0f63fb 100644
--- a/terraform-provider-constellation/examples/full/gcp/main.tf
+++ b/terraform-provider-constellation/examples/full/gcp/main.tf
@@ -23,6 +23,7 @@ locals {
   project_id           = "constellation-331613"
   control_plane_count  = 3
   worker_count         = 2
+  instance_type        = "n2d-standard-4"
 
   master_secret      = random_bytes.master_secret.hex
   master_secret_salt = random_bytes.master_secret_salt.hex
@@ -57,7 +58,7 @@ module "gcp_infrastructure" {
   node_groups = {
     control_plane_default = {
       role          = "control-plane"
-      instance_type = "n2d-standard-4"
+      instance_type = local.instance_type
       disk_size     = 30
       disk_type     = "pd-ssd"
       initial_count = local.control_plane_count
@@ -65,7 +66,7 @@ module "gcp_infrastructure" {
     },
     worker_default = {
       role          = "worker"
-      instance_type = "n2d-standard-4"
+      instance_type = local.instance_type
       disk_size     = 30
       disk_type     = "pd-ssd"
       initial_count = local.worker_count