From 5949a5d329cb0b72e5f131e5bdee5b3a21cca770 Mon Sep 17 00:00:00 2001 From: Markus Rudy Date: Tue, 21 May 2024 17:40:37 +0200 Subject: [PATCH] fixup! operators: ignore node deletion errors on absence --- .../internal/cloud/aws/client/nodeimage.go | 2 +- .../internal/cloud/gcp/client/nodeimage.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/operators/constellation-node-operator/internal/cloud/aws/client/nodeimage.go b/operators/constellation-node-operator/internal/cloud/aws/client/nodeimage.go index 602bd8195..78c37601e 100644 --- a/operators/constellation-node-operator/internal/cloud/aws/client/nodeimage.go +++ b/operators/constellation-node-operator/internal/cloud/aws/client/nodeimage.go @@ -224,4 +224,4 @@ func isInstanceNotFoundError(err error) bool { return false } return strings.Contains(err.Error(), "Instance Id not found") -} \ No newline at end of file +} diff --git a/operators/constellation-node-operator/internal/cloud/gcp/client/nodeimage.go b/operators/constellation-node-operator/internal/cloud/gcp/client/nodeimage.go index 321cdfbc1..e69750321 100644 --- a/operators/constellation-node-operator/internal/cloud/gcp/client/nodeimage.go +++ b/operators/constellation-node-operator/internal/cloud/gcp/client/nodeimage.go @@ -139,7 +139,7 @@ func (c *Client) DeleteNode(ctx context.Context, providerID string) error { Project: instanceGroupProject, Zone: instanceGroupZone, InstanceGroupManagersDeleteInstancesRequestResource: &computepb.InstanceGroupManagersDeleteInstancesRequest{ - Instances: []string{instanceID}, + Instances: []string{instanceID}, SkipInstancesOnValidationError: toPtr(true), }, })