Git-Mirrors/constellation
1
0
Fork 0
mirror of https://github.com/edgelesssys/constellation.git synced 2025-02-11 04:28:37 -05:00
Code Issues Packages Projects Releases Wiki Activity

bootstrapper: only err if no control plane IPs available (#3496)

Browse Source 
Previously we errored out of the entire join if retrieval
of either LB IP or control plane public IP failed. This resulted
in the entire "use either IP" logic not working as intended. This now
makes it log a warning only if the IP retrievals fail, and only errors
out of the join if no IP can be found at all.
This commit is contained in:
Moritz Sanft 2024-11-26 10:38:18 +01:00 committed by GitHub
parent fbdf1db053
commit 52372ae808
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bootstrapper/internal/joinclient/joinclient.go
View File

@ -173,13 +173,13 @@ func (c *JoinClient) tryJoinWithAvailableServices() (ticket *joinproto.IssueJoin
endpoint, _, err := c.metadataAPI.GetLoadBalancerEndpoint(ctx) endpoint, _, err := c.metadataAPI.GetLoadBalancerEndpoint(ctx)
if err != nil { if err != nil {
return nil, nil, fmt.Errorf("failed to get load balancer endpoint: %w", err) c.log.Warn("Failed to get load balancer endpoint", "err", err)
} }
endpoints = append(endpoints, endpoint) endpoints = append(endpoints, endpoint)
ips, err := c.getControlPlaneIPs(ctx) ips, err := c.getControlPlaneIPs(ctx)
if err != nil { if err != nil {
return nil, nil, fmt.Errorf("failed to get control plane IPs: %w", err) c.log.Warn("Failed to get control plane IPs", "err", err)
} }
endpoints = append(endpoints, ips...) endpoints = append(endpoints, ips...)