Git-Mirrors/constellation
1
0
Fork 0
mirror of https://github.com/edgelesssys/constellation.git synced 2025-08-24 14:39:22 -04:00
Code Issues Projects Releases Packages Wiki Activity

Ref/want err from err expected (#82)

Browse source 
consistent naming for test values using 'want' instead of 'expect/ed'
This commit is contained in:
datosh 2022-04-26 16:54:05 +02:00 • committed by GitHub
parent 6265b307af
commit 51068abc27
91 changed files with 2319 additions and 2319 deletions
Download patch file Download diff file Expand all files Collapse all files

68
coordinator/role/role_test.go
View file

@ -9,25 +9,25 @@ import (
func TestMarshal(t *testing.T) {
testCases := map[string]struct {
role Role
jsonExpected string
errExpected bool
role Role
wantJson string
wantErr bool
}{
"coordinator role": {
role: Coordinator,
jsonExpected: `"Coordinator"`,
role: Coordinator,
wantJson: `"Coordinator"`,
},
"node role": {
role: Node,
jsonExpected: `"Node"`,
role: Node,
wantJson: `"Node"`,
},
"admin role": {
role: Admin,
jsonExpected: `"Admin"`,
role: Admin,
wantJson: `"Admin"`,
},
"unknown role": {
role: Unknown,
jsonExpected: `"Unknown"`,
role: Unknown,
wantJson: `"Unknown"`,
},
}
@ -37,54 +37,54 @@ func TestMarshal(t *testing.T) {
require := require.New(t)
jsonRole, err := tc.role.MarshalJSON()
if tc.errExpected {
if tc.wantErr {
assert.Error(err)
return
}
require.NoError(err)
assert.Equal(tc.jsonExpected, string(jsonRole))
assert.Equal(tc.wantJson, string(jsonRole))
})
}
}
func TestUnmarshal(t *testing.T) {
testCases := map[string]struct {
json string
expectedRole Role
errExpected bool
json string
wantRole Role
wantErr bool
}{
"Coordinator can be unmarshaled": {
json: `"Coordinator"`,
expectedRole: Coordinator,
json: `"Coordinator"`,
wantRole: Coordinator,
},
"lowercase coordinator can be unmarshaled": {
json: `"coordinator"`,
expectedRole: Coordinator,
json: `"coordinator"`,
wantRole: Coordinator,
},
"Node can be unmarshaled": {
json: `"Node"`,
expectedRole: Node,
json: `"Node"`,
wantRole: Node,
},
"lowercase node can be unmarshaled": {
json: `"node"`,
expectedRole: Node,
json: `"node"`,
wantRole: Node,
},
"Admin can be unmarshaled": {
json: `"Admin"`,
expectedRole: Admin,
json: `"Admin"`,
wantRole: Admin,
},
"lowercase admin can be unmarshaled": {
json: `"admin"`,
expectedRole: Admin,
json: `"admin"`,
wantRole: Admin,
},
"other strings unmarshal to the unknown role": {
json: `"anything"`,
expectedRole: Unknown,
json: `"anything"`,
wantRole: Unknown,
},
"invalid json fails": {
json: `"unterminated string literal`,
errExpected: true,
json: `"unterminated string literal`,
wantErr: true,
},
}
@ -96,13 +96,13 @@ func TestUnmarshal(t *testing.T) {
var role Role
err := role.UnmarshalJSON([]byte(tc.json))
if tc.errExpected {
if tc.wantErr {
assert.Error(err)
return
}
require.NoError(err)
assert.Equal(tc.expectedRole, role)
assert.Equal(tc.wantRole, role)
})
}
}