From 4ba400228a2ec0ccf6a23be839872ed2118a76eb Mon Sep 17 00:00:00 2001
From: miampf <miampf@proton.me>
Date: Tue, 25 Feb 2025 15:50:36 +0100
Subject: [PATCH] refactor check for errors

---
 .github/workflows/check-measurements-reproducibility.yml | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/check-measurements-reproducibility.yml b/.github/workflows/check-measurements-reproducibility.yml
index acc6b4175..4ba389d7f 100644
--- a/.github/workflows/check-measurements-reproducibility.yml
+++ b/.github/workflows/check-measurements-reproducibility.yml
@@ -107,10 +107,9 @@ jobs:
             echo "Own measurements for $attestationVariant:"
             ts "  " < "$attestationVariant"_own-measurements.json
 
-            # not using $? since shellcheck complained about that, so code duplication seems to be
-            # a better tradeoff
-            if ! jd ./"$attestationVariant"_their-measurements.json ./"$attestationVariant"_own-measurements.json; then
-              errors["$attestationVariant"]="$(jd ./"$attestationVariant"_their-measurements.json ./"$attestationVariant"_own-measurements.json)"
+            diff="$(jd ./"$attestationVariant"_their-measurements.json ./"$attestationVariant"_own-measurements.json)"
+            if [[ ! -z "$diff"]]; then
+              errors["$attestationVariant"]="$diff"
             fi
           done