mirror of
https://github.com/edgelesssys/constellation.git
synced 2025-08-14 17:55:34 -04:00
config: iam create aws check zone contains availability zone (#1913)
* init * make zone flag mandatory again * add info about zone update + refactor * add comment in docs about zone update * Update cli/internal/cmd/iamcreate_test.go Co-authored-by: Thomas Tendyck <51411342+thomasten@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Thomas Tendyck <51411342+thomasten@users.noreply.github.com> * thomas feedback * add format check to config validation * remove TODO * Update docs/docs/workflows/config.md Co-authored-by: Thomas Tendyck <51411342+thomasten@users.noreply.github.com> * thomas nit --------- Co-authored-by: Thomas Tendyck <51411342+thomasten@users.noreply.github.com>
This commit is contained in:
parent
5749e885d9
commit
4b16139f07
6 changed files with 274 additions and 36 deletions
|
@ -264,6 +264,7 @@ func TestFromFile(t *testing.T) {
|
|||
func TestValidate(t *testing.T) {
|
||||
const defaultErrCount = 33 // expect this number of error messages by default because user-specific values are not set and multiple providers are defined by default
|
||||
const azErrCount = 7
|
||||
const awsErrCount = 6
|
||||
const gcpErrCount = 6
|
||||
|
||||
// TODO(AB#3132,3u13r): refactor config validation tests
|
||||
|
@ -346,7 +347,37 @@ func TestValidate(t *testing.T) {
|
|||
return cnf
|
||||
}(),
|
||||
},
|
||||
|
||||
"default AWS config is not valid": {
|
||||
cnf: func() *Config {
|
||||
cnf := Default()
|
||||
cnf.RemoveProviderAndAttestationExcept(cloudprovider.AWS)
|
||||
return cnf
|
||||
}(),
|
||||
wantErr: true,
|
||||
wantErrCount: awsErrCount,
|
||||
},
|
||||
"AWS config with correct region and zone format": {
|
||||
cnf: func() *Config {
|
||||
cnf := Default()
|
||||
cnf.Provider.AWS.Region = "us-east-2"
|
||||
cnf.Provider.AWS.Zone = "us-east-2a"
|
||||
cnf.RemoveProviderAndAttestationExcept(cloudprovider.AWS)
|
||||
return cnf
|
||||
}(),
|
||||
wantErr: true,
|
||||
wantErrCount: awsErrCount - 2,
|
||||
},
|
||||
"AWS config with wrong region and zone format": {
|
||||
cnf: func() *Config {
|
||||
cnf := Default()
|
||||
cnf.Provider.AWS.Region = "us-west2"
|
||||
cnf.Provider.AWS.Zone = "a"
|
||||
cnf.RemoveProviderAndAttestationExcept(cloudprovider.AWS)
|
||||
return cnf
|
||||
}(),
|
||||
wantErr: true,
|
||||
wantErrCount: awsErrCount,
|
||||
},
|
||||
"default GCP config is not valid": {
|
||||
cnf: func() *Config {
|
||||
cnf := Default()
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue