Git-Mirrors/constellation
1
0
Fork 0
mirror of https://github.com/edgelesssys/constellation.git synced 2025-05-04 07:15:05 -04:00
Code Issues Projects Releases Packages Wiki Activity

cli: remove ctx parameter from rollbackOnError to prevent wrong use

Browse source
This commit is contained in:
Thomas Tendyck 2023-03-19 16:05:01 +01:00 • committed by Thomas Tendyck
parent 4d618a4b99
commit 43fbb06426
3 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

4
cli/internal/cloudcmd/rollback.go
View file

@ -20,13 +20,13 @@ type rollbacker interface {
// rollbackOnError calls rollback on the rollbacker if the handed error is not nil,
// and writes logs to the writer w.
func rollbackOnError(ctx context.Context, w io.Writer, onErr *error, roll rollbacker) {
func rollbackOnError(w io.Writer, onErr *error, roll rollbacker) {
if *onErr == nil {
return
}
fmt.Fprintf(w, "An error occurred: %s\n", *onErr)
fmt.Fprintln(w, "Attempting to roll back.")
if err := roll.rollback(ctx); err != nil {
if err := roll.rollback(context.Background()); err != nil {
*onErr = errors.Join(*onErr, fmt.Errorf("on rollback: %w", err)) // TODO: print the error, or return it?
return
}