Git-Mirrors/constellation
1
0
Fork 0
mirror of https://github.com/edgelesssys/constellation.git synced 2025-08-14 01:35:34 -04:00
Code Issues Projects Releases Packages Wiki Activity

config: improve usage and meaning of validate (#1975)

Browse source 
* discuss miniup config.Default() usage + discourage usage for Default() in comment

* Update internal/config/config_test.go

Co-authored-by: Daniel Weiße <66256922+daniel-weisse@users.noreply.github.com>

* add enterprise version check for config.Default

* split config comment lines

* daniel feedback

* featureset.CanUseEmbeddedMeasurmentsAndImage

---------

Co-authored-by: Daniel Weiße <66256922+daniel-weisse@users.noreply.github.com>
This commit is contained in:
Adrian Stobbe 2023-06-28 10:28:48 +02:00 • committed by GitHub
parent 1edbe962c1
commit 161bb37cba
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 43 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

11
internal/config/config_test.go
View file

@ -376,6 +376,15 @@ func TestValidate(t *testing.T) {
return cnf
}(),
},
"miniup default config is not valid because image and measurements are missing in OSS": {
cnf: func() *Config {
config, _ := MiniDefault()
require.NotNil(t, config)
return config
}(),
wantErr: true,
wantErrCount: 2,
},
}
for name, tc := range testCases {
@ -389,7 +398,7 @@ func TestValidate(t *testing.T) {
assert.Error(err)
var valErr *ValidationError
require.ErrorAs(err, &valErr)
assert.Equal(tc.wantErrCount, valErr.messagesCount())
assert.Equalf(tc.wantErrCount, valErr.messagesCount(), "Got unexpected error count: %d: %s", valErr.messagesCount(), valErr.LongMessage())
return
}
assert.NoError(err)