AB#2159 Feat/cli/fetch measurements (#301)

Signed-off-by: Fabian Kammel <fk@edgeless.systems>
2025-05-04 23:35:11 -04:00 · 2022-08-01 09:37:05 +02:00 · 2022-08-01 09:37:05 +02:00 · 050e8fdc4a
commit 050e8fdc4a
parent 7baf98f014
16 changed files with 1430 additions and 496 deletions
--- a/cli/internal/cmd/configfetchmeasurements_test.go
+++ b/cli/internal/cmd/configfetchmeasurements_test.go
@ -0,0 +1,197 @@
+package cmd
+
+import (
+	"bytes"
+	"io/ioutil"
+	"net/http"
+	"net/url"
+	"testing"
+
+	"github.com/edgelesssys/constellation/internal/cloud/cloudprovider"
+	"github.com/edgelesssys/constellation/internal/config"
+	"github.com/edgelesssys/constellation/internal/constants"
+	"github.com/edgelesssys/constellation/internal/file"
+	"github.com/spf13/afero"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func urlMustParse(raw string) *url.URL {
+	parsed, _ := url.Parse(raw)
+	return parsed
+}
+
+func TestParseFetchMeasurementsFlags(t *testing.T) {
+	testCases := map[string]struct {
+		urlFlag          string
+		signatureURLFlag string
+		configFlag       string
+		wantFlags        *fetchMeasurementsFlags
+		wantErr          bool
+	}{
+		"default": {
+			wantFlags: &fetchMeasurementsFlags{
+				measurementsURL: nil,
+				signatureURL:    nil,
+				config:          constants.ConfigFilename,
+			},
+		},
+		"url": {
+			urlFlag:          "https://some.other.url/with/path",
+			signatureURLFlag: "https://some.other.url/with/path.sig",
+			wantFlags: &fetchMeasurementsFlags{
+				measurementsURL: urlMustParse("https://some.other.url/with/path"),
+				signatureURL:    urlMustParse("https://some.other.url/with/path.sig"),
+				config:          constants.ConfigFilename,
+			},
+		},
+		"broken url": {
+			urlFlag: "%notaurl%",
+			wantErr: true,
+		},
+		"config": {
+			configFlag: "someOtherConfig.yaml",
+			wantFlags: &fetchMeasurementsFlags{
+				config: "someOtherConfig.yaml",
+			},
+		},
+	}
+
+	for name, tc := range testCases {
+		t.Run(name, func(t *testing.T) {
+			assert := assert.New(t)
+			require := require.New(t)
+
+			cmd := newConfigFetchMeasurementsCmd()
+			cmd.Flags().String("config", constants.ConfigFilename, "") // register persisten flag manually
+
+			if tc.urlFlag != "" {
+				require.NoError(cmd.Flags().Set("url", tc.urlFlag))
+			}
+			if tc.signatureURLFlag != "" {
+				require.NoError(cmd.Flags().Set("signature-url", tc.signatureURLFlag))
+			}
+			if tc.configFlag != "" {
+				require.NoError(cmd.Flags().Set("config", tc.configFlag))
+			}
+
+			flags, err := parseFetchMeasurementsFlags(cmd)
+			if tc.wantErr {
+				assert.Error(err)
+				return
+			}
+			require.NoError(err)
+			assert.Equal(tc.wantFlags, flags)
+		})
+	}
+}
+
+func TestUpdateURLs(t *testing.T) {
+	testCases := map[string]struct {
+		conf                   *config.Config
+		flags                  *fetchMeasurementsFlags
+		wantMeasurementsURL    string
+		wantMeasurementsSigURL string
+	}{
+		"both values nil": {
+			conf: &config.Config{
+				Provider: config.ProviderConfig{
+					GCP: &config.GCPConfig{
+						Image: "some/image/path/image-123456",
+					},
+				},
+			},
+			flags:                  &fetchMeasurementsFlags{},
+			wantMeasurementsURL:    constants.S3PublicBucket + "some/image/path/image-123456/measurements.yaml",
+			wantMeasurementsSigURL: constants.S3PublicBucket + "some/image/path/image-123456/measurements.yaml.sig",
+		},
+		"both set by user": {
+			conf: &config.Config{},
+			flags: &fetchMeasurementsFlags{
+				measurementsURL: urlMustParse("get.my/measurements.yaml"),
+				signatureURL:    urlMustParse("get.my/measurements.yaml.sig"),
+			},
+			wantMeasurementsURL:    "get.my/measurements.yaml",
+			wantMeasurementsSigURL: "get.my/measurements.yaml.sig",
+		},
+	}
+
+	for name, tc := range testCases {
+		t.Run(name, func(t *testing.T) {
+			assert := assert.New(t)
+
+			err := tc.flags.updateURLs(tc.conf)
+			assert.NoError(err)
+			assert.Equal(tc.wantMeasurementsURL, tc.flags.measurementsURL.String())
+		})
+	}
+}
+
+// roundTripFunc .
+type roundTripFunc func(req *http.Request) *http.Response
+
+// RoundTrip .
+func (f roundTripFunc) RoundTrip(req *http.Request) (*http.Response, error) {
+	return f(req), nil
+}
+
+// newTestClient returns *http.Client with Transport replaced to avoid making real calls.
+func newTestClient(fn roundTripFunc) *http.Client {
+	return &http.Client{
+		Transport: fn,
+	}
+}
+
+func TestConfigFetchMeasurements(t *testing.T) {
+	assert := assert.New(t)
+	require := require.New(t)
+
+	measurements := `0: DzXCFGCNk8em5ornNZtKi+Wg6Z7qkQfs5CfE3qTkOc8=
+1: PpZwsXLISi+uelbloy9u3m9M+X0/Br11g5cqq370Kxc=
+2: PUWM/lXMA+ofRD8VYr7sjfUcdeFKn8+acjShPxmOeWk=
+3: PUWM/lXMA+ofRD8VYr7sjfUcdeFKn8+acjShPxmOeWk=
+4: C5/4ItGHR986BeUS7VNGD/wLltkAEOmw3sek9wA/QQs=
+5: ZykPWLTRtSn5ImX6ZpHW7JpvwqN9M9L170FtEQl3PYg=
+6: PUWM/lXMA+ofRD8VYr7sjfUcdeFKn8+acjShPxmOeWk=
+7: UZcW+fhFRMpFkgU+EfKG2s3KdmgEA+TD2quLmthQHbo=
+8: h4oDFRNoG+e3iig9KmrRZQUNfeCPpk2eqH3ZTpUikmw=
+9: vODgwZQa0pm/my1oXAQWHv1ozwzMYGELX2eO44MoUlA=
+10: TyOf7DchF2qkAYUBSZLQobvbsTx3GjYGKELTfAc2vRw=
+`
+	signature := "MEUCIBQYbeZMYNPFTaD80fcjlm75eiwxxQ6xu0JM/H2Ha7dJAiEA1WVdnpX+NbsJLzc2lrvUQFztfaWoDA8A39pHsu1MG6c="
+
+	cmd := newConfigFetchMeasurementsCmd()
+	cmd.Flags().String("config", constants.ConfigFilename, "") // register persisten flag manually
+	fileHandler := file.NewHandler(afero.NewMemMapFs())
+
+	gcpConfig := config.Default()
+	gcpConfig.RemoveProviderExcept(cloudprovider.GCP)
+	gcpConfig.Provider.GCP.Image = "projects/constellation-images/global/images/constellation-coreos-1658216163"
+
+	err := fileHandler.WriteYAML(constants.ConfigFilename, gcpConfig, file.OptMkdirAll)
+	require.NoError(err)
+
+	client := newTestClient(func(req *http.Request) *http.Response {
+		if req.URL.String() == "https://public-edgeless-constellation.s3.us-east-2.amazonaws.com/projects/constellation-images/global/images/constellation-coreos-1658216163/measurements.yaml" {
+			return &http.Response{
+				StatusCode: http.StatusOK,
+				Body:       ioutil.NopCloser(bytes.NewBufferString(measurements)),
+				Header:     make(http.Header),
+			}
+		}
+		if req.URL.String() == "https://public-edgeless-constellation.s3.us-east-2.amazonaws.com/projects/constellation-images/global/images/constellation-coreos-1658216163/measurements.yaml.sig" {
+			return &http.Response{
+				StatusCode: http.StatusOK,
+				Body:       ioutil.NopCloser(bytes.NewBufferString(signature)),
+				Header:     make(http.Header),
+			}
+		}
+		return &http.Response{
+			StatusCode: http.StatusNotFound,
+			Body:       ioutil.NopCloser(bytes.NewBufferString("Not found.")),
+			Header:     make(http.Header),
+		}
+	})
+
+	assert.NoError(configFetchMeasurements(cmd, fileHandler, client))
+}