Add helm's quote function to various fields

The constellationUID is sometimes interpreted as integer if it contains
0e, as the yaml parsing interprets that as scientific notation.
Since it is a best practices to quote string fields anyways this patch
also quotes other fields where an actual string is required.
This commit is contained in:
Otto Bittner 2022-11-25 10:01:41 +01:00
parent 64f03cf675
commit 038ea5fade
30 changed files with 53 additions and 56 deletions

View file

@ -56,10 +56,10 @@ spec:
- name: KUBERNETES_CLUSTER_DOMAIN
value: {{ .Values.kubernetesClusterDomain }}
- name: CONSTEL_CSP
value: {{ .Values.csp }}
value: {{ .Values.csp | quote }}
- name: constellation-uid
value: {{ .Values.constellationUID }}
image: {{ .Values.controllerManager.manager.image }}
value: {{ .Values.constellationUID | quote }}
image: {{ .Values.controllerManager.manager.image | quote }}
livenessProbe:
httpGet:
path: /healthz

View file

@ -13,12 +13,9 @@ data:
| quote }}
kind: ControllerManagerConfig
leaderElection:
leaderElect: {{ .Values.managerConfig.controllerManagerConfigYaml.leaderElection.leaderElect
}}
resourceName: {{ .Values.managerConfig.controllerManagerConfigYaml.leaderElection.resourceName
| quote }}
leaderElect: {{ .Values.managerConfig.controllerManagerConfigYaml.leaderElection.leaderElect }}
resourceName: {{ .Values.managerConfig.controllerManagerConfigYaml.leaderElection.resourceName | quote }}
metrics:
bindAddress: {{ .Values.managerConfig.controllerManagerConfigYaml.metrics.bindAddress
| quote }}
bindAddress: {{ .Values.managerConfig.controllerManagerConfigYaml.metrics.bindAddress | quote }}
webhook:
port: {{ .Values.managerConfig.controllerManagerConfigYaml.webhook.port }}

View file

@ -55,8 +55,8 @@ spec:
fieldRef:
fieldPath: metadata.namespace
- name: KUBERNETES_CLUSTER_DOMAIN
value: {{ .Values.kubernetesClusterDomain }}
image: {{ .Values.controllerManager.manager.image }}
value: {{ .Values.kubernetesClusterDomain | quote }}
image: {{ .Values.controllerManager.manager.image | quote }}
livenessProbe:
httpGet:
path: /healthz
@ -74,8 +74,7 @@ spec:
port: 8081
initialDelaySeconds: 5
periodSeconds: 10
resources: {{- toYaml .Values.controllerManager.manager.resources | nindent 10
}}
resources: {{- toYaml .Values.controllerManager.manager.resources | nindent 10 }}
securityContext:
allowPrivilegeEscalation: false
volumeMounts:

View file

@ -8,7 +8,7 @@ metadata:
node-maintenance-operator: ""
{{- include "chart.labels" . | nindent 4 }}
spec:
type: {{ .Values.metricsService.type }}
type: {{ .Values.metricsService.type | quote }}
selector:
control-plane: controller-manager
node-maintenance-operator: ""

View file

@ -8,8 +8,7 @@ metadata:
spec:
dnsNames:
- 'node-maintenance-operator-webhook-service.{{ .Release.Namespace }}.svc'
- 'node-maintenance-operator-webhook-service.{{ .Release.Namespace }}.svc.{{
.Values.kubernetesClusterDomain }}'
- 'node-maintenance-operator-webhook-service.{{ .Release.Namespace }}.svc.{{ .Values.kubernetesClusterDomain }}'
issuerRef:
kind: Issuer
name: node-maintenance-operator-selfsigned-issuer

View file

@ -7,7 +7,7 @@ metadata:
node-maintenance-operator: ""
{{- include "chart.labels" . | nindent 4 }}
spec:
type: {{ .Values.webhookService.type }}
type: {{ .Values.webhookService.type | quote }}
selector:
control-plane: controller-manager
node-maintenance-operator: ""