From fdc84fb8487b54b3e84868073c78653ad6cd3189 Mon Sep 17 00:00:00 2001 From: Vangelis Banos Date: Tue, 18 Jan 2022 10:09:39 +0000 Subject: [PATCH] Add chrome options --disable-sync and --disable-breakpad `--disable-sync` disables syncing to a Google account. `--disable-breakpad` disables crashdump collection. These options aren't useful for Brozzler. They are already used in puppeteer https://github.com/puppeteer/puppeteer/blob/main/src/node/Launcher.ts#L211 Docs in chrome-launcher https://github.com/GoogleChrome/chrome-launcher/blob/master/docs/chrome-flags-for-tools.md --- brozzler/chrome.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/brozzler/chrome.py b/brozzler/chrome.py index fb7c33f..f908da2 100644 --- a/brozzler/chrome.py +++ b/brozzler/chrome.py @@ -168,7 +168,7 @@ class Chrome: '--remote-debugging-port=%s' % self.port, '--use-mock-keychain', # mac thing '--user-data-dir=%s' % self._chrome_user_data_dir, - '--disable-background-networking', + '--disable-background-networking', '--disable-breakpad', '--disable-renderer-backgrounding', '--disable-hang-monitor', '--disable-background-timer-throttling', '--mute-audio', '--disable-web-sockets', @@ -176,7 +176,8 @@ class Chrome: '--disable-first-run-ui', '--no-first-run', '--homepage=about:blank', '--disable-direct-npapi-requests', '--disable-web-security', '--disable-notifications', - '--disable-extensions', '--disable-save-password-bubble'] + '--disable-extensions', '--disable-save-password-bubble', + '--disable-sync'] extra_chrome_args = os.environ.get('BROZZLER_EXTRA_CHROME_ARGS') if extra_chrome_args: