Git-Mirrors/brozzler
1
0
Fork 0
mirror of https://github.com/internetarchive/brozzler.git synced 2025-08-08 22:42:32 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

remove unused param to __init__, avoid exception when on_request callback not provided

Browse source
This commit is contained in:
Noah Levitt 2014-05-20 17:07:42 -07:00
parent 99d219dfda
commit d4693b2aba
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
umbra/browser.py
View file

@ -24,13 +24,12 @@ class Browser:
HARD_TIMEOUT_SECONDS = 20 * 60 HARD_TIMEOUT_SECONDS = 20 * 60
def __init__(self, chrome_port=9222, chrome_exe='chromium-browser', chrome_wait=60, client_id='request'): def __init__(self, chrome_port=9222, chrome_exe='chromium-browser', chrome_wait=60):
self.command_id = itertools.count(1) self.command_id = itertools.count(1)
self._lock = threading.Lock() self._lock = threading.Lock()
self.chrome_port = chrome_port self.chrome_port = chrome_port
self.chrome_exe = chrome_exe self.chrome_exe = chrome_exe
self.chrome_wait = chrome_wait self.chrome_wait = chrome_wait
self.client_id = client_id
self._behavior = None self._behavior = None
self.websock = None self.websock = None
@ -99,7 +98,7 @@ class Browser:
self._behavior.notify_of_activity() self._behavior.notify_of_activity()
if message["params"]["request"]["url"].lower().startswith("data:"): if message["params"]["request"]["url"].lower().startswith("data:"):
self.logger.debug("ignoring data url {}".format(message["params"]["request"]["url"][:80])) self.logger.debug("ignoring data url {}".format(message["params"]["request"]["url"][:80]))
else: elif self.on_request:
self.on_request(message) self.on_request(message)
elif "method" in message and message["method"] == "Page.loadEventFired": elif "method" in message and message["method"] == "Page.loadEventFired":
if self._behavior is None: if self._behavior is None: