From cc0855487896359e306873d7ec941822cd7b3f25 Mon Sep 17 00:00:00 2001 From: Barbara Miller Date: Thu, 20 Sep 2018 15:30:12 -0700 Subject: [PATCH] Browsing Exception for Page.interstitialShown --- brozzler/browser.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/brozzler/browser.py b/brozzler/browser.py index a7d39d1..ef7885e 100644 --- a/brozzler/browser.py +++ b/brozzler/browser.py @@ -241,10 +241,11 @@ class WebsockReceiverThread(threading.Thread): if self.on_request: self.on_request(message) elif message['method'] == 'Page.interstitialShown': - # for AITFIVE-1529: handle http auth - # for now, we should consider killing the browser when we receive Page.interstitialShown and - # consider the page finished—-first we should figure out when else that event might happen - self.logger.info('Page.interstitialShown received') + # AITFIVE-1529: handle http auth + # we should kill the browser when we receive Page.interstitialShown and + # consider the page finished, until this is fixed: https://bugs.chromium.org/p/chromium/issues/detail?id=764505 + self.logger.info('Page.interstitialShown received: likely http auth request, currently unsupported') + brozzler.thread_raise(self.calling_thread, BrowsingException) elif message['method'] == 'Inspector.targetCrashed': self.logger.error( '''chrome tab went "aw snap" or "he's dead jim"!''')