Git-Mirrors/brozzler
1
0
Fork 0
mirror of https://github.com/internetarchive/brozzler.git synced 2025-04-21 16:16:28 -04:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Browser.configure_browser optimisation

Browse Source 
We use `Network.setExtraHTTPHeaders` and then we use `self._wait_for` to wait
for the result.
This is redundant as we don't do anything with the result, we shouldn't
wait here.

Also, in the same method we use `Network.setUserAgentOverride` and we
don't wait for that. I'm saying this to indicate that waiting isn't
necessary after setting browser options like these.
This commit is contained in:
Vangelis Banos 2018-02-15 23:09:23 +00:00
parent 0d605d0a88
commit c98a39d343
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
brozzler/browser.py
View File

@ -520,15 +520,11 @@ class Browser:
def configure_browser(self, extra_headers=None, user_agent=None):
headers = extra_headers or {}
headers['Accept-Encoding'] = 'gzip' # avoid encodings br, sdch
self.websock_thread.expect_result(self._command_id.peek())
msg_id = self.send_to_chrome(
self.send_to_chrome(
method='Network.setExtraHTTPHeaders',
params={'headers': headers})
self._wait_for(
lambda: self.websock_thread.received_result(msg_id),
timeout=10)
if user_agent:
msg_id = self.send_to_chrome(
self.send_to_chrome(
method='Network.setUserAgentOverride',
params={'userAgent': user_agent})