From c886b57d3a8f8400a524abd9af10d132a38ad137 Mon Sep 17 00:00:00 2001 From: Noah Levitt Date: Tue, 19 Aug 2014 18:51:43 -0700 Subject: [PATCH] reject (discard) bad messages --- umbra/controller.py | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/umbra/controller.py b/umbra/controller.py index f22fc69..7a74155 100644 --- a/umbra/controller.py +++ b/umbra/controller.py @@ -98,7 +98,17 @@ class AmqpBrowserController: browser.start() def callback(body, message): - self._start_browsing_page(browser, message, body['clientId'], body['url'], body['metadata']) + try: + client_id, url, metadata = body['clientId'], body['url'], body['metadata'] + except: + self.logger.error("unable to decipher message {}".format(message), exc_info=True) + self.logger.error("discarding bad message") + message.reject() + browser.stop() + self._browser_pool.release(browser) + return + self._start_browsing_page(browser, message, client_id, url, metadata) + consumer.callbacks = [callback] while True: