Git-Mirrors/brozzler
1
0
Fork 0
mirror of https://github.com/internetarchive/brozzler.git synced 2025-06-20 04:44:12 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

dump stack trace and don't return browser to pool on critical error where chrome process might still be running

Browse source
This commit is contained in:
Noah Levitt 2014-05-30 23:07:39 -07:00
parent ed92f3bd53
commit 56a721f059
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
umbra/controller.py
View file

@ -138,8 +138,9 @@ class AmqpBrowserController:
self.logger.info('browser={} client_id={} url={}'.format(browser, client_id, url)) self.logger.info('browser={} client_id={} url={}'.format(browser, client_id, url))
try: try:
browser.browse_page(url, on_request=on_request) browser.browse_page(url, on_request=on_request)
finally:
self._browser_pool.release(browser) self._browser_pool.release(browser)
except:
self.logger.critical("problem browsing page, may have lost browser process", exc_info=True)
import random import random
threadName = "BrowsingThread{}-{}".format(browser.chrome_port, threadName = "BrowsingThread{}-{}".format(browser.chrome_port,