Git-Mirrors/brozzler
1
0
Fork 0
mirror of https://github.com/internetarchive/brozzler.git synced 2025-08-14 09:15:54 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

tidier, better exception handling?

Browse source
This commit is contained in:
Barbara Miller 2018-09-21 17:46:19 -07:00
parent 51d011c285
commit 156ec0caa1
3 changed files with 8 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

10
brozzler/browser.py
View file

@ -243,12 +243,10 @@ class WebsockReceiverThread(threading.Thread):
elif message['method'] == 'Page.interstitialShown':
# AITFIVE-1529: handle http auth
# we should kill the browser when we receive Page.interstitialShown and
# consider the page finished, until this is fixed: https://bugs.chromium.org/p/chromium/issues/detail?id=764505
self.page_interstitial_shown = brozzler.PageInterstitialShown(
warcprox_meta=None)
self.logger.info('Page.interstialShown (likely http auth request) %s', self.page_interstitial_shown)
brozzler.thread_raise(
self.calling_thread, brozzler.PageInterstitialShown)
# consider the page finished, until this is fixed:
# https://bugs.chromium.org/p/chromium/issues/detail?id=764505
self.logger.info('Page.interstialShown (likely unsupported http auth request)')
brozzler.thread_raise(self.calling_thread, brozzler.PageInterstitialShown)
elif message['method'] == 'Inspector.targetCrashed':
self.logger.error(
'''chrome tab went "aw snap" or "he's dead jim"!''')