Git-Mirrors/brozzler
1
0
Fork 0
mirror of https://github.com/internetarchive/brozzler.git synced 2025-04-21 08:06:27 -04:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Browsing Exception for Page.interstitialShown

Browse Source
This commit is contained in:
Barbara Miller 2018-09-20 15:30:12 -07:00
parent 48bf185746
commit 0e867102a9
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
brozzler/browser.py
View File

@ -241,10 +241,11 @@ class WebsockReceiverThread(threading.Thread):
if self.on_request:
self.on_request(message)
elif message['method'] == 'Page.interstitialShown':
# for AITFIVE-1529: handle http auth
# for now, we should consider killing the browser when we receive Page.interstitialShown and
# consider the page finished—-first we should figure out when else that event might happen
self.logger.info('Page.interstitialShown received')
# AITFIVE-1529: handle http auth
# we should kill the browser when we receive Page.interstitialShown and
# consider the page finished, until this is fixed: https://bugs.chromium.org/p/chromium/issues/detail?id=764505
self.logger.info('Page.interstitialShown received: likely http auth request, currently unsupported')
brozzler.thread_raise(self.calling_thread, BrowsingException)
elif message['method'] == 'Inspector.targetCrashed':
self.logger.error(
'''chrome tab went "aw snap" or "he's dead jim"!''')