Git-Mirrors/brozzler
1
0
Fork 0
mirror of https://github.com/internetarchive/brozzler.git synced 2025-04-19 15:25:59 -04:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #145 from galgeek/no-skipIframes

Browse Source 
no skipIframes for umbraBehavior
This commit is contained in:
Noah Levitt 2018-12-20 11:30:28 -08:00 committed by GitHub
commit 0a08c01461
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
brozzler/behaviors.yaml
View File

@ -25,8 +25,6 @@
url_regex: '^https?://(?:www\.)?instagram\.com/.*$'
behavior_js_template: umbraBehavior.js.j2
default_parameters:
interval: 500
skip_iframes: true
actions:
- selector: button.coreSpriteDismissLarge
- selector: 'a>.eLAPa>.KL4Bh'

25
brozzler/js-templates/umbraBehavior.js.j2
View File

@ -26,11 +26,6 @@ class UmbraBehavior {
this.idleSince = null;
this.intervalId = null;
this.intervalTimeMs = {{interval or 300}};
{% if skip_iframes %}
this.skipIframes = true;
{% else %}
this.skipIframes = false;
{% endif %}
this.index = 0;
}
@ -48,17 +43,15 @@ class UmbraBehavior {
var documents = [];
documents[0] = document;
if (!(this.skipIframes)) {
var iframes = document.querySelectorAll("iframe");
var iframesLength = iframes.length;
for (var i = 0; i < iframesLength; i++) {
try {
documents.push(iframes[i].contentWindow.document);
} catch (e) {
// it'd be too much logging because this is common:
// SecurityError: Blocked a frame with origin "..." from accessing a cross-origin frame
// console.log("exception looking at iframe" + iframes[i] + ": " + e);
}
var iframes = document.querySelectorAll("iframe");
var iframesLength = iframes.length;
for (var i = 0; i < iframesLength; i++) {
try {
documents.push(iframes[i].contentWindow.document);
} catch (e) {
// it'd be too much logging because this is common:
// SecurityError: Blocked a frame with origin "..." from accessing a cross-origin frame
// console.log("exception looking at iframe" + iframes[i] + ": " + e);
}
}
var documentsLength = documents.length;