Merge pull request #77 from vbanos/chrome-stop-del-tmpdir

Fix to delete tmpdir on Chrome.stop()
This commit is contained in:
Noah Levitt 2018-01-15 10:36:50 -08:00 committed by GitHub
commit 016bd5d3f7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -278,13 +278,13 @@ class Chrome:
'chrome pid %s reaped (status=%s) after killing with ' 'chrome pid %s reaped (status=%s) after killing with '
'SIGKILL', self.chrome_process.pid, status) 'SIGKILL', self.chrome_process.pid, status)
finally:
try: try:
self._home_tmpdir.cleanup() self._home_tmpdir.cleanup()
except: except:
self.logger.error( self.logger.error(
'exception deleting %s', self._home_tmpdir, 'exception deleting %s', self._home_tmpdir,
exc_info=True) exc_info=True)
finally:
self._out_reader_thread.join() self._out_reader_thread.join()
self.chrome_process = None self.chrome_process = None