From 99659ac9cefd7cf44e573c010e79a80ad4c77810 Mon Sep 17 00:00:00 2001
From: bt3gl <1130416+bt3gl@users.noreply.github.com>
Date: Fri, 23 Sep 2022 07:47:56 -0700
Subject: [PATCH] =?UTF-8?q?=F0=9F=8C=AD=20security=20tips?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../random-notes.md                            | 18 ------------------
 .../security_tips.md                           | 13 +++++++++++++
 2 files changed, 13 insertions(+), 18 deletions(-)
 delete mode 100644 smart_contracts_vulnerabilities/random-notes.md
 create mode 100644 smart_contracts_vulnerabilities/security_tips.md

diff --git a/smart_contracts_vulnerabilities/random-notes.md b/smart_contracts_vulnerabilities/random-notes.md
deleted file mode 100644
index c979b0e..0000000
--- a/smart_contracts_vulnerabilities/random-notes.md
+++ /dev/null
@@ -1,18 +0,0 @@
-## Random security notes
-
-<br>
-
-* `tx.origin` is used: you want to replace it by “msg.sender” because otherwise any contract you call can act on your behalf.
-* Avoid potential reetrancy bugs: 
-```
-msg.sender.transfer(amount);
-balances[msg.sender] -= amount;
-```
-* Inline assembly should be used only in rare cases.
-* Unclear semantics: `now` is alias for `block.timestamp` not current time; use of low level `call`, `callcode`, `delegatecall` should be avoided whenever possible; use `transfer` whenever failure of ether transfer should rollnack the whole transaction.
-* Beware of caller contracts: `selfdestruct` can block calling contracts unexpectedly.
-* Invocation of local functions via `this`: never use `this` to call functions in the same contract, it only consumes more gas than normal call.
-* Transferring Ether in a for/while/do-while loop should be avoid due to the block gas limit.
-* ERC20 `decimals` should have `uint8` as return type.
-
-<br>
diff --git a/smart_contracts_vulnerabilities/security_tips.md b/smart_contracts_vulnerabilities/security_tips.md
new file mode 100644
index 0000000..8efa20b
--- /dev/null
+++ b/smart_contracts_vulnerabilities/security_tips.md
@@ -0,0 +1,13 @@
+## 🌭 security tips
+
+<br>
+
+* `tx.origin` needs to bere placed by `msg.sender`, otherwise any contract you call can act on your behalf.
+* inline assembly should be used only in rare cases.
+* unclear semantics: `now` is alias for `block.timestamp` not current time; use of low level `call`, `callcode`, `delegatecall` should be avoided whenever possible; use `transfer` whenever failure of ether transfer should rollnack the whole transaction.
+* beware of caller contracts: `selfdestruct` can block calling contracts unexpectedly.
+* invocation of local functions via `this`: never use `this` to call functions in the same contract, it only consumes more gas than normal call.
+* transferring Ether in a for/while/do-while loop should be avoid due to the block gas limit.
+* erc20 `decimals` should have `uint8` as return type.
+
+<br>