/libretroshare/src/rsitems/rspluginitems.h:39: warning:
Cppcheck(noExplicitConstructor): Class 'RsPluginItem' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:117: warning:
Cppcheck(uninitMemberVar): Member variable
'RsNxsSyncGrpStatsItem::request_type' is not initialized in the
constructor.
/libretroshare/src/rsitems/rsnxsitems.h:117: warning:
Cppcheck(uninitMemberVar): Member variable
'RsNxsSyncGrpStatsItem::number_of_posts' is not initialized in the
constructor.
/libretroshare/src/rsitems/rsnxsitems.h:117: warning:
Cppcheck(uninitMemberVar): Member variable
'RsNxsSyncGrpStatsItem::last_post_TS' is not initialized in the
constructor.
/libretroshare/src/rsitems/rsnxsitems.h:371: warning:
Cppcheck(uninitMemberVar): Member variable 'RsNxsMsg::pos' is not
initialized in the constructor.
/libretroshare/src/rsitems/rsnxsitems.h:371: warning:
Cppcheck(uninitMemberVar): Member variable 'RsNxsMsg::count' is not
initialized in the constructor.
/libretroshare/src/rsitems/rsnxsitems.h:410: warning:
Cppcheck(uninitMemberVar): Member variable 'RsNxsSearchReqItem::nHops'
is not initialized in the constructor.
/libretroshare/src/rsitems/rsnxsitems.h:410: warning:
Cppcheck(uninitMemberVar): Member variable 'RsNxsSearchReqItem::token'
is not initialized in the constructor.
/libretroshare/src/rsitems/rsnxsitems.h:410: warning:
Cppcheck(uninitMemberVar): Member variable
'RsNxsSearchReqItem::expiration' is not initialized in the constructor.
/libretroshare/src/rsitems/rsnxsitems.h:431: warning:
Cppcheck(uninitMemberVar): Member variable
'RsNxsSearchResultMsgItem::token' is not initialized in the constructor.
/libretroshare/src/rsitems/rsnxsitems.h:431: warning:
Cppcheck(uninitMemberVar): Member variable
'RsNxsSearchResultMsgItem::expiration' is not initialized in the
constructor.
/libretroshare/src/rsitems/rsnxsitems.h:99: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSyncGrpReqItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:117: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSyncGrpStatsItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:140: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsGroupPublishKeyItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:183: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsTransacItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:211: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSyncGrpItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:257: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsEncryptedDataItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:283: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsGrp' has a constructor with
1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:327: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSyncMsgReqItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:351: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSyncMsgItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:371: warning:
Cppcheck(noExplicitConstructor): Struct 'RsNxsMsg' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:410: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSearchReqItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:500: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSerialiser' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:237: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSessionKeyItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsrttitems.h:56: warning:
Cppcheck(uninitMemberVar): Member variable 'RsRttPingItem::mSeqNo' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsrttitems.h:56: warning:
Cppcheck(uninitMemberVar): Member variable 'RsRttPingItem::mPingTS' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsrttitems.h:70: warning:
Cppcheck(uninitMemberVar): Member variable 'RsRttPongItem::mSeqNo' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsrttitems.h:70: warning:
Cppcheck(uninitMemberVar): Member variable 'RsRttPongItem::mPingTS' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsrttitems.h:70: warning:
Cppcheck(uninitMemberVar): Member variable 'RsRttPongItem::mPongTS' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsrttitems.h:46: warning:
Cppcheck(noExplicitConstructor): Class 'RsRttItem' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsitem.h:15: warning:
Cppcheck(noExplicitConstructor): Class 'RsItem' has a constructor with 1
argument that is not explicit.
/libretroshare/src/rsitems/rsgxsrecognitems.h:56: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsRecognReqItem::issued_at' is not initialized in the constructor.
/libretroshare/src/rsitems/rsgxsrecognitems.h:56: warning:
Cppcheck(uninitMemberVar): Member variable 'RsGxsRecognReqItem::period'
is not initialized in the constructor.
/libretroshare/src/rsitems/rsgxsrecognitems.h:56: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsRecognReqItem::tag_class' is not initialized in the constructor.
/libretroshare/src/rsitems/rsgxsrecognitems.h:56: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsRecognReqItem::tag_type' is not initialized in the constructor.
/libretroshare/src/rsitems/rsgxsrecognitems.h:82: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsRecognTagItem::valid_from' is not initialized in the constructor.
/libretroshare/src/rsitems/rsgxsrecognitems.h:82: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsRecognTagItem::valid_to' is not initialized in the constructor.
/libretroshare/src/rsitems/rsgxsrecognitems.h:82: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsRecognTagItem::tag_class' is not initialized in the constructor.
/libretroshare/src/rsitems/rsgxsrecognitems.h:82: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsRecognTagItem::tag_type' is not initialized in the constructor.
/libretroshare/src/rsitems/rsgxsupdateitems.h:88: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsGrpConfigItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsgxsupdateitems.h:109: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsGrpUpdateItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsgxsupdateitems.h:131: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsServerGrpUpdateItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsgxsupdateitems.h:157: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsMsgUpdateItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsgxsupdateitems.h:179: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsServerMsgUpdateItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsgxsupdateitems.h:194: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsUpdateSerialiser' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsconfigitems.h:74: warning:
Cppcheck(uninitMemberVar): Member variable 'RsPeerNetItem::netMode' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsconfigitems.h:74: warning:
Cppcheck(uninitMemberVar): Member variable 'RsPeerNetItem::vs_disc' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsconfigitems.h:74: warning:
Cppcheck(uninitMemberVar): Member variable 'RsPeerNetItem::vs_dht' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsconfigitems.h:74: warning:
Cppcheck(uninitMemberVar): Member variable 'RsPeerNetItem::lastContact'
is not initialized in the constructor.
/libretroshare/src/rsitems/rsconfigitems.h:74: warning:
Cppcheck(uninitMemberVar): Member variable 'RsPeerNetItem::domain_port'
is not initialized in the constructor.
/libretroshare/src/rsitems/rsconfigitems.h:146: warning:
Cppcheck(uninitMemberVar): Member variable 'RsNodeGroupItem::flag' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsconfigitems.h:243: warning:
Cppcheck(uninitMemberVar): Member variable 'RsFileConfigItem::flags' is
not initialized in the constructor.
/libretroshare/src/retroshare/rswire.h:111: warning:
Cppcheck(noExplicitConstructor): Class 'RsWire' has a constructor with 1
argument that is not explicit.
/libretroshare/src/retroshare/rsservicecontrol.h:46: warning:
Cppcheck(passedByValue): Function parameter 'service_name' should be
passed by reference.
/libretroshare/src/retroshare/rsposted.h:81: warning:
Cppcheck(noExplicitConstructor): Class 'RsPosted' has a constructor with
1 argument that is not explicit.
/libretroshare/src/retroshare/rsidentity.h:269: warning:
Cppcheck(noExplicitConstructor): Class 'RsIdentity' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/retroshare/rsgxsforums.h:66: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsForums' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/retroshare/rsphoto.h:162: warning:
Cppcheck(noExplicitConstructor): Class 'RsPhotoComment' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/retroshare/rsgxschannels.h:82: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsChannels' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/pqi/pqiqos.h:62: warning: Cppcheck(uninitMemberVar):
Member variable 'ItemQueue::_threshold' is not initialized in the
constructor.
/libretroshare/src/pqi/pqiqos.h:62: warning: Cppcheck(uninitMemberVar):
Member variable 'ItemQueue::_counter' is not initialized in the
constructor.
/libretroshare/src/pqi/pqiqos.h:62: warning: Cppcheck(uninitMemberVar):
Member variable 'ItemQueue::_inc' is not initialized in the constructor.
/libretroshare/src/pqi/pqiindic.h:39: warning:
Cppcheck(noExplicitConstructor): Class 'Indicator' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/pqi/pqi_base.h:195: warning:
Cppcheck(noExplicitConstructor): Class 'PQInterface' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/pqi/p3servicecontrol.cc:840: warning:
Cppcheck(unreadVariable): Variable 'changes' is assigned a value that is
never used.
/libretroshare/src/pqi/p3servicecontrol.cc:941: warning:
Cppcheck(unusedVariable): Unused variable: mit
/libretroshare/src/pqi/p3servicecontrol.cc:972: warning:
Cppcheck(unusedVariable): Unused variable: mit
/libretroshare/src/pqi/p3servicecontrol.cc:88: warning:
Cppcheck(uninitMemberVar): Member variable
'p3ServiceControl::mServiceServer' is not initialized in the
constructor.
/libretroshare/src/pqi/p3servicecontrol.h:69: warning:
Cppcheck(noExplicitConstructor): Class 'p3ServiceControl' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/pqi/p3servicecontrol.cc:45: warning:
Cppcheck(noExplicitConstructor): Class 'RsServiceControlItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/pqi/p3servicecontrol.cc:52: warning:
Cppcheck(noExplicitConstructor): Class 'RsServicePermissionItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/pqi/p3servicecontrol.cc:359: warning:
Cppcheck(passedByValue): Function parameter 'serviceName' should be
passed by reference.
/libretroshare/src/pqi/p3netmgr.cc:926: warning:
Cppcheck(unreadVariable): Variable 'title' is assigned a value that is
never used.
/libretroshare/src/pqi/p3netmgr.cc:1808: warning:
Cppcheck(unreadVariable): Variable 'connectstr' is assigned a value that
is never used.
/libretroshare/src/pqi/p3historymgr.cc:353: warning:
Cppcheck(invalidScanfArgType_int): %d in format string (no. 1) requires
'int *' but the argument type is 'unsigned int *'.
/libretroshare/src/pqi/p3cfgmgr.h:154: warning:
Cppcheck(noExplicitConstructor): Class 'p3ConfigMgr' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/pqi/authssl.cc:857: warning:
Cppcheck(redundantAssignment): Variable 'buf_in' is reassigned a value
before the old one has been used.
/libretroshare/src/pqi/authssl.cc:864: warning:
Cppcheck(redundantAssignment): Variable 'buf_hashout' is reassigned a
value before the old one has been used.
/libretroshare/src/pqi/authssl.cc:867: warning:
Cppcheck(redundantAssignment): Variable 'buf_sigout' is reassigned a
value before the old one has been used.
/libretroshare/src/pqi/authssl.cc:1006: warning:
Cppcheck(redundantAssignment): Variable 'buf_in' is reassigned a value
before the old one has been used.
/libretroshare/src/pqi/authssl.cc:1013: warning:
Cppcheck(redundantAssignment): Variable 'buf_hashout' is reassigned a
value before the old one has been used.
/libretroshare/src/pqi/authssl.cc:1016: warning:
Cppcheck(redundantAssignment): Variable 'buf_sigout' is reassigned a
value before the old one has been used.
/libretroshare/src/pqi/authssl.cc:1451: warning:
Cppcheck(redundantAssignment): Variable 'ek' is reassigned a value
before the old one has been used.
/libretroshare/src/pqi/authssl.cc:366: warning:
Cppcheck(unreadVariable): Variable 'dh_prime_2048_hex' is assigned a
value that is never used.
/libretroshare/src/pqi/authssl.cc:1508: warning:
Cppcheck(unreadVariable): Variable 'in_offset' is assigned a value that
is never used.
/libretroshare/src/pqi/authssl.cc:249: warning:
Cppcheck(useInitializationList): Variable 'name' is assigned in
constructor body. Consider performing initialization in initialization
list.
/libretroshare/src/pqi/authgpg.cc:124: warning:
Cppcheck(uninitMemberVar): Member variable 'AuthGPG::mStoreKeyTime' is
not initialized in the constructor.
/libretroshare/src/pqi/authgpg.h:58: warning:
Cppcheck(noExplicitConstructor): Class 'AuthGPGOperation' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/plugins/pluginmanager.h:48: warning:
Cppcheck(noExplicitConstructor): Class 'RsPluginManager' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/pgp/rscertificate.cc:75: warning:
Cppcheck(unusedVariable): Unused variable: res
/libretroshare/src/pgp/rscertificate.h:55: warning:
Cppcheck(operatorEqVarError): Member variable
'RsCertificate::ipv4_external_ip_and_port' is not assigned a value in
'RsCertificate::operator='.
/libretroshare/src/pgp/rscertificate.h:55: warning:
Cppcheck(operatorEqVarError): Member variable
'RsCertificate::ipv4_internal_ip_and_port' is not assigned a value in
'RsCertificate::operator='.
/libretroshare/src/pgp/rscertificate.h:55: warning:
Cppcheck(operatorEqVarError): Member variable
'RsCertificate::binary_pgp_key' is not assigned a value in
'RsCertificate::operator='.
/libretroshare/src/pgp/rscertificate.h:55: warning:
Cppcheck(operatorEqVarError): Member variable
'RsCertificate::binary_pgp_key_size' is not assigned a value in
'RsCertificate::operator='.
/libretroshare/src/pgp/rscertificate.h:55: warning:
Cppcheck(operatorEqVarError): Member variable 'RsCertificate::only_pgp'
is not assigned a value in 'RsCertificate::operator='.
/libretroshare/src/pgp/rscertificate.h:55: warning:
Cppcheck(operatorEqVarError): Member variable
'RsCertificate::hidden_node' is not assigned a value in
'RsCertificate::operator='.
/libretroshare/src/pgp/rscertificate.h:16: warning:
Cppcheck(noExplicitConstructor): Class 'RsCertificate' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:75: warning:
Cppcheck(uninitMemberVar): Member variable 'RsGxsTunnelDataItem::flags'
is not initialized in the constructor.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:76: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsTunnelDataItem::unique_item_counter' is not initialized in the
constructor.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:76: warning:
Cppcheck(uninitMemberVar): Member variable 'RsGxsTunnelDataItem::flags'
is not initialized in the constructor.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:76: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsTunnelDataItem::service_id' is not initialized in the constructor.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:111: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsTunnelDataAckItem::unique_item_counter' is not initialized in the
constructor.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:128: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsTunnelDHPublicKeyItem::public_key' is not initialized in the
constructor.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:145: warning:
Cppcheck(operatorEqVarError): Member variable
'RsGxsTunnelDHPublicKeyItem::public_key' is not assigned a value in
'RsGxsTunnelDHPublicKeyItem::operator='.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:56: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsTunnelItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:76: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsTunnelDataItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/gxstunnel/p3gxstunnel.h:127: warning:
Cppcheck(noExplicitConstructor): Class 'p3GxsTunnelService' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/gxstrans/p3gxstransitems.h:42: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsTransBaseMsgItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/gxstrans/p3gxstrans.h:296: warning:
Cppcheck(noExplicitConstructor): Class 'GxsTransIntegrityCleanupThread'
has a constructor with 1 argument that is not explicit.
/libretroshare/src/gxs/rsgxsdataaccess.h:40: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsDataAccess' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/gxs/rsgixs.h:179: warning: Cppcheck(uninitMemberVar):
Member variable 'GixsReputation::reputation_level' is not initialized in
the constructor.
/libretroshare/src/gxs/rsgenexchange.cc:2165: warning:
Cppcheck(redundantAssignment): Variable 'serialOk' is reassigned a value
before the old one has been used.
/libretroshare/src/gxs/rsgenexchange.cc:1227: warning:
Cppcheck(unusedVariable): Unused variable: metaL
/libretroshare/src/gxs/rsgenexchange.cc:2254: warning:
Cppcheck(unreadVariable): Variable 's' is assigned a value that is never
used.
/libretroshare/src/gxs/rsgenexchange.cc:71: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGenExchange::mCheckStarted' is not initialized in the constructor.
/libretroshare/src/gxs/gxstokenqueue.h:51: warning:
Cppcheck(noExplicitConstructor): Class 'GxsTokenQueue' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/grouter/p3grouter.cc:2295: warning:
Cppcheck(cstyleCast): C-style pointer casting
/libretroshare/src/grouter/p3grouter.h:82: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterDataInfo::last_activity_TS' is not initialized in the
constructor.
/libretroshare/src/grouter/p3grouter.cc:206: warning:
Cppcheck(uninitMemberVar): Member variable 'p3GRouter::mTurtle' is not
initialized in the constructor.
/libretroshare/src/grouter/p3grouter.cc:206: warning:
Cppcheck(uninitMemberVar): Member variable 'p3GRouter::mLinkMgr' is not
initialized in the constructor.
/libretroshare/src/grouter/grouteritems.h:93: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterAbstractMsgItem::flags' is not initialized in the constructor.
/libretroshare/src/grouter/grouteritems.h:106: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterGenericDataItem::data_size' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:106: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterGenericDataItem::data_bytes' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:106: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterGenericDataItem::duplication_factor' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:159: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterTransactionChunkItem::chunk_start' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:159: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterTransactionChunkItem::chunk_size' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:159: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterTransactionChunkItem::total_size' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:159: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterTransactionChunkItem::chunk_data' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:220: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterMatrixTrackItem::time_stamp' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:62: warning:
Cppcheck(noExplicitConstructor): Class 'RsGRouterItem' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/grouter/grouteritems.h:93: warning:
Cppcheck(noExplicitConstructor): Class 'RsGRouterAbstractMsgItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/grouter/grouteritems.h:147: warning:
Cppcheck(noExplicitConstructor): Class 'RsGRouterTransactionItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/grouter/grouteritems.h:274: warning:
Cppcheck(noExplicitConstructor): Class 'RsGRouterSerialiser' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/grouter/groutertypes.h:99: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterRoutingInfo::data_status' is not initialized in the constructor.
/libretroshare/src/grouter/groutertypes.h:99: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterRoutingInfo::tunnel_status' is not initialized in the
constructor.
/libretroshare/src/grouter/groutertypes.h:99: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterRoutingInfo::received_time_TS' is not initialized in the
constructor.
/libretroshare/src/grouter/groutertypes.h:99: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterRoutingInfo::last_sent_TS' is not initialized in the
constructor.
/libretroshare/src/grouter/groutertypes.h:99: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterRoutingInfo::last_tunnel_request_TS' is not initialized in the
constructor.
/libretroshare/src/grouter/groutertypes.h:99: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterRoutingInfo::sending_attempts' is not initialized in the
constructor.
/libretroshare/src/grouter/groutertypes.h:99: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterRoutingInfo::routing_flags' is not initialized in the
constructor.
/libretroshare/src/ft/ftturtlefiletransferitem.h:36: warning:
Cppcheck(uninitMemberVar): Member variable
'RsTurtleFileRequestItem::chunk_offset' is not initialized in the
constructor.
/libretroshare/src/ft/ftturtlefiletransferitem.h:36: warning:
Cppcheck(uninitMemberVar): Member variable
'RsTurtleFileRequestItem::chunk_size' is not initialized in the
constructor.
/libretroshare/src/ft/ftturtlefiletransferitem.h:52: warning:
Cppcheck(uninitMemberVar): Member variable
'RsTurtleFileDataItem::chunk_offset' is not initialized in the
constructor.
/libretroshare/src/ft/ftturtlefiletransferitem.h:52: warning:
Cppcheck(uninitMemberVar): Member variable
'RsTurtleFileDataItem::chunk_size' is not initialized in the
constructor.
/libretroshare/src/ft/ftturtlefiletransferitem.h:52: warning:
Cppcheck(uninitMemberVar): Member variable
'RsTurtleFileDataItem::chunk_data' is not initialized in the
constructor.
/libretroshare/src/ft/ftturtlefiletransferitem.h:102: warning:
Cppcheck(uninitMemberVar): Member variable
'RsTurtleChunkCrcRequestItem::chunk_number' is not initialized in the
constructor.
/libretroshare/src/ft/ftturtlefiletransferitem.h:116: warning:
Cppcheck(uninitMemberVar): Member variable
'RsTurtleChunkCrcItem::chunk_number' is not initialized in the
constructor.
/libretroshare/src/ft/fttransfermodule.cc:158: warning:
Cppcheck(unreadVariable): Variable 'mit' is assigned a value that is
never used.
/libretroshare/src/ft/fttransfermodule.h:59: warning:
Cppcheck(noExplicitConstructor): Class 'peerInfo' has a constructor with
1 argument that is not explicit.
/libretroshare/src/ft/fttransfermodule.h:114: warning:
Cppcheck(noExplicitConstructor): Class 'ftFileStatus' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/ft/fttransfermodule.cc:548: warning:
Cppcheck(noExplicitConstructor): Class 'HashThread' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/ft/ftserver.cc:134: warning:
Cppcheck(unreadVariable): Variable 'localcachedir' is assigned a value
that is never used.
/libretroshare/src/ft/ftserver.cc:135: warning:
Cppcheck(unreadVariable): Variable 'remotecachedir' is assigned a value
that is never used.
/libretroshare/src/ft/ftfilecreator.cc:86: warning:
Cppcheck(unusedVariable): Unused variable: it
/libretroshare/src/ft/ftfilecreator.cc:545: warning:
Cppcheck(unreadVariable): Variable 'chunks_for_this_peer' is modified
but its new value is never used.
/libretroshare/src/file_sharing/p3filelists.h:86: warning:
Cppcheck(noExplicitConstructor): Class 'p3FileDatabase' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/file_sharing/rsfilelistitems.h:78: warning:
Cppcheck(uninitMemberVar): Member variable
'RsFileListsSyncRequestItem::flags' is not initialized in the
constructor.
/libretroshare/src/file_sharing/rsfilelistitems.h:78: warning:
Cppcheck(uninitMemberVar): Member variable
'RsFileListsSyncRequestItem::last_known_recurs_modf_TS' is not
initialized in the constructor.
/libretroshare/src/file_sharing/rsfilelistitems.h:78: warning:
Cppcheck(uninitMemberVar): Member variable
'RsFileListsSyncRequestItem::request_id' is not initialized in the
constructor.
/libretroshare/src/file_sharing/rsfilelistitems.h:94: warning:
Cppcheck(uninitMemberVar): Member variable
'RsFileListsSyncResponseItem::flags' is not initialized in the
constructor.
/libretroshare/src/file_sharing/rsfilelistitems.h:94: warning:
Cppcheck(uninitMemberVar): Member variable
'RsFileListsSyncResponseItem::last_known_recurs_modf_TS' is not
initialized in the constructor.
/libretroshare/src/file_sharing/rsfilelistitems.h:94: warning:
Cppcheck(uninitMemberVar): Member variable
'RsFileListsSyncResponseItem::request_id' is not initialized in the
constructor.
/libretroshare/src/file_sharing/rsfilelistitems.h:52: warning:
Cppcheck(noExplicitConstructor): Class 'RsFileListsItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/file_sharing/hash_cache.h:57: warning:
Cppcheck(noExplicitConstructor): Class 'HashStorage' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/file_sharing/p3filelists.cc:375: warning:
Cppcheck(unusedVariable): Unused variable: mit
/libretroshare/src/file_sharing/p3filelists.cc:1530: warning:
Cppcheck(unreadVariable): Variable 'indent' is assigned a value that is
never used.
/libretroshare/src/file_sharing/hash_cache.h:57: warning:
Cppcheck(noExplicitConstructor): Class 'HashStorage' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/file_sharing/directory_storage.h💯 warning:
Cppcheck(noExplicitConstructor): Class 'FileIterator' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/file_sharing/directory_storage.cc:579: warning:
Cppcheck(unusedVariable): Unused variable: peers
/libretroshare/src/file_sharing/dir_hierarchy.cc:883: warning:
Cppcheck(unreadVariable): Variable 'nunknown' is modified but its new
value is never used.
/libretroshare/src/file_sharing/dir_hierarchy.h:71: warning:
Cppcheck(noExplicitConstructor): Class 'DirEntry' has a constructor with
1 argument that is not explicit.
/libretroshare/src/file_sharing/dir_hierarchy.cc:1056: warning:
Cppcheck(noExplicitConstructor): Class 'read_error' has a constructor
with 1 argument that is not explicit.
In lastest Qt versions linux-* mkspec doesn't match android anymore,
this was triggering a compilation error as DATA_DIR was not defined the
RsAccountsDetail::PathDataDirectory(bool check) code has been rearranged
so it works reasonably also on Android and do not depend on DATA_DIR
define anymore
Updated Android compiling documentation
/libretroshare/src/file_sharing/p3filelists.cc👎 In static member
function ‘static bool p3FileDatabase::convertPointerToEntryIndex(const
void*, p3FileDatabase::EntryIndex&, uint32_t&)’:
/libretroshare/src/file_sharing/p3filelists.cc:624: warning:
dereferencing type-punned pointer will break strict-aliasing rules [-
Wstrict-aliasing]
e = EntryIndex( *reinterpret_cast<uint32_t*>(&p) &
ENTRY_INDEX_BIT_MASK ) ;
/home/phenom/GIT/RetroShare/trunk/libretroshare/src/file_sharing/
p3filelists.cc:625: warning: dereferencing type-punned pointer will
break strict-aliasing rules [-Wstrict-aliasing]
friend_index = (*reinterpret_cast<uint32_t*>(&p)) >>
NB_ENTRY_INDEX_BITS ;
/libretroshare/src/gxstrans/p3gxstransitems.h:29: In file included from
../../../trunk/libretroshare/src/gxstrans/p3gxstransitems.h:29:0,
/libretroshare/src/gxstrans/p3gxstransitems.cc:19: from ../../../trunk/
libretroshare/src/gxstrans/p3gxstransitems.cc:19:
/libretroshare/src/gxstrans/p3gxstransitems.cc👎 In member function
‘virtual void
OutgoingRecord_deprecated::serial_process(RsGenericSerializer::SerializeJob,
RsGenericSerializer::SerializeContext&)’:
/libretroshare/src/serialiser/rstypeserializer.h:61: warning:
dereferencing type-punned pointer will break strict-aliasing rules [-
Wstrict-aliasing]
RsTypeSerializer::serial_process<T>(j, ctx, reinterpret_cast<T&>(I),
#I);\
/libretroshare/src/gxstrans/p3gxstransitems.cc:51: in expansion of macro
‘RS_REGISTER_SERIAL_MEMBER_TYPED’
RS_REGISTER_SERIAL_MEMBER_TYPED(clientService, uint16_t);
/libretroshare/src/gxstrans/p3gxstransitems.cc👎 In member function
‘virtual void
OutgoingRecord::serial_process(RsGenericSerializer::SerializeJob,
RsGenericSerializer::SerializeContext&)’:
/libretroshare/src/serialiser/rstypeserializer.h:61: warning:
dereferencing type-punned pointer will break strict-aliasing rules [-
Wstrict-aliasing]
RsTypeSerializer::serial_process<T>(j, ctx, reinterpret_cast<T&>(I),
#I);\
/libretroshare/src/gxstrans/p3gxstransitems.cc:65: in expansion of macro
‘RS_REGISTER_SERIAL_MEMBER_TYPED’
RS_REGISTER_SERIAL_MEMBER_TYPED(clientService, uint16_t);
/retroshare-gui/src/gui/common/RsBanListToolButton.cpp👎 In member
function ‘void RsBanListToolButton::applyIp()’:
/retroshare-gui/src/gui/common/RsBanListToolButton.cpp:163: warning:
‘list_type’ may be used uninitialized in this function [-Wmaybe-
uninitialized]
changed = rsBanList->removeIpRange(addr, masked_bytes, list_type);
/libretroshare/src/services/p3idservice.cc:1216: error:
Cppcheck(eraseDereference): Iterator 'it' used after element has been
erased.
/libretroshare/src/services/p3idservice.cc:1346: error:
Cppcheck(eraseDereference): Iterator 'it' used after element has been
erased.
/libretroshare/src/services/p3idservice.cc:448: error:
Cppcheck(uninitvar): Uninitialized variable: max_keep_time
previously declared as a class
/libretroshare/src/chat/p3chatservice.h:56: warning: 'p3ChatService'
defined as a struct here but previously declared as a class [-
Wmismatched-tags]
struct p3ChatService :
/libretroshare/src/rsserver/p3msgs.h:33: did you mean struct here?
class p3ChatService;
previously declared as a class
/libretroshare/src/services/p3msgservice.h:58: warning: 'p3MsgService'
defined as a struct here but previously declared as a class [-
Wmismatched-tags]
struct p3MsgService :
/libretroshare/src/rsserver/p3msgs.h:32: did you mean struct here?
class p3MsgService;
/libretroshare/src/dht/connectstatebox.cc:394: warning: this statement
may fall through [-Wimplicit-fallthrough=]
if (mNextAttemptTS > now)
/libretroshare/src/dht/connectstatebox.cc:401: here
default:
/libretroshare/src/dht/connectstatebox.cc:406: warning: this statement
may fall through [-Wimplicit-fallthrough=]
if (mState != CSB_FAILED_WAIT)
/libretroshare/src/dht/connectstatebox.cc:414: here
case CSB_START:
/libretroshare/src/dht/connectstatebox.cc:530: warning: this statement
may fall through [-Wimplicit-fallthrough=]
if (mNextAttemptTS > now)
/libretroshare/src/dht/connectstatebox.cc:540: here
default:
/libretroshare/src/dht/connectstatebox.cc:543: warning: this statement
may fall through [-Wimplicit-fallthrough=]
if (mState != CSB_FAILED_WAIT)
/libretroshare/src/dht/connectstatebox.cc:551: here
case CSB_START:
/libretroshare/src/gxs/rsgxsnetservice.cc:247: warning: unused variable
'GIXS_CUT_OFF' [-Wunused-const-variable]
static const uint32_t GIXS_CUT_OFF =
0;
/libretroshare/src/gxs/rsgxsnetservice.cc:251: warning: unused variable
'SECURITY_DELAY_TO_FORCE_CLIENT_REUPDATE' [-Wunused-const-variable]
static const uint32_t SECURITY_DELAY_TO_FORCE_CLIENT_REUPDATE =
3600; // force re-update if there happens to be a large delay between
our server side TS and the client side TS of friends
/libretroshare/src/chat/distributedchat.cc:57: warning: unused variable
'MAX_MESSAGES_PER_SECONDS_NUMBER' [-Wunused-const-variable]
static const uint32_t MAX_MESSAGES_PER_SECONDS_NUMBER = 5 ; // max
number of messages from a given peer in a window for duration below
declared as a struct
/libretroshare/src/gxstrans/p3gxstrans.h:88: warning: 'p3GxsTrans'
defined as a class here but previously declared as a struct [-
Wmismatched-tags]
class p3GxsTrans : public RsGenExchange, public GxsTokenQueue, public
p3Config, public RsGxsTrans
/libretroshare/src/gxstrans/p3gxstrans.h:31: did you mean class here?
struct p3GxsTrans;
/libretroshare/src/gxstrans/p3gxstrans.cc:870: warning: this statement
may fall through [-Wimplicit-fallthrough=]
pr.sent_ts = time(NULL) ; //pr.mailItem.meta.mPublishTs = time(NULL);
/libretroshare/src/gxstrans/p3gxstrans.cc:872: here
case GxsTransSendStatus::PENDING_PREFERRED_GROUP:
/libretroshare/src/gxstrans/p3gxstrans.cc:883: warning: this statement
may fall through [-Wimplicit-fallthrough=]
pr.group_id = mPreferredGroupId ; //pr.mailItem.meta.mGroupId =
mPreferredGroupId;
/libretroshare/src/gxstrans/p3gxstrans.cc:885: here
case GxsTransSendStatus::PENDING_RECEIPT_CREATE:
/libretroshare/src/gxstrans/p3gxstrans.cc:906: warning: this statement
may fall through [-Wimplicit-fallthrough=]
pr.presignedReceipt.msg.setBinData(&grsrz[0], grsz);
/libretroshare/src/gxstrans/p3gxstrans.cc:908: here
case GxsTransSendStatus::PENDING_RECEIPT_SIGNATURE: // (cyril)
This step is never actually used.
/libretroshare/src/gxstrans/p3gxstrans.cc:924: warning: this statement
may fall through [-Wimplicit-fallthrough=]
pr.presignedReceipt.meta.setBinData(&srx[0], metaSize);
/libretroshare/src/gxstrans/p3gxstrans.cc:926: here
case GxsTransSendStatus::PENDING_PAYLOAD_CREATE:
/libretroshare/src/gxstrans/p3gxstrans.cc:938: warning: this statement
may fall through [-Wimplicit-fallthrough=]
memcpy(&pr.mailItem.payload[offset], &pr.mailData[0], datasize);
/libretroshare/src/gxstrans/p3gxstrans.cc:940: here
case GxsTransSendStatus::PENDING_PAYLOAD_ENCRYPT:
/libretroshare/src/gxstrans/p3gxstrans.cc:982: warning: this statement
may fall through [-Wimplicit-fallthrough=]
}
/libretroshare/src/gxstrans/p3gxstrans.cc:984: here
case GxsTransSendStatus::PENDING_PUBLISH:
/libretroshare/src/gxs/rsgxsnetservice.cc:867: warning: variable ‘it’
set but not used [-Wunused-but-set-variable]
std::map<RsGxsGroupId,RsGxsServerMsgUpdate>::iterator it =
mServerMsgUpdateMap.find(grpId) ;
/libretroshare/src/gxs/rsgxsnetservice.cc:2434: warning: variable ‘it’
set but not used [-Wunused-but-set-variable]
ClientGrpMap::iterator it =
mClientGrpUpdateMap.find(peerFrom);
/libretroshare/src/util/dnsresolver.cc:49: warning: this statement may
fall through [-Wimplicit-fallthrough=]
case DNSResolver::DNS_LOOKUP_ERROR: if(it-
>second.last_lookup_time + MAX_TIME_BEFORE_RETRY > now)
/libretroshare/src/util/dnsresolver.cc:52: here
case DNSResolver::DNS_DONT_HAVE: next_call = it->first ;
/libretroshare/src/util/rsnet_ss.cc:1031: warning: this statement may
fall through [-Wimplicit-fallthrough=]
success = inet_ntop( addr.ss_family, (const void *) &(addrv4p-
>sin_addr), ipStr, INET_ADDRSTRLEN );
/libretroshare/src/util/rsnet_ss.cc:1033: here
case AF_INET6:
/libretroshare/src/util/rscompress.cc:165: warning: this statement may
fall through [-Wimplicit-fallthrough=]
ret = Z_DATA_ERROR; /* and fall through */
/home/phenom/GIT/RetroShare/trunk/libretroshare/src/util/rscompress.cc:
166: here
case Z_DATA_ERROR:
/libretroshare/src/rsserver/p3serverconfig.cc:292: warning: this
statement may fall through [-Wimplicit-fallthrough=]
if (mPeerMgr->getFriendCount(true, false) > MIN_BASIC_FRIENDS)
/libretroshare/src/rsserver/p3serverconfig.cc:297: here
case RSCONFIG_USER_LEVEL_BASIC:
/libretroshare/src/rsserver/p3serverconfig.cc:300: warning: this
statement may fall through [-Wimplicit-fallthrough=]
if (mPeerMgr->haveOnceConnected())
/libretroshare/src/rsserver/p3serverconfig.cc:306: here
case RSCONFIG_USER_LEVEL_CASUAL:
/libretroshare/src/rsserver/rsaccounts.cc:130: warning: variable
‘pgpNameFound’ set but not used [-Wunused-but-set-variable]
bool pgpNameFound = false;
/libretroshare/src/pqi/pqissl.cc:449: warning: this statement may fall
through [-Wimplicit-fallthrough=]
sslmode = PQISSL_ACTIVE; /* we're starting this one */
/libretroshare/src/pqi/pqissl.cc:456: here
case WAITING_DELAY:
/libretroshare/src/pqi/pqisslpersongrp.cc:125: warning: this statement
may fall through [-Wimplicit-fallthrough=]
std::cerr << " --> falling back to Tor" << std::endl;
/libretroshare/src/pqi/pqisslpersongrp.cc:126: here
case RS_HIDDEN_TYPE_TOR:
/libretroshare/src/pqi/p3peermgr.cc:2619: warning: variable ‘peerIt1’
set but not used [-Wunused-but-set-variable]
std::set<RsPgpId>::iterator peerIt1 =
groupItem.peerIds.find(*peerIt);
/libretroshare/src/pgp/pgphandler.cc:62: warning: this statement may
fall through [-Wimplicit-fallthrough=]
case OPS_PARSER_CMD_GET_SK_PASSPHRASE_PREV_WAS_BAD: prev_was_bad =
true ;
/libretroshare/src/pgp/pgphandler.cc:63: here
case OPS_PARSER_CMD_GET_SK_PASSPHRASE:
/libretroshare/src/ft/ftchunkmap.cc:190: warning: this statement may
fall through [-Wimplicit-fallthrough=]
case FileChunksInfo::CHUNK_CHECKING: _file_is_complete = false ;
/libretroshare/src/ft/ftchunkmap.cc:191: here
case FileChunksInfo::CHUNK_DONE: _total_downloaded +=
sizeOfChunk(i) ;
/libretroshare/src/tcponudp/bss_tou.c:246: warning: this statement may
fall through [-Wimplicit-fallthrough=]
num=0;
/libretroshare/src/tcponudp/bss_tou.c:247: here
case BIO_C_FILE_SEEK:
Avoid to forge the
[Starting distant chat. Please wait for secure tunnel to be established]
message on requesting chat id from API as it is a nuisance in most
libresapi use cases
pqi/authssl.cc: In member function 'virtual X509*
AuthSSLimpl::SignX509ReqWithGPG(X509_REQ*, long int)':
pqi/authssl.cc:929:3: error: jump to label 'err' [-fpermissive]
err:
^
pqi/authssl.cc:872:22: error: from here [-fpermissive]
goto err;
^
pqi/authssl.cc:877:24: error: crosses initialization of 'unsigned
char* p'
unsigned char *p=buf_in;
^
pqi/authssl.cc: In member function 'virtual bool
AuthSSLimpl::AuthX509WithGPG(X509*, uint32_t&)':
pqi/authssl.cc:1091:1: error: jump to label 'err' [-fpermissive]
err:
^
pqi/authssl.cc:1027:8: error: from here [-fpermissive]
goto err;
^
pqi/authssl.cc:1035:17: error: crosses initialization of 'unsigned
char* p'
unsigned char *p=buf_in;
^
RsItem added some comment and more verbose error reporting
RsTypeSerializer added support for RsItem derived classes as members
added utility macros for better readability of the code and easier
handling of RsItem derived members
RS_REGISTER_SERIAL_MEMBER(I)
RS_REGISTER_SERIAL_MEMBER_TYPED(I, T)
RS_REGISTER_ITEM_TYPE(T)
RsNxsMsg::serial_process use new macros for better readability and to
have an exemple of usage with RsTlvItem derived class
Fix undefined reference to RsNxsMsg::print
/libretroshare/src/pqi/pqiservice.h:80: warning: unused parameter
‘names’ [-Wunused-parameter]
virtual void getItemNames(std::map<uint8_t,std::string>& names)
const {} // This does nothing by default. Service should derive it in
order to give info for the UI
^~~~~
To import contact
/identity/import_key
{"radix":"AgIRBAAABd..."}
To export contact
/identity/export_key
{"gxs_id":"ffffffffffffffffffffffffffffffff"}
In both cases if everithing went fine the answer is something like
{"data":{"radix":"AgIRBAAABd...", "gxs_id":"fff..."}, "returncode":"ok"}
Some retrocompatible adaptations were necessary to libretroshare
RsGenExchange::deserializeGroupData
p3IdService::deserialiseIdentityFromMemory
Now accept an extra optional pointer parameter to return the id of the
key so we can return it back from libresapi too and can be used to
request more information about the key to the API.
warning: implicit conversion from 'int' to 'char' changes value from 255
to -1 [-Wconstant-conversion]
asctobin()[i] = 255; /* used to
detect invalid characters */
warning: private field 'mAutoBanIdentitiesLimit' is not used [-Wunused-
private-field]
float mAutoBanIdentitiesLimit ;
warning: private field 'mFiles' is not used [-Wunused-private-field]
RsFiles* mFiles;