Commit Graph

5992 Commits

Author SHA1 Message Date
csoler
48960d548d
Merge pull request #1880 from jolavillette/threadTick
clean rewrite of RsServer::threadTick
2020-05-03 13:28:43 +02:00
jolavillette
7db8cbca97 remove debug flag 2020-05-02 21:21:42 +02:00
csoler
efb26ce9c0
added warnign when notified CircleMsg cannot be retrieved from DB 2020-05-02 15:48:38 +02:00
csoler
32baccae97
finished cleaning GxsCircle Notifications 2020-05-02 15:09:32 +02:00
jolavillette
d35dd76ca5 try to isolate pqistreamer mutex from pqissl mutex, step 1: pqistreamer::tick_recv() 2020-05-02 09:47:24 +02:00
csoler
26dd716967
added documentation on circle membership at UI and circles API level. Internals need to be implemented accordingly 2020-05-01 22:59:39 +02:00
csoler
d32daaa111
made group notifications separate so that they can be treated more easily and added group item to new_group notifications, to allow more GUI notifications 2020-05-01 00:00:13 +02:00
Phenom
e8b8119174 Fix Channel Post Comments Number 2020-04-29 00:52:19 +02:00
csoler
767440afc5
added circle invite notifications 2020-04-28 21:39:38 +02:00
sehraf
04dc163d30
pqissl: document statemachine and function hierarchy 2020-04-28 19:17:35 +02:00
Olivier Marty
b0613ef653 Correct design flaw in slow process control, improve indentation, set up debug #ifdef 2020-04-28 09:48:12 +02:00
csoler
59b7f042e1
Merge pull request #1879 from G10h4ck/item_uninitialized_ptr
RawMemoryWrapper::serial_process report error
2020-04-27 23:24:09 +02:00
csoler
f5af7dfeb3
fixed up top bar tooltips to display what the numbers actually mean 2020-04-27 21:56:43 +02:00
csoler
0f1a3879d0
quick fix for debug flag that was left in the code 2020-04-27 20:28:34 +02:00
Gioacchino Mazzurco
6fc89c2d37
RawMemoryWrapper DESERIALIZE warn if got non null ptr 2020-04-27 20:22:50 +02:00
csoler
28a6b43357
added missing file 2020-04-27 17:11:06 +02:00
Olivier Marty
9a9eb56a3a clean rewrite of RsServer::threadTick 2020-04-27 16:08:20 +02:00
csoler
f7199f1f1c
moved GxsNotify classes to rsgxsnotify.h internal to gxs (not visible in API) since it is unused in GUI. Added event item in forum to handle moderator list changes 2020-04-26 23:35:37 +02:00
csoler
4b568f3068
fixed the same error in turtle generic search result 2020-04-26 15:34:28 +02:00
csoler
76e9387467
fixed deserialiser for rawWrapper causing crashes when wrapper memory is not initialized properly by the client 2020-04-26 14:19:44 +02:00
csoler
86897b60de
fixed uninitialized memory causing a crash in turtle items 2020-04-26 14:19:02 +02:00
csoler
ae54e53bc1
updated RsGenExchange::performUpdateValidation to simplify the logic and save (oldGrp,newGrp) in a specific RsGxsGroupUpdate subclass of GxsNotify so as to be able to handle group data notifications in services 2020-04-26 00:18:01 +02:00
csoler
9b0abe16dd
small fix to indent in authssl.cc 2020-04-25 18:07:04 +02:00
csoler
b2e36fbd9c
fixed version incompatibility in merge PR 1869 2020-04-24 23:06:29 +02:00
csoler
ad4939e64c
Merge pull request #1872 from b1rdG/patch-2
Improve documentation
2020-04-24 21:56:41 +02:00
csoler
e323bc8573
Merge pull request #1869 from PhenomRetroShare/Fix_OpenSSL1_CreatCertFail
Fix OpenSSL fail to create Cert.
2020-04-24 21:55:01 +02:00
b1rdG
36bab55d8c Use tabs instead of spaces 2020-04-23 15:15:03 -05:00
b1rdG
7290caa1a5
Improve documentation 2020-04-23 20:07:18 +00:00
b1rdG
b55d37efa4 Add RsGxsId checks 2020-04-23 14:56:53 -05:00
csoler
f9b731c92e
fixed free()/delete[] mismatch reported by valgrind 2020-04-22 20:32:16 +02:00
Phenom
866b564f90 Fix OpenSSL fail to create Cert. 2020-04-22 17:28:41 +02:00
csoler
5120f693be
Merge pull request #1859 from csoler/v0.6-ImprovedGUI_4
Making channels faster to load
2020-04-21 19:30:49 +02:00
Gioacchino Mazzurco
2f0b0f48bf
Better atomicity (not perfect) for RsDdg() and companions 2020-04-21 18:10:58 +02:00
csoler
1cfbfdaf63
Merge pull request #1866 from PhenomRetroShare/Fix_SIGSEGV_OnRsThreadStart
Fix SIGSEGV on RsThread::start
2020-04-21 13:11:35 +02:00
G10h4ck
2b44492cb6
Merge pull request #1829 from G10h4ck/rsfiles_links
RsFiles links support in libretroshare + a bunch of fixes
2020-04-20 17:12:04 +02:00
Gioacchino Mazzurco
3f38d04680
Clarify pointer ownership decorators documentation
Use old char* in PGP functionas asked by Cyril
2020-04-20 15:52:29 +02:00
Gioacchino Mazzurco
e406a1fb8b
Fix JSON API compilation after rebasing on master 2020-04-20 15:52:20 +02:00
csoler
38e89d4055
fixed merge with upstream/master 2020-04-19 21:53:02 +02:00
csoler
5b761c72ba
removed debug info 2020-04-19 21:07:53 +02:00
csoler
096cdd6dd2
Merge pull request #1863 from sehraf/pr_handle_deprecated_packets
Fix log spam by handling deprecated packet gracefully
2020-04-19 18:57:11 +02:00
Phenom
c0ce5c7088 Fix SIGSEGV on RsThread::start
mTid could be null while pError is null too.

This happens to me always with "gxs integrity".
2020-04-19 11:24:57 +02:00
sehraf
f19d933ff1
Partially revert bea6769a4e.
Currently the log is flooded with messages about "unkown" packets which are actually just deprecated ones. Add back the code to gracefully handle them (= delete them).
2020-04-18 11:45:35 +02:00
b1rdG
d100e53470
Improve parameter description 2020-04-17 22:09:40 +00:00
b1rdG
d265e61b06
Expose JSON API closeDistantChatConnexion and initiateDistantChatConnexion 2020-04-17 21:56:58 +00:00
csoler
fa8968797c
added some tests to insertGroupData() to avoid inconsistent calls 2020-04-16 21:35:57 +02:00
csoler
915e197223
Merge pull request #1857 from csoler/v0.6-GxsDbFix
Quick fix to allow plugin loading
2020-04-15 11:09:05 +02:00
csoler
59508d4c7e
fixed plugin loading 2020-04-14 21:38:52 +02:00
Gioacchino Mazzurco
f54fb046e4
Use a a loop instead of std::trasform as suggested by Cyril 2020-04-14 12:26:21 +02:00
Gioacchino Mazzurco
7d388c3090
Solve non compatible 32/64bit file handle API 2020-04-14 12:26:21 +02:00
Gioacchino Mazzurco
2a369cb785
Fix noisy compiler warning 2020-04-14 12:26:21 +02:00
Gioacchino Mazzurco
a4950aca66
Safer checks in type serializer 2020-04-14 12:24:58 +02:00
Gioacchino Mazzurco
0c3fd6f27c
Explicit type as requested by Cyril 2020-04-14 12:24:58 +02:00
Gioacchino Mazzurco
b701ca8da3
Keep 10 extra unassigned slots for event types
Proper error reporting + cruft removal
2020-04-14 12:24:58 +02:00
Gioacchino Mazzurco
76d492b4aa
Add forgot authorship in rsbase64* 2020-04-14 12:24:58 +02:00
Gioacchino Mazzurco
05f65e9211
Fix missing paramether direction in Doxygen doc 2020-04-14 12:24:58 +02:00
Gioacchino Mazzurco
13e0179812
Readd struct disappeared in rebase + fix warning 2020-04-14 12:24:58 +02:00
Gioacchino Mazzurco
612d47908d
Fix JSON API breakage introduced in cf7a77e512 2020-04-14 12:24:57 +02:00
Gioacchino Mazzurco
8cb46e5937
Fix compilation on Android arm64 2020-04-14 12:24:57 +02:00
Gioacchino Mazzurco
7d1efa7ed9
Fix compiler warnings 2020-04-14 12:24:57 +02:00
Gioacchino Mazzurco
4c0baa1ec3
Fix JSON API event handler registering behavior
As a bonus the behaviour is now homogeneous between C++ API and JSON API
Fix a bunch of compiler warning
RsEvents implementation is now safer
mHandlerMaps size is known at compile time, so use an std::array instead
  of vector
2020-04-14 12:24:57 +02:00
Gioacchino Mazzurco
ce5f5faa97
Fix Android compilation after rebase on master 2020-04-14 12:24:57 +02:00
Gioacchino Mazzurco
b42c0410f1
Expose pgpIdFromFingerprint to JSON API
+ missing explicit in one paramether costructor
2020-04-14 12:17:04 +02:00
Gioacchino Mazzurco
9d325e3d17
Fix mail in rsjsonapi.h copyright header 2020-04-14 12:17:03 +02:00
Gioacchino Mazzurco
0d1524aa12
Fix crash due to RsChatAvatarItem uninitialized pointer
Caught signal 11 (SIGSEGV)
stack trace:
retroshare( 0xbbd2da)[0x558ccf46a2da]
retroshare(CrashStackTrace::abortHandler(int) 0xeb)[0x558ccf471c5c]
/lib64/libc.so.6( 0x38f80)[0x7f6ef6facf80]
/lib64/libc.so.6(realloc 0x54)[0x7f6ef6fffef4]
retroshare(RsTypeSerializer::RawMemoryWrapper::serial_process(RsGenericSerializer::SerializeJob, RsGenericSerializer::SerializeContext&) 0x5d4)[0x558ccfcddad0]
retroshare(std::enable_if<std::is_base_of<RsSerializable, RsTypeSerializer::RawMemoryWrapper>::value, void>::type RsTypeSerializer::serial_process<RsTypeSerializer::RawMemoryWrapper>(RsGenericSerializer::SerializeJob, RsGenericSerializer::SerializeContext&, RsTypeSerializer::RawMemoryWrapper&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) 0x9d)[0x558ccfb3da66]
retroshare(RsChatAvatarItem::serial_process(RsGenericSerializer::SerializeJob, RsGenericSerializer::SerializeContext&) 0x84)[0x558ccff90ba6]
retroshare(RsServiceSerializer::deserialise(void*, unsigned int*) 0x403)[0x558ccfcd96e9]
retroshare(RsSerialiser::deserialise(void*, unsigned int*) 0x38e)[0x558ccfb5a1a8]
retroshare(pqiSSLstore::readPkt(RsItem**) 0x3f9)[0x558ccfad329f]
retroshare(pqiSSLstore::GetItem() 0xbb)[0x558ccfad2d9f]
retroshare(pqiSSLstore::getEncryptedItems(std::__cxx11::list<RsItem*, std::allocator<RsItem*> >&) 0x3e)[0x558ccfad2c26]
retroshare(p3Config::loadAttempt(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::list<RsItem*, std::allocator<RsItem*> >&) 0xf8)[0x558ccfab20d0]
retroshare(p3Config::loadConfig() 0xeb)[0x558ccfab1d69]
retroshare(p3Config::loadConfiguration(t_RsGenericIdType<20u, false, (RsGenericIdType)2>&) 0x1c)[0x558ccfab1c7c]
retroshare(p3ConfigMgr::loadConfig() 0x97)[0x558ccfab17f3]
retroshare(p3ConfigMgr::loadConfiguration() 0x18)[0x558ccfab1758]
retroshare(RsServer::StartupRetroShare() 0x4407)[0x558ccfb02fab]
retroshare(main 0x17e2)[0x558ccf46d291]
/lib64/libc.so.6(__libc_start_main 0xeb)[0x7f6ef6f97e9b]
retroshare(_start 0x2a)[0x558ccf438c9a]
D 1585687209 void RetroDb::closeDb() sqlite3_close return: 0
D 1585687209 void RetroDb::closeDb() sqlite3_close return: 0
Memory still in use at end of program: 24776 bytes.
2020-04-14 12:17:03 +02:00
Gioacchino Mazzurco
0187bf2f2f
Suppress eccessive VLQ debugging 2020-04-14 12:17:03 +02:00
Gioacchino Mazzurco
d7f23ce21c
Deprecate unreliable Channels features
Fix licensing years
2020-04-14 12:17:03 +02:00
Gioacchino Mazzurco
198fa7d8bc
RsFiles::parseFilesLink support old link formats 2020-04-14 12:17:03 +02:00
Gioacchino Mazzurco
8b4fcbe9e0
Remove unused constant from rsfiles.h 2020-04-14 12:17:03 +02:00
Gioacchino Mazzurco
a0da5a3120
Improve debugging 2020-04-14 12:17:02 +02:00
Gioacchino Mazzurco
1fd6e7e97a
Add API call to create links to extra files 2020-04-14 12:17:02 +02:00
Gioacchino Mazzurco
55aab6c447
Add RsFiles::requestFiles to de API to download whole colletions
Fix filetree creation from single file
RsDirUtil::moveFile now works also if parent directories doesn't exists
Backport std::filesystem::create_directories from C++17
2020-04-14 12:17:02 +02:00
Gioacchino Mazzurco
d666e58403
Fix regression in sequence container FROM_JSON 2020-04-14 12:17:02 +02:00
Gioacchino Mazzurco
fc5ad40c90
Add C++14 template types helpers that seems missing in TravisCI MacOSX 2020-04-14 12:17:02 +02:00
Gioacchino Mazzurco
da66719b83
Fix Android compilation 2020-04-14 12:17:02 +02:00
Gioacchino Mazzurco
5610cc8600
Fix memory management and deprecated removal from serialization
Fix missing RsDiscPgpKeyItem initialization
Fix inconsistent new[]/delete[] usage in RsDiscPgpKeyItem and
  PGPHandler::exportPublicKey which now consistently uses malloc/free
Remove deprecated RsGenericSerializer::FORMAT_*
Move from deprecated RsServiceSerializer::SERIALIZATION_FLAG_* to
  RsSerializationFlags
Solve a bunch of compiler warnings
Stricter checks in SerializeContext costructor
2020-04-14 12:17:01 +02:00
Gioacchino Mazzurco
39bde58c29
Many serialization and related stuff improvements
Fix bug in array-like containers serialization which could cause almost infinite
  loop on malformed input
Implement VLQ integer serialization
Unify sequence containers serialization code
Add support for VLQ serialization also for string size
Use VLQ compression for file links
Add templated function to fix endiannes for all integer types
Use bitset to print flags in binary form
Unify serialization code for integral types
Serialize 64bit integers types to JSON object with both string and integer
  representation, so it is posible to have this representation also for
  containers types like std::vetor or std::map this breaks retrocompatibility
  but is necessary to support clients written in languages which doesn't have
  64 bit integers support such as JavaScript or Dart
2020-04-14 12:17:01 +02:00
Gioacchino Mazzurco
d203f31d0c
Improve files links generation parsing and errors
Implement URL safe base64 for file links
Implement sneaking file data into URL fragment
Deprecate Radix65 in favore of RsBase64 which supports also URL safe encoding
2020-04-14 12:17:01 +02:00
Gioacchino Mazzurco
55d466f79b
Initial work on RsFiles links support in libretroshare 2020-04-14 12:17:01 +02:00
csoler
b6c5e2f188
Merge pull request #1847 from csoler/v0.6-GxsDbFix
This branch aims at fixing the requests problems in RsGxsDataAccess
2020-04-13 14:13:33 +02:00
csoler
bc748bf152
improved variable name and comment for GxsRequest::ansType 2020-04-13 13:35:35 +02:00
csoler
54f8ef1ffe
fixed small bug causing read/unread and new msgs to not update immediately 2020-04-12 23:07:42 +02:00
csoler
a8f94f9d74
cosmetic changes: std::cerr=>RsErr(), __PRETTY_FUNCTION__, removed debug flags, etc 2020-04-12 14:00:29 +02:00
csoler
f74c65fcc0
created a specific GxsEvent for Group Statistics changes and handle it in the GUI for all friends at once every 2 min at most 2020-04-11 20:52:35 +02:00
drbob
124781c1e0 Fixup PulseAddDialog and underlying datatypes
Cleaned up UI, removing unnecessary sidebar.
Added cleanup of Dialog to reset properly
Disabled URL adder, until it is complete
Added ComboBox for reply sentiment
Only enable Post button when length between 1 and 999 characters
Add Icon to WireGroup (future proofing datatype)
2020-04-11 12:55:04 +10:00
csoler
b7363b4d4e
fixed supid bug causing msgs to not be correctly retrieved 2020-04-10 22:23:49 +02:00
csoler
e433a64bb2
implemented new version of selection for only latest messages 2020-04-10 22:09:34 +02:00
csoler
4e66455ac0
started to re-write the getMsgMeta and Ids in gxsdataaccess for better efficiency. Lastest msgs only net yet functional 2020-04-09 22:55:13 +02:00
csoler
b0e61376f1
removed calls to getServiceStatistics from GxsUserNotify and replaced by info collected by GxsGroupFrameDialog 2020-04-08 21:11:53 +02:00
csoler
b51520bccf
Merge pull request #1846 from G10h4ck/millisec_dbg_message
Add millisecond details to debug messages timestamp
2020-04-08 16:39:31 +02:00
Gioacchino Mazzurco
8303f42af0
GitlabCI fix some tests 2020-04-08 12:10:06 +02:00
csoler
c60f1d1331
fixed merge with upstream/master 2020-04-08 10:41:47 +02:00
csoler
e0462b8411
Merge pull request #1845 from csoler/v0.6-FT4
Removed TokenQueue from GxsTransportStatistics
2020-04-08 10:25:41 +02:00
csoler
ebee69df96
fixed up display of GroupStatisticsReq and moved priorities to RsTokReqOptions 2020-04-07 22:42:01 +02:00
csoler
7c77e82b1e
added output to GxsRequest for debug purposes 2020-04-07 16:56:28 +02:00
csoler
5c71a46c52
fixed up the update of message count using a flag to only update when necessary, which limits drastically the calls to getGroupsStatistics() 2020-04-06 21:55:07 +02:00
csoler
65af73f8eb
fixed up new version of GxsDataAccess 2020-04-06 18:34:57 +02:00
Gioacchino Mazzurco
50adf00804
Add millisecond details to debug messages timestamp 2020-04-05 23:02:53 +02:00
csoler
2d23a9f251
experimental implementation of TokenQueue priority. not fully functional yet 2020-04-05 22:59:58 +02:00
csoler
9a1d589134
added a temporary copy of mRequests in RsGxsDataAccess::processRequests() to avoid interactions with storeRequest() mofying the queue 2020-04-05 16:41:44 +02:00
csoler
25467dda9f
Merge pull request #1831 from drbob/thewire_fix_message_display
TheWire fixup up display of messages
2020-04-05 11:33:27 +02:00
drbob
1c20d75a03 Update photo/wire/wiki interfaces to support Blocking Group API.
Add blocking API Group Interfaces for photo,wire and wiki services.
Add service blocking API calls for createGroup/updateGroup/getGroupData.
Update GUI classes to match new GxsGroupDialog Interfaces.
2020-04-05 15:04:39 +10:00
csoler
28a21392ca
removed TokenQueue from UserNotify 2020-04-04 22:54:54 +02:00
csoler
4653f18dd1
removed TokenQueue from GxsTransportStatistics 2020-04-04 22:00:52 +02:00
G10h4ck
76f3767756
Merge pull request #1843 from sehraf/pr_chat_event
fix last commit
2020-04-04 15:58:22 +02:00
sehraf
4bfbaef057
fix last commit 2020-04-04 15:11:29 +02:00
G10h4ck
208e96dc6c
Merge pull request #1842 from sehraf/pr_chat_event
Add chat events to RsEvent
2020-04-04 15:08:04 +02:00
sehraf
dfed3d6fb5
allow calling getDistantChatStatus via json api 2020-04-04 13:51:19 +02:00
sehraf
2abd284899
add chat to RsEvent 2020-04-04 13:30:23 +02:00
csoler
a0816c7324
Merge pull request #1838 from csoler/v0.6-FT4
Converting GxsMessageFrameWidget to blocking API, removing more TokenQueue from UI
2020-04-03 18:02:30 +02:00
csoler
449f9cb804
Merge pull request #1832 from sehraf/pr_fix-deadlock
i2pbob: fix deadlock on shutdown
2020-04-03 11:18:06 +02:00
csoler
cd98f02246
removed askForDeferredSelfSignature() and made IdEditDialog comply with this 2020-04-02 22:24:14 +02:00
csoler
0cc871da60
removed TokenQueue from IdEditDialog PGP Signed identities still not working 2020-04-01 22:34:47 +02:00
csoler
cf7a77e512
finished converting GxsMessageFrameWidget to blocking API 2020-03-31 20:21:16 +02:00
drbob
3402aa861f Merge branch 'master' into thewire_fix_message_display 2020-03-31 21:23:51 +11:00
csoler
55c810f848
first pass for converting GxsMessageFrameWidget to blocking API 2020-03-29 23:21:48 +02:00
csoler
c18dfb39c3
added some more debug info and proper error output to GxsDb 2020-03-26 23:19:34 +01:00
csoler
5dcbb978c3
improvement of autoloading of GxsGroupFrameDialog 2020-03-26 16:47:37 +01:00
csoler
6616e8a6b3
fixed priority problem in async request of group data tht shows up in RsGxsForumThreadWidget 2020-03-22 23:35:34 +01:00
csoler
0f5fd198a4
removed debug info in db access 2020-03-22 22:06:49 +01:00
csoler
6c1f09a53b
completely removed TokenQueue from GxsGroupDialog and GxsGroupFrameDialog 2020-03-22 21:47:14 +01:00
csoler
b8ec91aac5
fixed missing returns 2020-03-21 15:46:52 +01:00
csoler
2387150f64
1/4 convertion of GxsGroupFrameDialog to blocking API 2020-03-21 15:25:34 +01:00
csoler
1a9ac16546
fixed bug due to missing iterator increment 2020-03-19 21:20:52 +01:00
csoler
cd4594d0a3
merged with upstream/master 2020-03-19 09:15:45 +01:00
csoler
b6667a2c5a
fixed bug causing RS to eat all the memory, slow down GxsId access and ultimately make forums and other Gxs services to not load properly 2020-03-18 22:33:58 +01:00
csoler
676ddfbfb5
removed waitToken from GxsTokenService since it was only used directly by rsGenExchange to export keys 2020-03-17 23:33:03 +01:00
csoler
5408427ea8
added auto delete active token feature to RsGxsIfaceHelper 2020-03-17 00:13:29 +01:00
csoler
db42c7a973
removed sleep in p3GxsTunnel::tick() since it is not needed and causes unwanted delays 2020-03-15 13:15:33 +01:00
sehraf
ddd6b91f71
i2pbob: fix deadlock on shutdown 2020-03-13 17:08:48 +01:00
csoler
4c4b7ce754
Merge pull request #1826 from csoler/v0.6-FT4
attempt to solve GXS data access problems in new blocking API
2020-03-13 14:37:53 +01:00
drbob
fc53af2646 TheWire fixup up display of messages
Process messages to group replies correctly and sort by age.
Expand message display to include replies.
Add coloring to distinguish between replies and actual msgs.
Enable subscribe / unsubscribe buttons.
Add Selection of which set of groups are visible.
Add missing setNetworkExchangeService calls for photo + wire services.
2020-03-13 16:44:15 +11:00
csoler
230eca985f
reverted unnecessary cancel of tokens after waitToken in p3gxscircles 2020-03-11 22:42:34 +01:00
csoler
a02bb0acb6
added cancel in waitToken in rstokenservice 2020-03-11 22:41:57 +01:00
csoler
dc3c3488df
added blocking API for createComment() in GxsCommentService and removed token queue from GxsCreateCommentDialog 2020-03-09 21:01:55 +01:00
csoler
4031b081c5
Merge pull request #1824 from drbob/photos_improve_sharing
Updates to PhotoSharing service
2020-03-08 23:14:38 +01:00
Gioacchino Mazzurco
57be2cb11e
Silence excessive debugging in miniupnp handler 2020-03-08 22:07:12 +01:00
csoler
ab2c1f23e9
attempt to solve GXS data access problems in new blocking API 2020-03-07 20:39:10 +01:00
csoler
1f0678075f
merged upstream/master 2020-03-06 22:12:06 +01:00
Gioacchino Mazzurco
b62b3ec54b
Fix crash on Android due to dangling reference
JSON API debug lambda returned a dangling reference on Android, fix by
  moving the scope of the returned object
What made this a bit tricky to understand was the fact that it happened
only on Android, while the code was formally incorrect for all
platforms, and strangely caused a stack overflow due to two std lib
functions (sentry and flush) calling each other ad infinitum

+#23379 0x603cb2a8 in std::__ndk1::basic_ostream<char, std::__ndk1::char_traits<char> >::flush (this=0x618e92bc) at /opt/android-ndk/sources/cxx-stl/llvm-libc++/include/ostream:949
+#23380 0x603cad08 in std::__ndk1::basic_ostream<char, std::__ndk1::char_traits<char> >::sentry::sentry (this=0x618e9284, __os=...) at /opt/android-ndk/sources/cxx-stl/llvm-libc++/include/ostream:270
+#23381 0x603cb2a8 in std::__ndk1::basic_ostream<char, std::__ndk1::char_traits<char> >::flush (this=0x618e92bc) at /opt/android-ndk/sources/cxx-stl/llvm-libc++/include/ostream:949
+#23382 0x603cad08 in std::__ndk1::basic_ostream<char, std::__ndk1::char_traits<char> >::sentry::sentry (this=0x618e9304, __os=...) at /opt/android-ndk/sources/cxx-stl/llvm-libc++/include/ostream:270
+#23383 0x603caa6c in std::__ndk1::__put_character_sequence<char, std::__ndk1::char_traits<char> > (__os=..., __str=0x61379a60 " user: ", __len=7) at /opt/android-ndk/sources/cxx-stl/llvm-libc++/include/ostream:726
+#23384 0x603caa30 in std::__ndk1::operator<< <std::__ndk1::char_traits<char> > (__os=..., __str=0x61379a60 " user: ") at /opt/android-ndk/sources/cxx-stl/llvm-libc++/include/ostream:869
+#23385 0x60522184 in t_RsLogger<(RsLoggerCategories)5>::operator<< <char [8]> (this=0x618e92bc, val=...) at ../../../../Development/rs-develop/libretroshare/src/util/rsdebug.h:53
+#23386 0x60bbe5ec in JsonApiServer::registerHandler(std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&, std::__ndk1::function<void (std::__ndk1::shared_ptr<restbed::Session>)> const&, bool)::$_259::operator()(std::__ndk1::shared_ptr<restbed::Session>, std::__ndk1::function<void (std::__ndk1::shared_ptr<restbed::Session>)> const&) const (this=0x617d8364, session=..., callback=...) at ../../../../Development/rs-develop/libretroshare/src/jsonapi/jsonapi.cpp:517
2020-03-06 18:21:32 +01:00
drbob
88f76c5fbb Update the data in photoitems
Update PhotoItem members
 - remove excessive fields in Photo
 - add RsGxsFile to Photo
 - update ShareMode for Album
 - renamed photo.mThumbnail to mLowResImage
Update Photo GUI
 - enable setting of AlbumExtra parameters.
 - added data for Ordering of photos
 - stop showing duplicates in PhotoSlideShow
2020-03-07 00:13:25 +11:00
csoler
3bd23d612a
Merge pull request #1817 from G10h4ck/optional_dh_init_test
Add option to disable DH init check for faster init
2020-03-06 11:16:45 +01:00
csoler
f59193b625
fixed bug in SQL access where timeout was compared to a negative value 2020-03-05 20:51:02 +01:00
csoler
09fe628415
removed debug info 2020-03-05 20:50:25 +01:00
csoler
ae932b605a
fixed 2 bugs causing forums and channels to be notified when already known and added notification list for posted 2020-03-04 19:17:09 +01:00
Gioacchino Mazzurco
15c3e87bc5
Add option to disable DH init check for faster init
The check is not necessary and on Android it takes around 1 minute to
  complete.
2020-03-03 16:21:14 +01:00
csoler
97e7df82c5
Merge pull request #1816 from csoler/v0.6-FT4
TokenQueue cleanup
2020-03-01 17:29:44 +01:00
csoler
76596e678e
Merge pull request #1815 from drbob/thewire-get-basics-working
Get the basics of TheWire service working
2020-03-01 16:40:35 +01:00
csoler
f8d07a3e92
switched to more reasonnable timeout values in waitToken 2020-03-01 13:45:07 +01:00
csoler
c09e9c407b
removed warning about filtered packet 2020-02-29 23:06:43 +01:00
csoler
4124585b55
removed unused print methods in some RsItems since now print is handled by serializer 2020-02-29 12:14:37 +01:00