Commit Graph

6316 Commits

Author SHA1 Message Date
csoler
5ec3ae8640
Merge pull request #2224 from csoler/v0.6-BugFixing_5
continue bug fixing for 0.6.6 (See commits)
2021-01-18 13:24:31 +01:00
csoler
5d805e3798 fixed compilation, removing implicit cast from nullptr to uninitialized std::shared_ptr 2021-01-18 13:23:43 +01:00
Phenom
da02bf8ca1 Fix qmake error:
Please specify at least one package name on the command line.
2021-01-18 11:57:38 +01:00
csoler
e73e3232f6 fixed update of avatar/name in signed identities 2021-01-17 23:53:49 +01:00
csoler
217aa119ff limit distant search results to non circle-restricted groups 2021-01-15 22:48:31 +01:00
Phenom
31acef55d3 Fix Compil with Photo Service
CONFIG+=gxsphotoshare
2021-01-15 22:29:59 +01:00
csoler
dca8a5a91d fixed bug in chat history causing lots of gibberish output to the console 2021-01-14 22:35:08 +01:00
csoler
7f5f03bcda
Merge pull request #2141 from PhenomRetroShare/Fix_DataAccessReqDelWhenFailed
Fix RsGxsDataAccess req delete when failed.
2021-01-14 21:42:35 +01:00
csoler
3decd2b768
Merge pull request #2137 from PhenomRetroShare/Add_HandleTokenStatus
Add ability to manage canceled token in Gxs.
2021-01-14 19:50:55 +01:00
csoler
af696639cc fixed channel UI so that comment label is only shown when a new comment is here 2021-01-12 22:31:59 +01:00
csoler
7b2f6a3439
Merge pull request #2213 from jolavillette/bandwidthOptim
bandwith management optimization
2021-01-12 19:35:43 +01:00
jolavillette
df7de80914 restore smooth increase of up bw, and restore the use of the maximum down bw advertised by peer via BwCtrl 2021-01-12 10:12:11 +01:00
csoler
d92132d025
Merge pull request #2211 from csoler/v0.6-BugFixing_5
Various bug fixes
2021-01-11 20:12:01 +01:00
csoler
faa09ea55a fixed small memleak in authssl 2021-01-10 21:09:14 +01:00
csoler
78628a1842 fixed mem leak in p3MsgService 2021-01-10 20:52:58 +01:00
csoler
0f9aa519a5 added proper check for size w.r.t. RsSerialiser::MAX_SERIAL_SIZE before publishing GXS message, and proper handling of error if de-deserialization produces an item that is too large as well 2021-01-10 20:32:30 +01:00
jolavillette
45a1c7af24 bandwith management optimization 2021-01-10 15:55:38 +01:00
csoler
453c656570 fixed the status of signature vs. making friends, and fixed the deadlock when signing a certificate 2021-01-09 14:24:04 +01:00
csoler
d7fbe29a56 sorted out the mess with various calls to clear/cache PGP passphrase that resulted in the passphrase staying in memory 2021-01-08 23:43:59 +01:00
Phenom
ec32ec9983 Add ability to manage canceled token in Gxs. 2021-01-08 15:49:22 +01:00
csoler
3ee9408c00 fixed compilation with rs_deep_channels_index 2021-01-08 13:28:27 +01:00
csoler
d0b8c7dd69
Merge pull request #2203 from csoler/v0.6-CacheTests_2
Cache tests 2
2021-01-07 18:07:55 +01:00
csoler
ce4a0de6df fixed normal checking/cleaning periods 2021-01-06 23:09:50 +01:00
csoler
c3988e986f only call the costly part of db checking when deep-indexing is needed 2021-01-06 21:48:18 +01:00
csoler
839a82450e made GxsUtil check a static method 2021-01-06 21:47:46 +01:00
csoler
6d11abc0f3 added single call for db check at time of db creation 2021-01-05 20:35:58 +01:00
csoler
2124c0935d fixed stupid mistake 2021-01-05 14:51:24 +01:00
csoler
94afc17629 added more debug output 2021-01-04 21:24:06 +01:00
csoler
d0dffaa2a4 removed display of "Dead" elements in cache since they are no longer used 2021-01-04 13:57:54 +01:00
csoler
f1ccfb4d57 removed double-return 2021-01-03 21:24:15 +01:00
csoler
ec0f56f0ae
Merge pull request #2194 from jolavillette/ChatroomStatus
speed up status display of participants in chatrooms
2021-01-03 15:41:38 +01:00
csoler
ef21db0a0a fixed bug causing bad cache update 2021-01-02 23:56:26 +01:00
csoler
a6010beab3 Merge remote-tracking branch 'upstream/master' into v0.6-CacheTests 2021-01-02 22:25:10 +01:00
csoler
aad542e3a5 trick to avoid creating new memoty when cache is not used 2021-01-02 22:24:13 +01:00
hunbernd
a97d0ff15c Fix: DHT cannot bootstrap if bdboot.txt is corrupted.
If the bdboot.txt file is broken in profile folder, attempt to load the data from the file installed with RS.
2021-01-02 18:44:32 +01:00
csoler
71f2e273ea moved all metadata cache switches into DataStore as a single internal variable 2021-01-01 23:36:16 +01:00
csoler
06ed1e3e97
Merge pull request #2175 from csoler/v0.6-BugFixing_2
v0.6.6-RC2 fixes
2020-12-31 13:19:02 +01:00
csoler
637d5f360a fixed extra delete after storeGroup and storeMessage 2020-12-30 21:41:47 +01:00
csoler
c3f4e1babc
Merge pull request #2189 from PhenomRetroShare/Fix_UninitGxsTunnelPeerInfo
Fix Uninit in GxsTunnelPeerInfo
2020-12-30 21:00:01 +01:00
csoler
159a2061f6
Merge pull request #2182 from csoler/v0.6-MemLeaks
Fixing mem leaks
2020-12-30 20:58:32 +01:00
csoler
4916c3925f renamed mispelled functions 2020-12-30 20:16:44 +01:00
csoler
1fe3664007 fixed bug causing GXS sync to fail and crash 2020-12-30 20:16:25 +01:00
jolavillette
4aaae99a52 speed up status display of participants in chatrooms 2020-12-30 16:06:12 +01:00
Phenom
ac4b7334dd Fix ValGrind error in PGPHandler::locked_writePrivateTrustDatabase
Syscall param write(buf) points to uninitialised byte(s)
  in PGPHandler::locked_writePrivateTrustDatabase() in /libretroshare/
src/pgp/pgphandler.cc:1885
  1: write in /usr/lib/libc-2.32.so
  2: _IO_file_write@@GLIBC_2.2.5 in /usr/lib/libc-2.32.so
  3: new_do_write in /usr/lib/libc-2.32.so
  4: _IO_do_write@@GLIBC_2.2.5 in /usr/lib/libc-2.32.so
  5: _IO_file_close_it@@GLIBC_2.2.5 in /usr/lib/libc-2.32.so
  6: fclose@@GLIBC_2.2.5 in /usr/lib/libc-2.32.so
  7: PGPHandler::locked_writePrivateTrustDatabase() in /libretroshare/
src/pgp/pgphandler.cc:1885
  8: PGPHandler::locked_syncTrustDatabase() in /libretroshare/src/pgp/
pgphandler.cc:1987
  9: PGPHandler::syncDatabase() in /libretroshare/src/pgp/pgphandler.cc:
1909
  10: AuthGPG::threadTick() in /libretroshare/src/pqi/authgpg.cc:207
  11: RsTickingThread::run() in /libretroshare/src/util/rsthreads.h:314
  12: RsThread::wrapRun() in /libretroshare/src/util/rsthreads.cc:116
  13: RsThread::rsthread_init(void*) in /libretroshare/src/util/
rsthreads.cc:84
  14: start_thread in /usr/lib/libpthread-2.32.so
  15: clone in /usr/lib/libc-2.32.so
Address 0xcb70379 is 9 bytes inside a block of size 4,096 alloc'd  1:
malloc in /build/valgrind/src/valgrind-3.16.1/coregrind/m_replacemalloc/
vg_replace_malloc.c:307
  2: _IO_file_doallocate in /usr/lib/libc-2.32.so
  3: _IO_doallocbuf in /usr/lib/libc-2.32.so
  4: _IO_file_overflow@@GLIBC_2.2.5 in /usr/lib/libc-2.32.so
  5: _IO_file_xsputn@@GLIBC_2.2.5 in /usr/lib/libc-2.32.so
  6: fwrite in /usr/lib/libc-2.32.so
  7: PGPHandler::locked_writePrivateTrustDatabase() in /libretroshare/
src/pgp/pgphandler.cc:1877
  8: PGPHandler::locked_syncTrustDatabase() in /libretroshare/src/pgp/
pgphandler.cc:1987
  9: PGPHandler::syncDatabase() in /libretroshare/src/pgp/pgphandler.cc:
1909
  10: AuthGPG::threadTick() in /libretroshare/src/pqi/authgpg.cc:207
  11: RsTickingThread::run() in /libretroshare/src/util/rsthreads.h:314
  12: RsThread::wrapRun() in /libretroshare/src/util/rsthreads.cc:116
  13: RsThread::rsthread_init(void*) in /libretroshare/src/util/
rsthreads.cc:84
  14: start_thread in /usr/lib/libpthread-2.32.so
  15: clone in /usr/lib/libc-2.32.so
Uninitialised value was created by a stack allocation  1:
PGPHandler::locked_writePrivateTrustDatabase() in /libretroshare/src/
pgp/pgphandler.cc:1855
2020-12-29 13:05:41 +01:00
Phenom
308fa78307 Fix Uninit in GxsTunnelPeerInfo 2020-12-29 12:23:18 +01:00
csoler
a40c54950c fixed bug due to double free 2020-12-27 00:12:13 +01:00
csoler
5ff58e6a5f added params to disable the use of cache when retrieving msg and grp data and metadata. Made GxsUtil::check() not use the cache 2020-12-26 23:35:39 +01:00
csoler
22ceec6c43 replaced GxsMetaData pointers by shared_ptrs in dataaccess and dataservice, so that we can easily disable caching, more freely get rid of cache items, and have a simpler memory management scheme 2020-12-26 23:13:17 +01:00
csoler
2a3fa76256 added missing delete of X509 cert at loading time 2020-12-23 21:12:05 +01:00
csoler
d28665df18 added missing delete in authssl.cc 2020-12-23 20:47:28 +01:00
csoler
25041c694b fixed previous commit with remaining deletes and shared_ptr that messed the whole thing 2020-12-22 22:51:17 +01:00
csoler
68d7edd405 fixed leak in gossipDiscovery 2020-12-22 20:15:45 +01:00
csoler
d5aa8dd9f3 fixed wrong message code in rsEvent call from p3msgservice 2020-12-20 16:40:21 +01:00
defnax
43d953b992
Merge pull request #2168 from PhenomRetroShare/Fix_SystemMessageSender
Fix System Message Sender
2020-12-20 15:44:38 +01:00
csoler
e8d6632473 fixed bug in debug_printCacheSize() that was actually corrupting the cache 2020-12-19 21:11:13 +01:00
Phenom
d1ba81e50f Fix System Message Sender 2020-12-16 16:17:44 +01:00
csoler
63bc384ae7 switched to RC2 2020-12-15 21:29:11 +01:00
csoler
733b059571
Merge pull request #2161 from csoler/v0.6-BugFixing_5
V0.6 bug fixing 5
2020-12-15 20:50:14 +01:00
Phenom
4340b1a04a Fix Friend Request Toaster 2020-12-14 17:33:08 +01:00
csoler
aad27ff94b renamed "count" to "size" in DirDetails 2020-12-13 20:03:21 +01:00
csoler
335a90cc92 added internal update of total size for directories and display in GUI 2020-12-13 18:15:14 +01:00
csoler
d112357b77
Merge pull request #2158 from csoler/v0.6-BugFixing_5
Mem leaks fixing and cpu optimization
2020-12-12 19:57:18 +01:00
csoler
7b2f7f2e0e fixed mem leak in rsgxstunnel.cc 2020-12-10 20:23:23 +01:00
csoler
9a6835bf06 fixed memory leak in RsGenExchange 2020-12-10 20:15:53 +01:00
csoler
0f55d73b69 fixed quadratic search in GxsUtil check routine 2020-12-09 23:31:40 +01:00
csoler
e3c2b644b3
Merge pull request #2154 from csoler/v0.6-BugFixing_5
fixed missing delete in generic_sendData() causing a memory leak
2020-12-09 23:06:06 +01:00
csoler
50ad409e26
Merge pull request #2150 from PhenomRetroShare/Fix_RsMutexDebug
Fix RsMutex Debug and add rs_mutex_debug qmake option.
2020-12-09 23:04:51 +01:00
csoler
906c1f03e4
Merge pull request #2147 from csoler/v0.6-BugFixing_2
Still bug fixing 0.6.6-RC1
2020-12-09 22:58:13 +01:00
csoler
758aaffbd0 fixed missing delete in generic_sendData() causing a memory leak 2020-12-09 22:55:15 +01:00
Phenom
82bd8d5f6a Fix CONFIG with rs_deep_channels_index 2020-12-09 16:10:17 +01:00
csoler
4ddcf3c0bb removed double call to delete groups and delete msgs (left after previous changes). Improved output when checking groups/msgs 2020-12-08 23:57:30 +01:00
csoler
ed5f8618b6 fixed bug in mutexes causing a deadlock in gxs integrity check 2020-12-08 23:45:31 +01:00
Phenom
2ff3d83c30 Fix RsMutex Debug and add rs_mutex_debug qmake option. 2020-12-08 17:15:16 +01:00
Phenom
5f67710f16 Fix RsGxsDataAccess req delete when failed. 2020-12-07 14:47:57 +01:00
csoler
931be5dc6d fixed update of forum and circle lists when forum/circle is edited 2020-12-06 21:29:56 +01:00
csoler
dbd6477acd fixed bug in circle chooser that showed duplicates. Removed mCircleExternalIdList (not really useful now that circles are cached) and used a std::set to ensure uniqueness 2020-12-05 20:12:03 +01:00
csoler
08e264913d
Merge pull request #2143 from csoler/v0.6-BugFixing_4
V0.6 bug fixing 4
2020-12-05 16:15:11 +01:00
csoler
9533fc9c00 added notification when new extra file is shared, so that shared files updates 2020-12-04 16:33:12 +01:00
csoler
ba7bac4284 removed debug info 2020-12-03 23:33:22 +01:00
csoler
d2dad59b54 added sending of group authors along with group data in distant GXS search 2020-12-03 23:13:18 +01:00
csoler
fa20b9b254 simplified GxsIntegrityCheck, in hope that it will remove the crashes. Also moved the deletion to async RsGenExchange, so as to get the proper notifications 2020-12-01 20:34:23 +01:00
csoler
a4e3f98a09 Merge remote-tracking branch 'upstream/master' into v0.6-BugFixing_2 2020-12-01 19:45:30 +01:00
csoler
bcb43cb9a1 fixed bug in Gxs cleaning code 2020-12-01 14:43:23 +01:00
csoler
a3b7dbe55e fixed merge 2020-12-01 09:35:11 +01:00
csoler
ac7e2b5582 fixed redraw of channels and boards info when editing the group data 2020-11-28 23:10:40 +01:00
csoler
d842c6fe52 Merge remote-tracking branch 'upstream/master' into v0.6-BugFixing_4 2020-11-28 21:34:32 +01:00
csoler
0a78d27cae Merge remote-tracking branch 'upstream/master' into v0.6-BugFixing_2 2020-11-28 21:28:16 +01:00
csoler
1e53bf3b77 fixed auto-DL from trusted identities 2020-11-28 16:51:31 +01:00
jolavillette
9324d9de6c More optimization of priorities 2020-11-26 20:29:51 +01:00
jolavillette
e8691e9b0f Priority optimization and fixes 2020-11-26 20:29:51 +01:00
csoler
41357489c0
Merge pull request #2127 from PhenomRetroShare/Add_PID_InLockFile
Add current PID in Lock file.
2020-11-26 20:18:53 +01:00
csoler
cb995f3aff reverted back cleanup period to 59 mins 2020-11-26 20:07:16 +01:00
csoler
5a7f95f443 fixed deletion of groups using the proper method in RsGenExchange, and disabled debug output 2020-11-26 20:03:03 +01:00
csoler
b820057064
Merge pull request #2128 from PhenomRetroShare/Fix_RsItemDeserialiseTooSmall
Fix rs item deserialise too small
2020-11-26 20:01:41 +01:00
Phenom
3fff0869a2 Fix Valgrind report at End of RS
XXXX bytes in XX blocks are still reachable in loss record.
2020-11-26 19:13:54 +01:00
csoler
bce514115d added proper notifications when a group is deleted 2020-11-25 23:35:20 +01:00
csoler
f21b57b643 fixed a few bugs in checking for unused groups 2020-11-25 23:03:25 +01:00
Phenom
0ae073d073 Fix RsItem deserialise when they are too small (< 8 bytes). 2020-11-25 15:35:21 +01:00
csoler
be1728d535
Merge pull request #2120 from csoler/v0.6-BugFixing_2
Trying to optimize circles and prevent the spread of unwanted/useless circles
2020-11-24 18:40:49 +01:00
csoler
fc8604154b cancelled commit c1c6d33 because PR2122 provides a more advanced set 2020-11-24 18:39:21 +01:00
csoler
2c7ee7ebeb added logic to keep track of circles activity from friend nodes and the methods to estimate when circles are not used 2020-11-24 18:33:16 +01:00
Phenom
cf0360a172 Add current PID in Lock file. 2020-11-24 15:57:43 +01:00
thunder2
e9298c16bc Fixed linking with enabled libretroshare_shared with msys2 2020-11-23 21:04:18 +01:00
csoler
2fd15134c9 added auto-cleaning of unused forums, channels, posted. Works for all GXS groups if the correct method is supplied. 2020-11-22 21:45:21 +01:00
csoler
c1c6d33add new experimental set of priorities accounting for more recent statistics 2020-11-21 15:57:45 +01:00
csoler
1058989c5b added some info about circles subscribe and membership system 2020-11-21 15:12:50 +01:00
csoler
115dd1cf5f removed unused variable _item_count in pqiqos 2020-11-20 10:33:18 +01:00
csoler
e15058d14c optimization in circles: now only auto-subscribe when a own msg is present 2020-11-19 23:43:47 +01:00
csoler
11c71d16ab
Merge pull request #2115 from csoler/v0.6-BugFixing_2
Bug fixing for 0.6.6
2020-11-18 19:57:48 +01:00
Gioacchino Mazzurco
d473f1be3f
Fix JSON API compilation 2020-11-16 12:44:10 +01:00
csoler
7db8400233 disable limit of forward time checking for validating signatures 2020-11-15 21:22:25 +01:00
csoler
f9bb886c27 fixed bug in circles causing missing identities to block circle interaction in UI and data send/recv 2020-11-14 23:40:03 +01:00
csoler
f8721ad60f Merge remote-tracking branch 'upstream/master' into v0.6-BugFixing_2 2020-11-12 23:17:55 +01:00
csoler
3d958a7592 moved event to the right place for detecting change in local address 2020-11-11 22:43:07 +01:00
csoler
9a2749dbe5 added flags to invite system to unify the different variables and made sure the HomePage contains at least current IP (not fully tested) 2020-11-09 22:42:28 +01:00
thunder2
76b22ada5c Added new config "libretroshare_shared" to build libretroshare as shared library (default off) based on changes from ET. Activated for Windows build with plugins to fix the link error (ld.exe: Error: export ordinal too large) due to too many exported symbols. 2020-11-09 20:00:50 +01:00
thunder2
1895abfb24 Changed updating submodules for Windows build. Use "cd /D" to change directory. 2020-11-09 16:16:29 +01:00
csoler
d2bd947252 fixed bug due to passing shared_ptr to RsThread::async() without making an explicit copy before 2020-11-08 18:25:20 +01:00
csoler
d472053960 fixed missing call to update comments in GxsChannelPostsModel 2020-11-08 14:57:17 +01:00
csoler
08e2987154 added icon over posts with comments in channels 2020-11-07 20:52:50 +01:00
Phenom
b1129df077 Change Chat History Dialog to no modal.
It will be updated when new message comes.
2020-11-07 18:09:50 +01:00
csoler
3cac0c030d added NEW_COMMENT and NEW_VOTE to rsEvents types in Posted and Channels 2020-11-07 16:55:15 +01:00
csoler
dc90d6f6dc renamed SSGXSChannelGroup to GxsChannelGroupInfo, mCount in RsGxsChannelPost to mAttachmentCount and added a mCommentCount member. Also added some missing override in p3gxschannels.cc 2020-11-06 23:08:18 +01:00
csoler
1dd54317c7 fixed pinned post immediate update by adding the proper rsEvent notification when updating own group data. Should also help in circles 2020-11-04 22:30:30 +01:00
Gioacchino Mazzurco
079180c790
Fix compilation with libupnp 1.14.0
Based of sehraf patch https://github.com/RetroShare/RetroShare/issues/2072#issuecomment-703299870
2020-11-03 17:53:52 +01:00
csoler
b5cfa46073 fixed missed notification in Messages when new/draft msg happens by switching to new event system 2020-10-28 21:26:07 +01:00
csoler
74edefcc43 added infrastructure to track oingoing distant GXS group requests 2020-10-25 22:47:48 +01:00
csoler
c30107c248 added up-to-date info about sync period in group data details (channels, boards, forums) and warning when the sync period is too small w.r.t. the date of last post 2020-10-24 21:17:34 +02:00
csoler
4199b1a02f switched to 0.6.6 2020-10-15 20:41:36 +02:00
csoler
ce6fb603c7
Merge pull request #2026 from csoler/v0.6-BoardsGUI
V0.6 boards gui
2020-10-12 20:07:42 +02:00
csoler
1170f0bc7b Merge remote-tracking branch 'upstream/master' into v0.6-BoardsGUI 2020-10-10 23:12:58 +02:00
csoler
74660b916a Merge remote-tracking branch 'upstream/master' into v0.6-TorV3 2020-10-10 23:12:27 +02:00
Gioacchino Mazzurco
eca11d0885
retroshare-gui: fix missing include in jsonapipage
Fix compile error, warnings and typo
2020-10-07 10:58:52 +02:00
csoler
3912c6562e fixed bugs causing short invites to not generate/parse hidden nodes with correct options to keep hidden address 2020-10-06 23:02:00 +02:00
sehraf
26d0443ff9
fixed Cyrils remarks 2020-10-04 20:41:34 +02:00
sehraf
26fdd79b50
Merge remote-tracking branch 'RetroShare/master' into pr_rsconfig 2020-10-04 20:25:06 +02:00
csoler
5dfa481f2f added code to change posts read status 2020-09-22 23:32:10 +02:00
csoler
0e4d438066 fixed model update when new vote is posted by user 2020-09-17 21:08:07 +02:00
csoler
5915c27b9f merged upstream 2020-09-11 22:37:26 +02:00
csoler
6e3f42381e
Merge pull request #2060 from csoler/v0.6-BugFixing_2
UI Bug fixing
2020-09-11 21:21:47 +02:00
csoler
a4d3848547 Hidden nodes always drop IP information from normal nodes. 2020-09-05 10:29:12 +02:00
csoler
05daa0387b added some debug info in p3gxschannels.cc 2020-09-03 20:53:57 +02:00
csoler
97762093ce added missing initialization of write-only pointer that causes error in RsTypeSerializer 2020-09-01 22:34:56 +02:00
csoler
e2a04c1baa
Merge pull request #2059 from G10h4ck/stubborn_post
Forum add API to mark a post to be kept forever
2020-09-01 22:28:10 +02:00
csoler
4e923bd8ad
Merge pull request #2057 from G10h4ck/rm_deadcode
Remove a bunch of deadcode
2020-09-01 22:25:29 +02:00
Gioacchino Mazzurco
06d8476120
Forum add API to mark a post to be kept forever
This way the post never get deleted even when older then  parent group
  maximum storage time
2020-09-01 16:15:49 +02:00
Gioacchino Mazzurco
4a81f7f5db
Remove documentation for param which doesn't exists anymore 2020-09-01 15:36:47 +02:00
Gioacchino Mazzurco
162028abd0
Remove a bunch of deadcode 2020-09-01 12:01:38 +02:00
csoler
fa72af4d0c merged upstream/master 2020-08-25 11:52:06 +02:00
csoler
bb6706e996 added missing destructor in MsgMetaCache 2020-08-15 18:54:00 +02:00