Commit Graph

1319 Commits

Author SHA1 Message Date
csoler
d8569d813c
switched security items to new notification system 2019-12-01 22:35:16 +01:00
csoler
4a257614f1
merged with upstream/master 2019-11-24 18:38:50 +01:00
csoler
d19d1685de
made JsonApiServer an singleton through static method instance() 2019-11-12 22:32:18 +01:00
Gioacchino Mazzurco
ca6071fa21
fixup! Improve RsUrl 2019-11-11 23:49:06 +01:00
Gioacchino Mazzurco
aabba04be9
Remove some cruft from p3peermgr 2019-11-07 19:47:23 +01:00
Gioacchino Mazzurco
48879d1f40
Remove some cruft 2019-10-31 11:29:16 +01:00
G10h4ck
63861ba942
Merge pull request #1659 from G10h4ck/netmgr_calmer
Calm down p3netmgr at least when internet connection is not available
2019-10-25 18:42:45 +02:00
csoler
438966979b
Merge pull request #1674 from G10h4ck/pqissludp_fixup
Fix double free crash in ~pqissludp()
2019-10-15 08:39:49 +02:00
defnax
cbfe49f0f3 added distant chat settings 2019-10-14 02:29:20 +02:00
Gioacchino Mazzurco
f86d20d4cd
Improve readibility of terrible if 2019-10-09 15:22:24 +02:00
Gioacchino Mazzurco
63b787a504
Fix double free crash in ~pqissludp()
Use POD type member intitialization for sockaddr_storage
Cleanup a bunch of clutter
2019-10-09 14:59:46 +02:00
Gioacchino Mazzurco
93bfbb6ede
Fix addSslOnlyFriend when adding with already known PGP
If the PGP key is available add as full friend.
Without this change when the PGP key of a non-friend is available
  the SSL-id is added in peer list but the PGP-id is not added as PGP
  friend, at same time skip_pgp_signature_validation is false, because
  we have the full PGP, so the connection attempt is refused, when it
  should be verified with PGP and accepted.
2019-10-09 02:06:55 +02:00
csoler
423f20231c
Merge pull request #1661 from G10h4ck/short_invites_fixup
Fix setting port when adding from short invite with dyndns
2019-10-03 09:40:28 +02:00
Gioacchino Mazzurco
b77924b368
Fix setting port when adding from short invite with dyndns 2019-10-01 17:43:52 +02:00
G10h4ck
1732177669
Merge pull request #1645 from G10h4ck/short_invites_fixes
Allow friend information  update from short invite
2019-09-30 23:37:55 +02:00
Gioacchino Mazzurco
6b71c57a54
Calm down p3netmgr at least when internet connection is not available
Solve compiler warnings, delete tons of cruft and deadcode
2019-09-29 17:59:32 +02:00
Gioacchino Mazzurco
6788ea041a
Avoid netReset() if no network address is available 2019-09-28 18:42:13 +02:00
Gioacchino Mazzurco
4e3ac4a9f4
Make SSL-only friend criteria stricter 2019-09-28 14:15:12 +02:00
Gioacchino Mazzurco
5660c73175
Allow friend information update from short invite
Add comments explaining security of addSslOnlyFriend
2019-09-28 10:36:33 +02:00
Gioacchino Mazzurco
1705a930d4
getLocalAddresses should not need Qt for android >= 24 2019-09-25 22:15:07 +02:00
csoler
24781a71f5
removed unused mOthersList from PeerMgr 2019-09-23 21:32:28 +02:00
csoler
9b78447109
used RsInfo instead of std::cerr in authssl.cc 2019-09-22 17:36:08 +02:00
csoler
9c7edffc21
fixed bug caused by shadowing a variable 2019-09-22 16:34:01 +02:00
csoler
6919711f48
restricted check for matching PGP ids to short invites only, since otherwise the call to isGPGAccepted() will rule out wrong IDs anyway 2019-09-21 22:20:33 +02:00
csoler
ed864f9470
removed some debug info about PGP signature validation, and added the ability to accept fingerprint instead of ID in the handshake 2019-09-21 19:00:52 +02:00
csoler
4fabf3deb1
renamed skip_signature_validation into more appropriate skip_pgp_signature_validation 2019-09-19 21:14:57 +02:00
csoler
654d760d84
fixed comments from review of PR 2019-09-19 20:59:35 +02:00
csoler
32b4312725
improved security checks in authssl by verifying that the supplied PGP id is the one the peer has been registered with 2019-09-17 22:14:32 +02:00
csoler
a20ec1a885
fixed exchange of PGP keys in binary format and update of PGP signature flags on short invites when the key is received 2019-09-14 15:33:43 +02:00
csoler
bbf92bd5f3
fixed remanent bug due causing the deletion of rsEvent 2019-09-10 21:59:25 +02:00
csoler
dd90314c3d
fixed missing type conversion 2019-09-08 20:49:38 +02:00
csoler
6419b03a2a
merged upstream/master 2019-09-08 20:35:23 +02:00
csoler
15e43dce01
proper handling of peer connections notifications 2019-08-21 22:39:07 +02:00
csoler
fb52f6717c
fixed up addign friend from short invite 2019-06-09 23:49:31 +02:00
Gioacchino Mazzurco
8d6c83ac7f
Fix missing location regression interoduced in 41d4599f 2019-06-08 12:42:28 +02:00
csoler
8fddb559b9
fixed stupid bug that crashed the code in a different place 2019-05-27 21:48:47 +02:00
csoler
4eb6b0b066
fixed uninitialized memory read for variable mRsEventsHandle 2019-05-26 17:08:36 +02:00
csoler
56e591f728
added a flag in peerState specific to short invites, and several checks for consistency 2019-05-22 21:46:11 +02:00
csoler
dac76439bd
Merge pull request #1565 from G10h4ck/short_invites_v2
Short invites support for libretroshare
2019-05-21 21:32:05 +02:00
Gioacchino Mazzurco
720d5ea8a6
Implement libretroshare short invites support 2019-05-16 22:13:12 +02:00
Gioacchino Mazzurco
fb4be22f0e
Prepare RsBanList for JSON API support 2019-05-14 23:01:06 +02:00
csoler
ebd55b2626
Merge pull request #1559 from G10h4ck/autssl_refinement
Cleanup huge amount of AuthSSL and related files cruft
2019-05-14 22:55:34 +02:00
Gioacchino Mazzurco
16d606b513
refactor LoadCheckX509 into safer AuthSSL::parseX509DetailsFromFile 2019-05-14 22:05:42 +02:00
Gioacchino Mazzurco
0c097c2080
Rename redundant to double in guarding macros 2019-05-14 21:33:08 +02:00
Gioacchino Mazzurco
c8082fdcc2
Add PGP verification info message 2019-05-14 15:12:39 +02:00
Gioacchino Mazzurco
0eee4adaa8
Add forgot define enabling banlist redundant check 2019-05-14 14:47:33 +02:00
Gioacchino Mazzurco
1599689eab
PQI redundant check behave the same as authssl check 2019-05-14 11:43:18 +02:00
csoler
6a18e242bb
added compile option to use sanitizer and already fixed a few misalignment errors with it 2019-05-11 22:25:02 +02:00
Gioacchino Mazzurco
f9f7e0df18
pqi free x509 cert even before exit
Avoid risk of introducing memory leak if we change the behaviour code from exit
  to return in the future
2019-05-07 12:11:38 +02:00
Gioacchino Mazzurco
2975fa5446
p3LinkMgr remove address age check in wrong place
The age check was causing some address were ignored during connect attempt,
  this was disastrous expecially for sporadic users which completely
  lost capability to connect to any node, even if the IPs neve changes!

Old addresses triagin is handled elsewhere so ignoring them in connect attempt
  only generate very counter-intuitive situations for the user, as
  addressed still listed in potential address list were never attempted.
2019-05-03 17:13:04 +02:00
Gioacchino Mazzurco
41d4599fe3
Cleanup huge amount of AuthSSL cruft
Make reduntant auth check in pqi effective (even if redundant only
  siganture was checked but friendess wasn't)
Evidence redundant auth check in pqi by putting it inside #ifdef this
  way the beaviior being the same with and without redundat check can be
  verified easier
Solve lot of compiler warnings and made code more readable
Remove dangerous sslcert wrapper
Remove misleading messeges and notification about peer not giving cert,
  FailedCertificate logic is wrong since many years as authentication is
  fully handled inside VerifyX509Callback
2019-05-03 17:05:49 +02:00
Gioacchino Mazzurco
de0dd63e3f
Remove a bunch of deadcode
RsSerializable already provide std::ostream &operator<<
Add deprecation notice for RsNotify
2019-05-03 16:55:57 +02:00
G10h4ck
9102a698e4
Merge branch 'master' into Fix_ClangWarnings 2019-04-23 12:45:33 +02:00
Gioacchino Mazzurco
4d703b9df9
Increase waitToken interval for channel creation
Creating GXS groups imply a bunch of crypto operations that require lot
  of time expecially on embedded device, channel creation was reported
  as failed while it was still pending.
Reduce too long lines.
Print API error messages also on std::cerr.
2019-04-12 22:14:16 +02:00
csoler
322334b076
fixed compilation warning 2019-04-11 21:04:29 +02:00
csoler
43a5312194
Merge pull request #1509 from RetroPooh/trafcount
display session traffic
2019-04-10 21:04:53 +02:00
Phenom
78f9bbfd75 Fix clang warning for
../../../trunk/libretroshare/src/pqi/authssl.cc:57:16: warning: unused
variable 'RS_SSL_HANDSHAKE_DIAGNOSTIC_KEY_ALGORITHM_NOT_ACCEPTED' [-
Wunused-const-variable]
const uint32_t RS_SSL_HANDSHAKE_DIAGNOSTIC_KEY_ALGORITHM_NOT_ACCEPTED  =
0x08 ;
               ^
2019-04-04 21:20:25 +02:00
RetroPooh
7504964899 display session traffic 2019-04-03 17:29:13 +03:00
G10h4ck
c4a0c18b18
Merge pull request #1317 from sehraf/pr_further_improve_fulltype
further conversion to new wrapper function
2019-02-13 22:21:17 -03:00
csoler
630609c11c
fixed retroshare.project email in licenses 2018-11-11 20:42:48 +01:00
csoler
602bc36eec
fixed missing licenses in libretroshare 2018-11-11 14:24:47 +01:00
csoler
98bf2922cb
removed old/unused files 2018-11-11 14:24:47 +01:00
Gioacchino Mazzurco
7d6fba7e8c
Attempt to fix crash in pqissludp
Caused by unneeded pointer usages + not enough careful IPv6 porting

I haven't managed to reproduce the crash nor to test the fix due it
happening only when UDP relayed connection happens (apparently never on
my nodes.

I have managed to discover where the bug comes from thanks to multiple
user reports, specially to Ilario report which documented 3 crashes
happening on 0.6.4 with complete log.
2018-11-04 00:09:28 +01:00
csoler
33b39a8be6
removed uninitialized memory read in determination of own IP 2018-11-01 22:05:22 +01:00
csoler
cb5d247565
removed unnecessry debug output from pqissl 2018-11-01 21:45:59 +01:00
Gioacchino Mazzurco
e5805e9047
Avoid external port being reset without necessity
Fix RetroSahre behaviour when manually configured external port is
  different to local port
2018-10-24 05:39:31 +02:00
G10h4ck
047ae7f723
Merge branch 'master' into jsonapi 2018-10-10 22:23:28 +02:00
csoler
09b109d522
Merge pull request #1364 from G10h4ck/safer_time
Use safer rstime_t instead of time_t
2018-10-10 22:03:51 +02:00
Gioacchino Mazzurco
329050a9c2
Use safer rstime_t instead of time_t
Avoid problems to serialization on different platforms, without breaking
nested STL containers serialization.

The conversion have been made with sed, and checked with grep, plus
kdiff3 visual ispection, plus rutime tests, so it should be fine.
2018-10-07 13:07:06 +02:00
csoler
586cff2ad1
Merge pull request #1362 from csoler/v0.6-ImprovedGUI
V0.6 improved gui
2018-10-06 18:33:13 +02:00
csoler
045691855b
Merge pull request #1356 from PhenomRetroShare/Fix_Warnings
Fix warnings
2018-10-06 18:31:33 +02:00
csoler
ec8e8ebafa
fixed merging with upstream/master 2018-10-05 21:38:36 +02:00
csoler
dbd52c0c9c
fixed bug in previous commit 2018-10-05 17:01:54 +02:00
csoler
4de0498208
fixed bad signature checking code for config files 2018-10-05 16:54:36 +02:00
Gioacchino Mazzurco
1d8bb44811
Fix warnings 2018-10-05 01:55:18 +02:00
csoler
c6d0203557
added debug output to see which config files are loaded/saved 2018-10-04 19:22:49 +02:00
Gioacchino Mazzurco
7cc15c703c
Fix forward declarations class struct missmatch 2018-10-03 19:07:46 +02:00
Phenom
6ef72f551d Fix Gcc Warning in authssl.cc
/libretroshare/src/pqi/authssl.cc:160: warning: ‘void
dyn_destroy_function(CRYPTO_dynlock_value*, const char*, int)’ defined
but not used [-Wunused-function]
 static void dyn_destroy_function(struct CRYPTO_dynlock_value *l, const
char */*file*/, int /*line*/)
/libretroshare/src/pqi/authssl.cc:143: warning: ‘void
dyn_lock_function(int, CRYPTO_dynlock_value*, const char*, int)’ defined
but not used [-Wunused-function]
 static void dyn_lock_function(int mode, struct CRYPTO_dynlock_value *l,
const char */*file*/, int /*line*/)
/libretroshare/src/pqi/authssl.cc:121: warning: ‘CRYPTO_dynlock_value*
dyn_create_function(const char*, int)’ defined but not used [-Wunused-
function]
 static struct CRYPTO_dynlock_value *dyn_create_function(const char */
*file*/, int /*line*/)
/libretroshare/src/pqi/authssl.cc:106: warning: ‘long unsigned int
id_function()’ defined but not used [-Wunused-function]
 static unsigned long id_function(void)
/libretroshare/src/pqi/authssl.cc:92: warning: ‘void
locking_function(int, int, const char*, int)’ defined but not used [-
Wunused-function]
 static void locking_function(int mode, int n, const char */*file*/, int
/*line*/)
2018-09-30 15:10:40 +02:00
Gioacchino Mazzurco
eb77f921ec
Implement JSON API HTTP Basic authentication
jsonapi-generator is now capable of generating API for headers outside
  retroshare/ directory
jsonapi-generator do a bit of methods parameter sanity check
JsonApiServer is now integrated in the rsinit hell like other services
Add *::exportGPGKeyPairToString to a bunch of classes in cascade
RsControl is now capable of calling back a function when retroshare is almost
  completely stopped, this is useful when running retroshare toghether with
  externally managed runloop such as QCoreApplication
Expose a bunch of methods through JSON API
retroshare-nogui remove some dead code and fix stopping from the RetroShare API
2018-09-19 21:28:26 +02:00
sehraf
0b6644cd55
get rid of unused variables 2018-09-15 14:38:57 +02:00
sehraf
1e85b05f09
get rid of cipher_version variable. use plain output from openssl 2018-09-15 14:37:40 +02:00
sehraf
7ce2bef37b
add support for displaying TLSv1.3 2018-09-14 16:27:50 +02:00
csoler
65304a301a
added last relay (a.k.a which direct friend) of search results in sources column 2018-08-28 23:57:16 +02:00
Gioacchino Mazzurco
396fe49312
Merge branch 'master' into jsonapi 2018-08-22 16:59:42 +02:00
sehraf
a556965813
further conversion to new wrapper function 2018-08-03 20:19:10 +02:00
sehraf
97194fd092
Add wrapper function to convert uint16_t service IDs to internal unsigned int.
Use it when looking up service names.
2018-08-01 20:47:02 +02:00
csoler
d1a375cbd0
removed RETROTOR #ifdef and started using RsAccounts::isTorAuto() instead. Unfinished yet. 2018-07-25 11:37:40 +02:00
Gioacchino Mazzurco
130007b578
Merge branch 'master' into jsonapi 2018-07-23 13:44:01 +02:00
csoler
2bab688dec
fixed merge with upstream/master 2018-07-19 23:22:24 +02:00
csoler
b8062f2e21
Merge pull request #1294 from csoler/v0.6-GXS-DistSync3-TurtleSearch
V0.6 gxs dist sync3 turtle search
2018-07-19 22:59:43 +02:00
csoler
dac885e24d
made randomBias initilized with true random bytes at start 2018-07-18 21:22:38 +02:00
csoler
6848a586f3
merged upstream/master 2018-07-08 21:17:48 +02:00
chelovechishko
b3dddeafdf add missing namespaces 2018-07-06 23:55:12 +09:00
csoler
0c45217fc0
merged upstream/master 2018-07-05 17:41:30 +02:00
Gioacchino Mazzurco
1dd707710b
Merge branch 'master' into extra_locators_merge 2018-07-02 12:22:23 +02:00
Gioacchino Mazzurco
d14a455cf1
jsonapi-generator fix support for void methods
Thanks sehraf for reporting
retroshare://forum?name=fucking%20genius&id=8fd22bd8f99754461e7ba1ca8a727995&msgid=503d75bf7ed7fa7568eeae4db5c8d31a7e124c98
2018-06-26 22:01:17 +02:00
csoler
5b9666855d
fixed merge with upstream 2018-06-22 23:38:31 +02:00
cyril soler
8edb1f7535 fixed problem causing infinite loop of net reset in p3NetMgr 2018-06-08 14:32:56 +02:00
csoler
7caf06b57d
added structures for generic turtle search and access functions in Gxs objects 2018-06-06 23:15:29 +02:00
csoler
90d7f55c40
finished implementing GXS search items 2018-05-31 15:41:54 +02:00